diff options
author | Roel Kluin <roel.kluin@gmail.com> | 2009-01-02 11:32:55 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-01-02 13:16:38 -0500 |
commit | a234b1103f7df35eacb1de7a9d15a636046e263b (patch) | |
tree | d03973e328ed12a7b12057c7430bcf5d128ca105 /drivers/scsi/libsas | |
parent | d38f47a977e5d314a2e21db0806ca4f76cb0576b (diff) |
[SCSI] libsas: fix test for negative unsigned and typos
unsigned req->data_len cannot be negative, and fix =-/-= typo
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/libsas')
-rw-r--r-- | drivers/scsi/libsas/sas_host_smp.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/scsi/libsas/sas_host_smp.c b/drivers/scsi/libsas/sas_host_smp.c index 16f93123271e..d110a366c48a 100644 --- a/drivers/scsi/libsas/sas_host_smp.c +++ b/drivers/scsi/libsas/sas_host_smp.c | |||
@@ -199,8 +199,8 @@ int sas_smp_host_handler(struct Scsi_Host *shost, struct request *req, | |||
199 | break; | 199 | break; |
200 | 200 | ||
201 | case SMP_DISCOVER: | 201 | case SMP_DISCOVER: |
202 | req->data_len =- 16; | 202 | req->data_len -= 16; |
203 | if (req->data_len < 0) { | 203 | if ((int)req->data_len < 0) { |
204 | req->data_len = 0; | 204 | req->data_len = 0; |
205 | error = -EINVAL; | 205 | error = -EINVAL; |
206 | goto out; | 206 | goto out; |
@@ -215,8 +215,8 @@ int sas_smp_host_handler(struct Scsi_Host *shost, struct request *req, | |||
215 | break; | 215 | break; |
216 | 216 | ||
217 | case SMP_REPORT_PHY_SATA: | 217 | case SMP_REPORT_PHY_SATA: |
218 | req->data_len =- 16; | 218 | req->data_len -= 16; |
219 | if (req->data_len < 0) { | 219 | if ((int)req->data_len < 0) { |
220 | req->data_len = 0; | 220 | req->data_len = 0; |
221 | error = -EINVAL; | 221 | error = -EINVAL; |
222 | goto out; | 222 | goto out; |
@@ -238,8 +238,8 @@ int sas_smp_host_handler(struct Scsi_Host *shost, struct request *req, | |||
238 | break; | 238 | break; |
239 | 239 | ||
240 | case SMP_PHY_CONTROL: | 240 | case SMP_PHY_CONTROL: |
241 | req->data_len =- 44; | 241 | req->data_len -= 44; |
242 | if (req->data_len < 0) { | 242 | if ((int)req->data_len < 0) { |
243 | req->data_len = 0; | 243 | req->data_len = 0; |
244 | error = -EINVAL; | 244 | error = -EINVAL; |
245 | goto out; | 245 | goto out; |