[SCSI] Unify SAM_ and SAM_STAT_ macros

We have two separate definitions for identical constants with nearly the
same name.  One comes from the generic headers in scsi.h; the other is
an enum in libsas.h ... it's causing confusion about which one is
correct (fortunately they both are).

Fix this by eliminating the libsas.h duplicate

Signed-off-by: James Bottomley <James.Bottomley@suse.de>

4 files changed, 12 insertions, 12 deletions

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 8c496b56556c..042153cbbde1 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -71,7 +71,7 @@ static enum ata_completion_errors sas_to_ata_err(struct task_status_struct *ts)
                 case SAS_SG_ERR:
                         return AC_ERR_INVALID;
 
-                case SAM_CHECK_COND:
+                case SAM_STAT_CHECK_CONDITION:
                 case SAS_OPEN_TO:
                 case SAS_OPEN_REJECT:
                         SAS_DPRINTK("%s: Saw error %d.  What to do?\n",
@@ -107,7 +107,7 @@ static void sas_ata_task_done(struct sas_task *task)
         sas_ha = dev->port->ha;
 
         spin_lock_irqsave(dev->sata_dev.ap->lock, flags);
-        if (stat->stat == SAS_PROTO_RESPONSE || stat->stat == SAM_GOOD) {
+        if (stat->stat == SAS_PROTO_RESPONSE || stat->stat == SAM_STAT_GOOD) {
                 ata_tf_from_fis(resp->ending_fis, &dev->sata_dev.tf);
                 qc->err_mask |= ac_err_mask(dev->sata_dev.tf.command);
                 dev->sata_dev.sstatus = resp->sstatus;
@@ -511,12 +511,12 @@ static int sas_execute_task(struct sas_task *task, void *buffer, int size,
                                         goto ex_err;
                         }
                 }
-                if (task->task_status.stat == SAM_BUSY ||
-                           task->task_status.stat == SAM_TASK_SET_FULL ||
+                if (task->task_status.stat == SAM_STAT_BUSY ||
+                           task->task_status.stat == SAM_STAT_TASK_SET_FULL ||
                            task->task_status.stat == SAS_QUEUE_FULL) {
                         SAS_DPRINTK("task: q busy, sleeping...\n");
                         schedule_timeout_interruptible(HZ);
-                } else if (task->task_status.stat == SAM_CHECK_COND) {
+                } else if (task->task_status.stat == SAM_STAT_CHECK_CONDITION) {
                         struct scsi_sense_hdr shdr;
 
                         if (!scsi_normalize_sense(ts->buf, ts->buf_valid_size,
@@ -549,7 +549,7 @@ static int sas_execute_task(struct sas_task *task, void *buffer, int size,
                                             shdr.asc, shdr.ascq);
                         }
                 } else if (task->task_status.resp != SAS_TASK_COMPLETE ||
-                           task->task_status.stat != SAM_GOOD) {
+                           task->task_status.stat != SAM_STAT_GOOD) {
                         SAS_DPRINTK("task finished with resp:0x%x, "
                                     "stat:0x%x\n",
                                     task->task_status.resp,
diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
index c65af02dcfe8..83dd5070a15c 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -107,7 +107,7 @@ static int smp_execute_task(struct domain_device *dev, void *req, int req_size,
                         }
                 }
                 if (task->task_status.resp == SAS_TASK_COMPLETE &&
-                    task->task_status.stat == SAM_GOOD) {
+                    task->task_status.stat == SAM_STAT_GOOD) {
                         res = 0;
                         break;
                 } if (task->task_status.resp == SAS_TASK_COMPLETE &&
diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
index a7890c6d878e..f0cfba9a1fc8 100644
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -113,10 +113,10 @@ static void sas_scsi_task_done(struct sas_task *task)
                 case SAS_ABORTED_TASK:
                         hs = DID_ABORT;
                         break;
-                case SAM_CHECK_COND:
+                case SAM_STAT_CHECK_CONDITION:
                         memcpy(sc->sense_buffer, ts->buf,
                                min(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
-                        stat = SAM_CHECK_COND;
+                        stat = SAM_STAT_CHECK_CONDITION;
                         break;
                 default:
                         stat = ts->stat;
diff --git a/drivers/scsi/libsas/sas_task.c b/drivers/scsi/libsas/sas_task.c
index 594524d5bfa1..b13a3346894c 100644
--- a/drivers/scsi/libsas/sas_task.c
+++ b/drivers/scsi/libsas/sas_task.c
@@ -15,13 +15,13 @@ void sas_ssp_task_response(struct device *dev, struct sas_task *task,
         else if (iu->datapres == 1)
                 tstat->stat = iu->resp_data[3];
         else if (iu->datapres == 2) {
-                tstat->stat = SAM_CHECK_COND;
+                tstat->stat = SAM_STAT_CHECK_CONDITION;
                 tstat->buf_valid_size =
                         min_t(int, SAS_STATUS_BUF_SIZE,
                               be32_to_cpu(iu->sense_data_len));
                 memcpy(tstat->buf, iu->sense_data, tstat->buf_valid_size);
 
-                if (iu->status != SAM_CHECK_COND)
+                if (iu->status != SAM_STAT_CHECK_CONDITION)
                         dev_printk(KERN_WARNING, dev,
                                    "dev %llx sent sense data, but "
                                    "stat(%x) is not CHECK CONDITION\n",
@@ -30,7 +30,7 @@ void sas_ssp_task_response(struct device *dev, struct sas_task *task,
         }
         else
                 /* when datapres contains corrupt/unknown value... */
-                tstat->stat = SAM_CHECK_COND;
+                tstat->stat = SAM_STAT_CHECK_CONDITION;
 }
 EXPORT_SYMBOL_GPL(sas_ssp_task_response);