diff options
author | Dan Williams <dan.j.williams@intel.com> | 2012-06-22 02:36:30 -0400 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2012-07-20 03:58:54 -0400 |
commit | f0bf750c2d25c3a2131ececbff63c7878e0e3765 (patch) | |
tree | ba967c5d28945e76bee78feb24ade328d5b0b3a6 /drivers/scsi/libsas/sas_init.c | |
parent | a494fd5bd98bb35d5a9a274fecb768e14ebf499c (diff) |
[SCSI] libsas: trim sas_task of slow path infrastructure
The timer and the completion are only used for slow path tasks (smp, and
lldd tmfs), yet we incur the allocation space and cpu setup time for
every fast path task.
Cc: Xiangliang Yu <yuxiangl@marvell.com>
Acked-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/libsas/sas_init.c')
-rw-r--r-- | drivers/scsi/libsas/sas_init.c | 23 |
1 files changed, 21 insertions, 2 deletions
diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c index 1bbab3d94a20..014297c05880 100644 --- a/drivers/scsi/libsas/sas_init.c +++ b/drivers/scsi/libsas/sas_init.c | |||
@@ -48,18 +48,37 @@ struct sas_task *sas_alloc_task(gfp_t flags) | |||
48 | INIT_LIST_HEAD(&task->list); | 48 | INIT_LIST_HEAD(&task->list); |
49 | spin_lock_init(&task->task_state_lock); | 49 | spin_lock_init(&task->task_state_lock); |
50 | task->task_state_flags = SAS_TASK_STATE_PENDING; | 50 | task->task_state_flags = SAS_TASK_STATE_PENDING; |
51 | init_timer(&task->timer); | ||
52 | init_completion(&task->completion); | ||
53 | } | 51 | } |
54 | 52 | ||
55 | return task; | 53 | return task; |
56 | } | 54 | } |
57 | EXPORT_SYMBOL_GPL(sas_alloc_task); | 55 | EXPORT_SYMBOL_GPL(sas_alloc_task); |
58 | 56 | ||
57 | struct sas_task *sas_alloc_slow_task(gfp_t flags) | ||
58 | { | ||
59 | struct sas_task *task = sas_alloc_task(flags); | ||
60 | struct sas_task_slow *slow = kmalloc(sizeof(*slow), flags); | ||
61 | |||
62 | if (!task || !slow) { | ||
63 | if (task) | ||
64 | kmem_cache_free(sas_task_cache, task); | ||
65 | kfree(slow); | ||
66 | return NULL; | ||
67 | } | ||
68 | |||
69 | task->slow_task = slow; | ||
70 | init_timer(&slow->timer); | ||
71 | init_completion(&slow->completion); | ||
72 | |||
73 | return task; | ||
74 | } | ||
75 | EXPORT_SYMBOL_GPL(sas_alloc_slow_task); | ||
76 | |||
59 | void sas_free_task(struct sas_task *task) | 77 | void sas_free_task(struct sas_task *task) |
60 | { | 78 | { |
61 | if (task) { | 79 | if (task) { |
62 | BUG_ON(!list_empty(&task->list)); | 80 | BUG_ON(!list_empty(&task->list)); |
81 | kfree(task->slow_task); | ||
63 | kmem_cache_free(sas_task_cache, task); | 82 | kmem_cache_free(sas_task_cache, task); |
64 | } | 83 | } |
65 | } | 84 | } |