diff options
author | Mike Christie <michaelc@cs.wisc.edu> | 2006-07-24 16:47:50 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2006-07-28 12:50:02 -0400 |
commit | f3ff0c3627df90aa28be98803b10289bb348e4e6 (patch) | |
tree | a387f0fade78bbcd337ee3ed962b76e92b482705 /drivers/scsi/libiscsi.c | |
parent | 40527afea1a3b18ee5754e17d6f807176e03f1f2 (diff) |
[SCSI] iscsi bugfixes: fix mem leaks in libiscsi
We were leaking some strings. This patch just frees them.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/libiscsi.c')
-rw-r--r-- | drivers/scsi/libiscsi.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index c628c63c51a8..5884cd26d53a 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c | |||
@@ -1357,6 +1357,8 @@ void iscsi_session_teardown(struct iscsi_cls_session *cls_session) | |||
1357 | iscsi_pool_free(&session->mgmtpool, (void**)session->mgmt_cmds); | 1357 | iscsi_pool_free(&session->mgmtpool, (void**)session->mgmt_cmds); |
1358 | iscsi_pool_free(&session->cmdpool, (void**)session->cmds); | 1358 | iscsi_pool_free(&session->cmdpool, (void**)session->cmds); |
1359 | 1359 | ||
1360 | kfree(session->targetname); | ||
1361 | |||
1360 | iscsi_destroy_session(cls_session); | 1362 | iscsi_destroy_session(cls_session); |
1361 | scsi_host_put(shost); | 1363 | scsi_host_put(shost); |
1362 | module_put(owner); | 1364 | module_put(owner); |
@@ -1491,6 +1493,7 @@ void iscsi_conn_teardown(struct iscsi_cls_conn *cls_conn) | |||
1491 | 1493 | ||
1492 | spin_lock_bh(&session->lock); | 1494 | spin_lock_bh(&session->lock); |
1493 | kfree(conn->data); | 1495 | kfree(conn->data); |
1496 | kfree(conn->persistent_address); | ||
1494 | __kfifo_put(session->mgmtpool.queue, (void*)&conn->login_mtask, | 1497 | __kfifo_put(session->mgmtpool.queue, (void*)&conn->login_mtask, |
1495 | sizeof(void*)); | 1498 | sizeof(void*)); |
1496 | list_del(&conn->item); | 1499 | list_del(&conn->item); |