diff options
author | Eddie Wai <eddie.wai@broadcom.com> | 2010-11-23 18:29:21 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-12-21 13:24:10 -0500 |
commit | 8eea2f55a65b9471276e78e5c86ddd19c4c0365c (patch) | |
tree | 5b40a3401d20d6d40ce22e86307e3252a3e7b67d /drivers/scsi/libiscsi.c | |
parent | 5ee32576269f33b66c6dbc98144aead1e74a1e91 (diff) |
[SCSI] bnx2i: Added fix for NOP-Out response panic from unsolicited NOP-In
The patch fixes the following situations where NOP-Out pkt is called for:
- local unsolicited NOP-Out requests (requesting no NOP-In response)
- local NOP-Out responses to unsolicited NOP-In requests
kernel panic is observed due to double session spin_lock requests; one in the
bnx2i_process_nopin_local_cmpl routine in bnx2i_hwi.c and the other in the
iscsi_put_task routine in libiscsi.c
The proposed fix is to export the currently static __iscsi_put_task() routine
and have bnx2i call it directly instead of the iscsi_put_task() routine which
holds the session spin lock.
Signed-off-by: Eddie Wai <eddie.wai@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Reviewed-by: Anil Veerabhadrappa <anilgv@broadcom.com>
Acked-by: Benjamin Li <benli@broadcom.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/libiscsi.c')
-rw-r--r-- | drivers/scsi/libiscsi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index c15fde808c33..7551abe40900 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c | |||
@@ -539,11 +539,12 @@ void __iscsi_get_task(struct iscsi_task *task) | |||
539 | } | 539 | } |
540 | EXPORT_SYMBOL_GPL(__iscsi_get_task); | 540 | EXPORT_SYMBOL_GPL(__iscsi_get_task); |
541 | 541 | ||
542 | static void __iscsi_put_task(struct iscsi_task *task) | 542 | void __iscsi_put_task(struct iscsi_task *task) |
543 | { | 543 | { |
544 | if (atomic_dec_and_test(&task->refcount)) | 544 | if (atomic_dec_and_test(&task->refcount)) |
545 | iscsi_free_task(task); | 545 | iscsi_free_task(task); |
546 | } | 546 | } |
547 | EXPORT_SYMBOL_GPL(__iscsi_put_task); | ||
547 | 548 | ||
548 | void iscsi_put_task(struct iscsi_task *task) | 549 | void iscsi_put_task(struct iscsi_task *task) |
549 | { | 550 | { |