diff options
author | Yi Zou <yi.zou@intel.com> | 2010-07-20 18:19:10 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-07-28 10:05:44 -0400 |
commit | ba402804ac2447ad41f4919603bf3e6f6db63110 (patch) | |
tree | 86ae6efbc2456403a816e33594d6d849cbd854b7 /drivers/scsi/libfc | |
parent | 2cf75f1c8aa4cab3ace57f9159f1dc85cba69d38 (diff) |
[SCSI] libfc: fix slowpath error from WARN_ON in fc_fcp_send_data
This is exposed by a mpio test using EMC CLARiiON targets when LUN
tresspassing happens, the burst length from the XFER_READY for the
MODE SELECT(10) is 19 bytes, much smaller than FC_MIN_MAX_PAYLOAD as
256 bytes. This patch removes the related two WARN_ON()s.
Signed-off-by: Yi Zou <yi.zou@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/libfc')
-rw-r--r-- | drivers/scsi/libfc/fc_fcp.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index 8914f1e95b72..a0a3ae7d8611 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c | |||
@@ -580,10 +580,8 @@ static int fc_fcp_send_data(struct fc_fcp_pkt *fsp, struct fc_seq *seq, | |||
580 | fsp, seq_blen, lport->lso_max, t_blen); | 580 | fsp, seq_blen, lport->lso_max, t_blen); |
581 | } | 581 | } |
582 | 582 | ||
583 | WARN_ON(t_blen < FC_MIN_MAX_PAYLOAD); | ||
584 | if (t_blen > 512) | 583 | if (t_blen > 512) |
585 | t_blen &= ~(512 - 1); /* round down to block size */ | 584 | t_blen &= ~(512 - 1); /* round down to block size */ |
586 | WARN_ON(t_blen < FC_MIN_MAX_PAYLOAD); /* won't go below 256 */ | ||
587 | sc = fsp->cmd; | 585 | sc = fsp->cmd; |
588 | 586 | ||
589 | remaining = seq_blen; | 587 | remaining = seq_blen; |