diff options
author | Robert Love <robert.w.love@intel.com> | 2009-02-27 13:55:45 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-03-10 10:04:40 -0400 |
commit | 34f42a070fc98f5dc07e9fa2338b7b8d1dc347eb (patch) | |
tree | 7e08edd537159be8a4fa341e7022cafd6f13b9e4 /drivers/scsi/libfc/fc_lport.c | |
parent | 0ae4d4ae47d2ccbcad813b0d6d8fe12590c7d648 (diff) |
[SCSI] libfc, fcoe: Fix kerneldoc comments
1) Added '()' for function names in kerneldoc comments
2) Changed comment bookends from '**/' to '*/'. The comment on the the
mailing list was that '**/' "is consistently unconventional. Not
wrong, just odd." The Documentation/kernel-doc-nano-HOWTO.txt
states that kerneldoc comment blocks should end with '**/' but most
(if not all) instance I found under drivers/scsi/ were only using
the '*/' so I converted to that style.
3) Removed incorrect linebreaks in kerneldoc comments where found
4) Removed a few unnecessary blank comment lines in kerneldoc comment
blocks
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/libfc/fc_lport.c')
-rw-r--r-- | drivers/scsi/libfc/fc_lport.c | 77 |
1 files changed, 38 insertions, 39 deletions
diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c index c00de2244c78..2ae50a1188e6 100644 --- a/drivers/scsi/libfc/fc_lport.c +++ b/drivers/scsi/libfc/fc_lport.c | |||
@@ -139,7 +139,7 @@ static int fc_frame_drop(struct fc_lport *lport, struct fc_frame *fp) | |||
139 | } | 139 | } |
140 | 140 | ||
141 | /** | 141 | /** |
142 | * fc_lport_rport_callback - Event handler for rport events | 142 | * fc_lport_rport_callback() - Event handler for rport events |
143 | * @lport: The lport which is receiving the event | 143 | * @lport: The lport which is receiving the event |
144 | * @rport: The rport which the event has occured on | 144 | * @rport: The rport which the event has occured on |
145 | * @event: The event that occured | 145 | * @event: The event that occured |
@@ -195,7 +195,7 @@ static void fc_lport_rport_callback(struct fc_lport *lport, | |||
195 | } | 195 | } |
196 | 196 | ||
197 | /** | 197 | /** |
198 | * fc_lport_state - Return a string which represents the lport's state | 198 | * fc_lport_state() - Return a string which represents the lport's state |
199 | * @lport: The lport whose state is to converted to a string | 199 | * @lport: The lport whose state is to converted to a string |
200 | */ | 200 | */ |
201 | static const char *fc_lport_state(struct fc_lport *lport) | 201 | static const char *fc_lport_state(struct fc_lport *lport) |
@@ -209,7 +209,7 @@ static const char *fc_lport_state(struct fc_lport *lport) | |||
209 | } | 209 | } |
210 | 210 | ||
211 | /** | 211 | /** |
212 | * fc_lport_ptp_setup - Create an rport for point-to-point mode | 212 | * fc_lport_ptp_setup() - Create an rport for point-to-point mode |
213 | * @lport: The lport to attach the ptp rport to | 213 | * @lport: The lport to attach the ptp rport to |
214 | * @fid: The FID of the ptp rport | 214 | * @fid: The FID of the ptp rport |
215 | * @remote_wwpn: The WWPN of the ptp rport | 215 | * @remote_wwpn: The WWPN of the ptp rport |
@@ -351,7 +351,7 @@ static void fc_lport_add_fc4_type(struct fc_lport *lport, enum fc_fh_type type) | |||
351 | } | 351 | } |
352 | 352 | ||
353 | /** | 353 | /** |
354 | * fc_lport_recv_rlir_req - Handle received Registered Link Incident Report. | 354 | * fc_lport_recv_rlir_req() - Handle received Registered Link Incident Report. |
355 | * @lport: Fibre Channel local port recieving the RLIR | 355 | * @lport: Fibre Channel local port recieving the RLIR |
356 | * @sp: current sequence in the RLIR exchange | 356 | * @sp: current sequence in the RLIR exchange |
357 | * @fp: RLIR request frame | 357 | * @fp: RLIR request frame |
@@ -370,7 +370,7 @@ static void fc_lport_recv_rlir_req(struct fc_seq *sp, struct fc_frame *fp, | |||
370 | } | 370 | } |
371 | 371 | ||
372 | /** | 372 | /** |
373 | * fc_lport_recv_echo_req - Handle received ECHO request | 373 | * fc_lport_recv_echo_req() - Handle received ECHO request |
374 | * @lport: Fibre Channel local port recieving the ECHO | 374 | * @lport: Fibre Channel local port recieving the ECHO |
375 | * @sp: current sequence in the ECHO exchange | 375 | * @sp: current sequence in the ECHO exchange |
376 | * @fp: ECHO request frame | 376 | * @fp: ECHO request frame |
@@ -412,7 +412,7 @@ static void fc_lport_recv_echo_req(struct fc_seq *sp, struct fc_frame *in_fp, | |||
412 | } | 412 | } |
413 | 413 | ||
414 | /** | 414 | /** |
415 | * fc_lport_recv_echo_req - Handle received Request Node ID data request | 415 | * fc_lport_recv_echo_req() - Handle received Request Node ID data request |
416 | * @lport: Fibre Channel local port recieving the RNID | 416 | * @lport: Fibre Channel local port recieving the RNID |
417 | * @sp: current sequence in the RNID exchange | 417 | * @sp: current sequence in the RNID exchange |
418 | * @fp: RNID request frame | 418 | * @fp: RNID request frame |
@@ -479,7 +479,7 @@ static void fc_lport_recv_rnid_req(struct fc_seq *sp, struct fc_frame *in_fp, | |||
479 | } | 479 | } |
480 | 480 | ||
481 | /** | 481 | /** |
482 | * fc_lport_recv_adisc_req - Handle received Address Discovery Request | 482 | * fc_lport_recv_adisc_req() - Handle received Address Discovery Request |
483 | * @lport: Fibre Channel local port recieving the ADISC | 483 | * @lport: Fibre Channel local port recieving the ADISC |
484 | * @sp: current sequence in the ADISC exchange | 484 | * @sp: current sequence in the ADISC exchange |
485 | * @fp: ADISC request frame | 485 | * @fp: ADISC request frame |
@@ -529,7 +529,7 @@ static void fc_lport_recv_adisc_req(struct fc_seq *sp, struct fc_frame *in_fp, | |||
529 | } | 529 | } |
530 | 530 | ||
531 | /** | 531 | /** |
532 | * fc_lport_recv_logo_req - Handle received fabric LOGO request | 532 | * fc_lport_recv_logo_req() - Handle received fabric LOGO request |
533 | * @lport: Fibre Channel local port recieving the LOGO | 533 | * @lport: Fibre Channel local port recieving the LOGO |
534 | * @sp: current sequence in the LOGO exchange | 534 | * @sp: current sequence in the LOGO exchange |
535 | * @fp: LOGO request frame | 535 | * @fp: LOGO request frame |
@@ -546,7 +546,7 @@ static void fc_lport_recv_logo_req(struct fc_seq *sp, struct fc_frame *fp, | |||
546 | } | 546 | } |
547 | 547 | ||
548 | /** | 548 | /** |
549 | * fc_fabric_login - Start the lport state machine | 549 | * fc_fabric_login() - Start the lport state machine |
550 | * @lport: The lport that should log into the fabric | 550 | * @lport: The lport that should log into the fabric |
551 | * | 551 | * |
552 | * Locking Note: This function should not be called | 552 | * Locking Note: This function should not be called |
@@ -568,7 +568,7 @@ int fc_fabric_login(struct fc_lport *lport) | |||
568 | EXPORT_SYMBOL(fc_fabric_login); | 568 | EXPORT_SYMBOL(fc_fabric_login); |
569 | 569 | ||
570 | /** | 570 | /** |
571 | * fc_linkup - Handler for transport linkup events | 571 | * fc_linkup() - Handler for transport linkup events |
572 | * @lport: The lport whose link is up | 572 | * @lport: The lport whose link is up |
573 | */ | 573 | */ |
574 | void fc_linkup(struct fc_lport *lport) | 574 | void fc_linkup(struct fc_lport *lport) |
@@ -588,7 +588,7 @@ void fc_linkup(struct fc_lport *lport) | |||
588 | EXPORT_SYMBOL(fc_linkup); | 588 | EXPORT_SYMBOL(fc_linkup); |
589 | 589 | ||
590 | /** | 590 | /** |
591 | * fc_linkdown - Handler for transport linkdown events | 591 | * fc_linkdown() - Handler for transport linkdown events |
592 | * @lport: The lport whose link is down | 592 | * @lport: The lport whose link is down |
593 | */ | 593 | */ |
594 | void fc_linkdown(struct fc_lport *lport) | 594 | void fc_linkdown(struct fc_lport *lport) |
@@ -607,12 +607,12 @@ void fc_linkdown(struct fc_lport *lport) | |||
607 | EXPORT_SYMBOL(fc_linkdown); | 607 | EXPORT_SYMBOL(fc_linkdown); |
608 | 608 | ||
609 | /** | 609 | /** |
610 | * fc_fabric_logoff - Logout of the fabric | 610 | * fc_fabric_logoff() - Logout of the fabric |
611 | * @lport: fc_lport pointer to logoff the fabric | 611 | * @lport: fc_lport pointer to logoff the fabric |
612 | * | 612 | * |
613 | * Return value: | 613 | * Return value: |
614 | * 0 for success, -1 for failure | 614 | * 0 for success, -1 for failure |
615 | **/ | 615 | */ |
616 | int fc_fabric_logoff(struct fc_lport *lport) | 616 | int fc_fabric_logoff(struct fc_lport *lport) |
617 | { | 617 | { |
618 | lport->tt.disc_stop_final(lport); | 618 | lport->tt.disc_stop_final(lport); |
@@ -625,7 +625,7 @@ int fc_fabric_logoff(struct fc_lport *lport) | |||
625 | EXPORT_SYMBOL(fc_fabric_logoff); | 625 | EXPORT_SYMBOL(fc_fabric_logoff); |
626 | 626 | ||
627 | /** | 627 | /** |
628 | * fc_lport_destroy - unregister a fc_lport | 628 | * fc_lport_destroy() - unregister a fc_lport |
629 | * @lport: fc_lport pointer to unregister | 629 | * @lport: fc_lport pointer to unregister |
630 | * | 630 | * |
631 | * Return value: | 631 | * Return value: |
@@ -635,7 +635,7 @@ EXPORT_SYMBOL(fc_fabric_logoff); | |||
635 | * clean-up all the allocated memory | 635 | * clean-up all the allocated memory |
636 | * and free up other system resources. | 636 | * and free up other system resources. |
637 | * | 637 | * |
638 | **/ | 638 | */ |
639 | int fc_lport_destroy(struct fc_lport *lport) | 639 | int fc_lport_destroy(struct fc_lport *lport) |
640 | { | 640 | { |
641 | lport->tt.frame_send = fc_frame_drop; | 641 | lport->tt.frame_send = fc_frame_drop; |
@@ -646,15 +646,14 @@ int fc_lport_destroy(struct fc_lport *lport) | |||
646 | EXPORT_SYMBOL(fc_lport_destroy); | 646 | EXPORT_SYMBOL(fc_lport_destroy); |
647 | 647 | ||
648 | /** | 648 | /** |
649 | * fc_set_mfs - sets up the mfs for the corresponding fc_lport | 649 | * fc_set_mfs() - sets up the mfs for the corresponding fc_lport |
650 | * @lport: fc_lport pointer to unregister | 650 | * @lport: fc_lport pointer to unregister |
651 | * @mfs: the new mfs for fc_lport | 651 | * @mfs: the new mfs for fc_lport |
652 | * | 652 | * |
653 | * Set mfs for the given fc_lport to the new mfs. | 653 | * Set mfs for the given fc_lport to the new mfs. |
654 | * | 654 | * |
655 | * Return: 0 for success | 655 | * Return: 0 for success |
656 | * | 656 | */ |
657 | **/ | ||
658 | int fc_set_mfs(struct fc_lport *lport, u32 mfs) | 657 | int fc_set_mfs(struct fc_lport *lport, u32 mfs) |
659 | { | 658 | { |
660 | unsigned int old_mfs; | 659 | unsigned int old_mfs; |
@@ -683,7 +682,7 @@ int fc_set_mfs(struct fc_lport *lport, u32 mfs) | |||
683 | EXPORT_SYMBOL(fc_set_mfs); | 682 | EXPORT_SYMBOL(fc_set_mfs); |
684 | 683 | ||
685 | /** | 684 | /** |
686 | * fc_lport_disc_callback - Callback for discovery events | 685 | * fc_lport_disc_callback() - Callback for discovery events |
687 | * @lport: FC local port | 686 | * @lport: FC local port |
688 | * @event: The discovery event | 687 | * @event: The discovery event |
689 | */ | 688 | */ |
@@ -708,7 +707,7 @@ void fc_lport_disc_callback(struct fc_lport *lport, enum fc_disc_event event) | |||
708 | } | 707 | } |
709 | 708 | ||
710 | /** | 709 | /** |
711 | * fc_rport_enter_ready - Enter the ready state and start discovery | 710 | * fc_rport_enter_ready() - Enter the ready state and start discovery |
712 | * @lport: Fibre Channel local port that is ready | 711 | * @lport: Fibre Channel local port that is ready |
713 | * | 712 | * |
714 | * Locking Note: The lport lock is expected to be held before calling | 713 | * Locking Note: The lport lock is expected to be held before calling |
@@ -725,7 +724,7 @@ static void fc_lport_enter_ready(struct fc_lport *lport) | |||
725 | } | 724 | } |
726 | 725 | ||
727 | /** | 726 | /** |
728 | * fc_lport_recv_flogi_req - Receive a FLOGI request | 727 | * fc_lport_recv_flogi_req() - Receive a FLOGI request |
729 | * @sp_in: The sequence the FLOGI is on | 728 | * @sp_in: The sequence the FLOGI is on |
730 | * @rx_fp: The frame the FLOGI is in | 729 | * @rx_fp: The frame the FLOGI is in |
731 | * @lport: The lport that recieved the request | 730 | * @lport: The lport that recieved the request |
@@ -815,7 +814,7 @@ out: | |||
815 | } | 814 | } |
816 | 815 | ||
817 | /** | 816 | /** |
818 | * fc_lport_recv_req - The generic lport request handler | 817 | * fc_lport_recv_req() - The generic lport request handler |
819 | * @lport: The lport that received the request | 818 | * @lport: The lport that received the request |
820 | * @sp: The sequence the request is on | 819 | * @sp: The sequence the request is on |
821 | * @fp: The frame the request is in | 820 | * @fp: The frame the request is in |
@@ -911,7 +910,7 @@ static void fc_lport_recv_req(struct fc_lport *lport, struct fc_seq *sp, | |||
911 | } | 910 | } |
912 | 911 | ||
913 | /** | 912 | /** |
914 | * fc_lport_reset - Reset an lport | 913 | * fc_lport_reset() - Reset an lport |
915 | * @lport: The lport which should be reset | 914 | * @lport: The lport which should be reset |
916 | * | 915 | * |
917 | * Locking Note: This functions should not be called with the | 916 | * Locking Note: This functions should not be called with the |
@@ -928,7 +927,7 @@ int fc_lport_reset(struct fc_lport *lport) | |||
928 | EXPORT_SYMBOL(fc_lport_reset); | 927 | EXPORT_SYMBOL(fc_lport_reset); |
929 | 928 | ||
930 | /** | 929 | /** |
931 | * fc_rport_enter_reset - Reset the local port | 930 | * fc_rport_enter_reset() - Reset the local port |
932 | * @lport: Fibre Channel local port to be reset | 931 | * @lport: Fibre Channel local port to be reset |
933 | * | 932 | * |
934 | * Locking Note: The lport lock is expected to be held before calling | 933 | * Locking Note: The lport lock is expected to be held before calling |
@@ -960,7 +959,7 @@ static void fc_lport_enter_reset(struct fc_lport *lport) | |||
960 | } | 959 | } |
961 | 960 | ||
962 | /** | 961 | /** |
963 | * fc_lport_error - Handler for any errors | 962 | * fc_lport_error() - Handler for any errors |
964 | * @lport: The fc_lport object | 963 | * @lport: The fc_lport object |
965 | * @fp: The frame pointer | 964 | * @fp: The frame pointer |
966 | * | 965 | * |
@@ -1007,8 +1006,8 @@ static void fc_lport_error(struct fc_lport *lport, struct fc_frame *fp) | |||
1007 | } | 1006 | } |
1008 | 1007 | ||
1009 | /** | 1008 | /** |
1010 | * fc_lport_rft_id_resp - Handle response to Register Fibre | 1009 | * fc_lport_rft_id_resp() - Handle response to Register Fibre |
1011 | * Channel Types by ID (RPN_ID) request | 1010 | * Channel Types by ID (RPN_ID) request |
1012 | * @sp: current sequence in RPN_ID exchange | 1011 | * @sp: current sequence in RPN_ID exchange |
1013 | * @fp: response frame | 1012 | * @fp: response frame |
1014 | * @lp_arg: Fibre Channel host port instance | 1013 | * @lp_arg: Fibre Channel host port instance |
@@ -1059,8 +1058,8 @@ err: | |||
1059 | } | 1058 | } |
1060 | 1059 | ||
1061 | /** | 1060 | /** |
1062 | * fc_lport_rpn_id_resp - Handle response to Register Port | 1061 | * fc_lport_rpn_id_resp() - Handle response to Register Port |
1063 | * Name by ID (RPN_ID) request | 1062 | * Name by ID (RPN_ID) request |
1064 | * @sp: current sequence in RPN_ID exchange | 1063 | * @sp: current sequence in RPN_ID exchange |
1065 | * @fp: response frame | 1064 | * @fp: response frame |
1066 | * @lp_arg: Fibre Channel host port instance | 1065 | * @lp_arg: Fibre Channel host port instance |
@@ -1111,7 +1110,7 @@ err: | |||
1111 | } | 1110 | } |
1112 | 1111 | ||
1113 | /** | 1112 | /** |
1114 | * fc_lport_scr_resp - Handle response to State Change Register (SCR) request | 1113 | * fc_lport_scr_resp() - Handle response to State Change Register (SCR) request |
1115 | * @sp: current sequence in SCR exchange | 1114 | * @sp: current sequence in SCR exchange |
1116 | * @fp: response frame | 1115 | * @fp: response frame |
1117 | * @lp_arg: Fibre Channel lport port instance that sent the registration request | 1116 | * @lp_arg: Fibre Channel lport port instance that sent the registration request |
@@ -1157,7 +1156,7 @@ err: | |||
1157 | } | 1156 | } |
1158 | 1157 | ||
1159 | /** | 1158 | /** |
1160 | * fc_lport_enter_scr - Send a State Change Register (SCR) request | 1159 | * fc_lport_enter_scr() - Send a State Change Register (SCR) request |
1161 | * @lport: Fibre Channel local port to register for state changes | 1160 | * @lport: Fibre Channel local port to register for state changes |
1162 | * | 1161 | * |
1163 | * Locking Note: The lport lock is expected to be held before calling | 1162 | * Locking Note: The lport lock is expected to be held before calling |
@@ -1184,7 +1183,7 @@ static void fc_lport_enter_scr(struct fc_lport *lport) | |||
1184 | } | 1183 | } |
1185 | 1184 | ||
1186 | /** | 1185 | /** |
1187 | * fc_lport_enter_rft_id - Register FC4-types with the name server | 1186 | * fc_lport_enter_rft_id() - Register FC4-types with the name server |
1188 | * @lport: Fibre Channel local port to register | 1187 | * @lport: Fibre Channel local port to register |
1189 | * | 1188 | * |
1190 | * Locking Note: The lport lock is expected to be held before calling | 1189 | * Locking Note: The lport lock is expected to be held before calling |
@@ -1226,7 +1225,7 @@ static void fc_lport_enter_rft_id(struct fc_lport *lport) | |||
1226 | } | 1225 | } |
1227 | 1226 | ||
1228 | /** | 1227 | /** |
1229 | * fc_rport_enter_rft_id - Register port name with the name server | 1228 | * fc_rport_enter_rft_id() - Register port name with the name server |
1230 | * @lport: Fibre Channel local port to register | 1229 | * @lport: Fibre Channel local port to register |
1231 | * | 1230 | * |
1232 | * Locking Note: The lport lock is expected to be held before calling | 1231 | * Locking Note: The lport lock is expected to be held before calling |
@@ -1259,7 +1258,7 @@ static struct fc_rport_operations fc_lport_rport_ops = { | |||
1259 | }; | 1258 | }; |
1260 | 1259 | ||
1261 | /** | 1260 | /** |
1262 | * fc_rport_enter_dns - Create a rport to the name server | 1261 | * fc_rport_enter_dns() - Create a rport to the name server |
1263 | * @lport: Fibre Channel local port requesting a rport for the name server | 1262 | * @lport: Fibre Channel local port requesting a rport for the name server |
1264 | * | 1263 | * |
1265 | * Locking Note: The lport lock is expected to be held before calling | 1264 | * Locking Note: The lport lock is expected to be held before calling |
@@ -1296,7 +1295,7 @@ err: | |||
1296 | } | 1295 | } |
1297 | 1296 | ||
1298 | /** | 1297 | /** |
1299 | * fc_lport_timeout - Handler for the retry_work timer. | 1298 | * fc_lport_timeout() - Handler for the retry_work timer. |
1300 | * @work: The work struct of the fc_lport | 1299 | * @work: The work struct of the fc_lport |
1301 | */ | 1300 | */ |
1302 | static void fc_lport_timeout(struct work_struct *work) | 1301 | static void fc_lport_timeout(struct work_struct *work) |
@@ -1337,7 +1336,7 @@ static void fc_lport_timeout(struct work_struct *work) | |||
1337 | } | 1336 | } |
1338 | 1337 | ||
1339 | /** | 1338 | /** |
1340 | * fc_lport_logo_resp - Handle response to LOGO request | 1339 | * fc_lport_logo_resp() - Handle response to LOGO request |
1341 | * @sp: current sequence in LOGO exchange | 1340 | * @sp: current sequence in LOGO exchange |
1342 | * @fp: response frame | 1341 | * @fp: response frame |
1343 | * @lp_arg: Fibre Channel lport port instance that sent the LOGO request | 1342 | * @lp_arg: Fibre Channel lport port instance that sent the LOGO request |
@@ -1383,7 +1382,7 @@ err: | |||
1383 | } | 1382 | } |
1384 | 1383 | ||
1385 | /** | 1384 | /** |
1386 | * fc_rport_enter_logo - Logout of the fabric | 1385 | * fc_rport_enter_logo() - Logout of the fabric |
1387 | * @lport: Fibre Channel local port to be logged out | 1386 | * @lport: Fibre Channel local port to be logged out |
1388 | * | 1387 | * |
1389 | * Locking Note: The lport lock is expected to be held before calling | 1388 | * Locking Note: The lport lock is expected to be held before calling |
@@ -1415,7 +1414,7 @@ static void fc_lport_enter_logo(struct fc_lport *lport) | |||
1415 | } | 1414 | } |
1416 | 1415 | ||
1417 | /** | 1416 | /** |
1418 | * fc_lport_flogi_resp - Handle response to FLOGI request | 1417 | * fc_lport_flogi_resp() - Handle response to FLOGI request |
1419 | * @sp: current sequence in FLOGI exchange | 1418 | * @sp: current sequence in FLOGI exchange |
1420 | * @fp: response frame | 1419 | * @fp: response frame |
1421 | * @lp_arg: Fibre Channel lport port instance that sent the FLOGI request | 1420 | * @lp_arg: Fibre Channel lport port instance that sent the FLOGI request |
@@ -1510,7 +1509,7 @@ err: | |||
1510 | } | 1509 | } |
1511 | 1510 | ||
1512 | /** | 1511 | /** |
1513 | * fc_rport_enter_flogi - Send a FLOGI request to the fabric manager | 1512 | * fc_rport_enter_flogi() - Send a FLOGI request to the fabric manager |
1514 | * @lport: Fibre Channel local port to be logged in to the fabric | 1513 | * @lport: Fibre Channel local port to be logged in to the fabric |
1515 | * | 1514 | * |
1516 | * Locking Note: The lport lock is expected to be held before calling | 1515 | * Locking Note: The lport lock is expected to be held before calling |