diff options
author | Bart Van Assche <bvanassche@acm.org> | 2013-08-14 11:32:51 -0400 |
---|---|---|
committer | Robert Love <robert.w.love@intel.com> | 2013-09-04 15:55:02 -0400 |
commit | b20d9bfda77306c2f66a90eb94ef9db58fb1e682 (patch) | |
tree | 965d772c974767e416e57027cf338dca17a357f0 /drivers/scsi/libfc/fc_exch.c | |
parent | c1d454246c1339388ed0788f34f88ee12ad58ef3 (diff) |
libfc: Debug code fixes
The second argument of fc_lport_error() may be a valid frame pointer.
Hence only print it as an error code if it really is an error code.
Debug statements must end in a newline. Add one where it is missing.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Diffstat (limited to 'drivers/scsi/libfc/fc_exch.c')
-rw-r--r-- | drivers/scsi/libfc/fc_exch.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index b233a2dea122..cb2b900c011d 100644 --- a/drivers/scsi/libfc/fc_exch.c +++ b/drivers/scsi/libfc/fc_exch.c | |||
@@ -1659,7 +1659,7 @@ static void fc_exch_recv_bls(struct fc_exch_mgr *mp, struct fc_frame *fp) | |||
1659 | break; | 1659 | break; |
1660 | default: | 1660 | default: |
1661 | if (ep) | 1661 | if (ep) |
1662 | FC_EXCH_DBG(ep, "BLS rctl %x - %s received", | 1662 | FC_EXCH_DBG(ep, "BLS rctl %x - %s received\n", |
1663 | fh->fh_r_ctl, | 1663 | fh->fh_r_ctl, |
1664 | fc_exch_rctl_name(fh->fh_r_ctl)); | 1664 | fc_exch_rctl_name(fh->fh_r_ctl)); |
1665 | break; | 1665 | break; |
@@ -1953,13 +1953,13 @@ static void fc_exch_rrq_resp(struct fc_seq *sp, struct fc_frame *fp, void *arg) | |||
1953 | 1953 | ||
1954 | switch (op) { | 1954 | switch (op) { |
1955 | case ELS_LS_RJT: | 1955 | case ELS_LS_RJT: |
1956 | FC_EXCH_DBG(aborted_ep, "LS_RJT for RRQ"); | 1956 | FC_EXCH_DBG(aborted_ep, "LS_RJT for RRQ\n"); |
1957 | /* fall through */ | 1957 | /* fall through */ |
1958 | case ELS_LS_ACC: | 1958 | case ELS_LS_ACC: |
1959 | goto cleanup; | 1959 | goto cleanup; |
1960 | default: | 1960 | default: |
1961 | FC_EXCH_DBG(aborted_ep, "unexpected response op %x " | 1961 | FC_EXCH_DBG(aborted_ep, "unexpected response op %x for RRQ\n", |
1962 | "for RRQ", op); | 1962 | op); |
1963 | return; | 1963 | return; |
1964 | } | 1964 | } |
1965 | 1965 | ||