diff options
author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2005-08-26 11:03:19 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2005-08-26 17:36:26 -0400 |
commit | b73fc89f6d1f84326e5e897ad249d00a9f218fd7 (patch) | |
tree | 557d5ba51a4f6c58be0717c0da13c2e409fd6008 /drivers/scsi/libata-core.c | |
parent | 31433ea369d250ad011577eee6110d3efcb9d861 (diff) |
[PATCH] libata: regularize dma_start/stop arguments
Needed for a few PATA drivers.
Also fix up a wrong comment.
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/scsi/libata-core.c')
-rw-r--r-- | drivers/scsi/libata-core.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c index 19b45c2bfa26..f15a07f9f471 100644 --- a/drivers/scsi/libata-core.c +++ b/drivers/scsi/libata-core.c | |||
@@ -3017,7 +3017,7 @@ static void ata_qc_timeout(struct ata_queued_cmd *qc) | |||
3017 | host_stat = ap->ops->bmdma_status(ap); | 3017 | host_stat = ap->ops->bmdma_status(ap); |
3018 | 3018 | ||
3019 | /* before we do anything else, clear DMA-Start bit */ | 3019 | /* before we do anything else, clear DMA-Start bit */ |
3020 | ap->ops->bmdma_stop(ap); | 3020 | ap->ops->bmdma_stop(qc); |
3021 | 3021 | ||
3022 | /* fall through */ | 3022 | /* fall through */ |
3023 | 3023 | ||
@@ -3399,7 +3399,7 @@ static void ata_bmdma_setup_mmio (struct ata_queued_cmd *qc) | |||
3399 | } | 3399 | } |
3400 | 3400 | ||
3401 | /** | 3401 | /** |
3402 | * ata_bmdma_start - Start a PCI IDE BMDMA transaction | 3402 | * ata_bmdma_start_mmio - Start a PCI IDE BMDMA transaction |
3403 | * @qc: Info associated with this ATA transaction. | 3403 | * @qc: Info associated with this ATA transaction. |
3404 | * | 3404 | * |
3405 | * LOCKING: | 3405 | * LOCKING: |
@@ -3570,7 +3570,7 @@ u8 ata_bmdma_status(struct ata_port *ap) | |||
3570 | 3570 | ||
3571 | /** | 3571 | /** |
3572 | * ata_bmdma_stop - Stop PCI IDE BMDMA transfer | 3572 | * ata_bmdma_stop - Stop PCI IDE BMDMA transfer |
3573 | * @ap: Port associated with this ATA transaction. | 3573 | * @qc: Command we are ending DMA for |
3574 | * | 3574 | * |
3575 | * Clears the ATA_DMA_START flag in the dma control register | 3575 | * Clears the ATA_DMA_START flag in the dma control register |
3576 | * | 3576 | * |
@@ -3580,8 +3580,9 @@ u8 ata_bmdma_status(struct ata_port *ap) | |||
3580 | * spin_lock_irqsave(host_set lock) | 3580 | * spin_lock_irqsave(host_set lock) |
3581 | */ | 3581 | */ |
3582 | 3582 | ||
3583 | void ata_bmdma_stop(struct ata_port *ap) | 3583 | void ata_bmdma_stop(struct ata_queued_cmd *qc) |
3584 | { | 3584 | { |
3585 | struct ata_port *ap = qc->ap; | ||
3585 | if (ap->flags & ATA_FLAG_MMIO) { | 3586 | if (ap->flags & ATA_FLAG_MMIO) { |
3586 | void __iomem *mmio = (void __iomem *) ap->ioaddr.bmdma_addr; | 3587 | void __iomem *mmio = (void __iomem *) ap->ioaddr.bmdma_addr; |
3587 | 3588 | ||
@@ -3633,7 +3634,7 @@ inline unsigned int ata_host_intr (struct ata_port *ap, | |||
3633 | goto idle_irq; | 3634 | goto idle_irq; |
3634 | 3635 | ||
3635 | /* before we do anything else, clear DMA-Start bit */ | 3636 | /* before we do anything else, clear DMA-Start bit */ |
3636 | ap->ops->bmdma_stop(ap); | 3637 | ap->ops->bmdma_stop(qc); |
3637 | 3638 | ||
3638 | /* fall through */ | 3639 | /* fall through */ |
3639 | 3640 | ||