aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/libata-core.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2006-02-15 01:01:42 -0500
committerJeff Garzik <jgarzik@pobox.com>2006-02-20 06:19:53 -0500
commit56497bd5f1340cb97d94cab953b050be6f729790 (patch)
tree330d966efed6bf6fd2c3d746b02a25f5ad4232a7 /drivers/scsi/libata-core.c
parent6aff8f1f07a7fff48121d1ad4a550f3af24ccc81 (diff)
[PATCH] libata: fix comment regarding setting cable type
The comment above ata_std_postreset() specified that setting cable type is the responsibility of postreset(), which isn't possible / optimal depending on controller / driver. This patch kills the comment. Setting cable type is responsibility of ->probe_reset. libata doesn't care whether it's done in probeinit, reset or postreset. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/scsi/libata-core.c')
-rw-r--r--drivers/scsi/libata-core.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 76621463b499..62340f4ef004 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -2112,7 +2112,6 @@ int sata_std_hardreset(struct ata_port *ap, int verbose, unsigned int *class)
2112 * This function is invoked after a successful reset. Note that 2112 * This function is invoked after a successful reset. Note that
2113 * the device might have been reset more than once using 2113 * the device might have been reset more than once using
2114 * different reset methods before postreset is invoked. 2114 * different reset methods before postreset is invoked.
2115 * postreset is also reponsible for setting cable type.
2116 * 2115 *
2117 * This function is to be used as standard callback for 2116 * This function is to be used as standard callback for
2118 * ata_drive_*_reset(). 2117 * ata_drive_*_reset().
@@ -2124,7 +2123,7 @@ void ata_std_postreset(struct ata_port *ap, unsigned int *classes)
2124{ 2123{
2125 DPRINTK("ENTER\n"); 2124 DPRINTK("ENTER\n");
2126 2125
2127 /* set cable type */ 2126 /* set cable type if it isn't already set */
2128 if (ap->cbl == ATA_CBL_NONE && ap->flags & ATA_FLAG_SATA) 2127 if (ap->cbl == ATA_CBL_NONE && ap->flags & ATA_FLAG_SATA)
2129 ap->cbl = ATA_CBL_SATA; 2128 ap->cbl = ATA_CBL_SATA;
2130 2129