diff options
author | Mike Christie <michaelc@cs.wisc.edu> | 2006-08-31 18:09:28 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2006-09-02 14:37:18 -0400 |
commit | dd8c0d958621e3137f3e3302f7b8952041a4a1d7 (patch) | |
tree | 30b943eebcc044cb3305c449d7eea00376115a22 /drivers/scsi/iscsi_tcp.h | |
parent | 62f383003c22cd34920d0412465eddcb1223da0d (diff) |
[SCSI] scsi_tcp: rm data rx and tx tfms
We currently allocated seperate tfms for data and header digests. There
is no reason for this since we can never calculate a rx header and
digest at the same time. Same for sends. So this patch removes the data
tfms and has the send and recv sides use the rx_tfm or tx_tfm.
I also made the connection creation code preallocate the tfms because I
thought I hit a bug where I changed the digests settings during a
relogin but could not allocate the tfm and then we just failed.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/iscsi_tcp.h')
-rw-r--r-- | drivers/scsi/iscsi_tcp.h | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/scsi/iscsi_tcp.h b/drivers/scsi/iscsi_tcp.h index 7e40e94d9fdc..609f4778d125 100644 --- a/drivers/scsi/iscsi_tcp.h +++ b/drivers/scsi/iscsi_tcp.h | |||
@@ -81,10 +81,6 @@ struct iscsi_tcp_conn { | |||
81 | * stop to terminate */ | 81 | * stop to terminate */ |
82 | /* iSCSI connection-wide sequencing */ | 82 | /* iSCSI connection-wide sequencing */ |
83 | int hdr_size; /* PDU header size */ | 83 | int hdr_size; /* PDU header size */ |
84 | |||
85 | struct crypto_tfm *rx_tfm; /* CRC32C (Rx) */ | ||
86 | struct crypto_tfm *data_rx_tfm; /* CRC32C (Rx) for data */ | ||
87 | |||
88 | /* control data */ | 84 | /* control data */ |
89 | struct iscsi_tcp_recv in; /* TCP receive context */ | 85 | struct iscsi_tcp_recv in; /* TCP receive context */ |
90 | int in_progress; /* connection state machine */ | 86 | int in_progress; /* connection state machine */ |
@@ -94,9 +90,9 @@ struct iscsi_tcp_conn { | |||
94 | void (*old_state_change)(struct sock *); | 90 | void (*old_state_change)(struct sock *); |
95 | void (*old_write_space)(struct sock *); | 91 | void (*old_write_space)(struct sock *); |
96 | 92 | ||
97 | /* xmit */ | 93 | /* data and header digests */ |
98 | struct crypto_tfm *tx_tfm; /* CRC32C (Tx) */ | 94 | struct crypto_tfm *tx_tfm; /* CRC32C (Tx) */ |
99 | struct crypto_tfm *data_tx_tfm; /* CRC32C (Tx) for data */ | 95 | struct crypto_tfm *rx_tfm; /* CRC32C (Rx) */ |
100 | 96 | ||
101 | /* MIB custom statistics */ | 97 | /* MIB custom statistics */ |
102 | uint32_t sendpage_failures_cnt; | 98 | uint32_t sendpage_failures_cnt; |