diff options
author | Dan Williams <dan.j.williams@intel.com> | 2011-07-01 15:07:25 -0400 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2011-07-03 07:04:52 -0400 |
commit | a8a0a133b03c6863d0f77229d19befca4de905fa (patch) | |
tree | 387efebbe86ba9b8510fd1374ca3221bb42dbb42 /drivers/scsi/isci/task.c | |
parent | dc00c8b6940aa10ab1ce6a4d10b1bfe7b848781b (diff) |
isci: pare back error messsages
The messages emitted from task.c and some from request.c likely
duplicate (in a less undertandable way) what is reported by the
midlayer.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/scsi/isci/task.c')
-rw-r--r-- | drivers/scsi/isci/task.c | 38 |
1 files changed, 19 insertions, 19 deletions
diff --git a/drivers/scsi/isci/task.c b/drivers/scsi/isci/task.c index 5d962b6b03eb..22504c7ef2dc 100644 --- a/drivers/scsi/isci/task.c +++ b/drivers/scsi/isci/task.c | |||
@@ -104,7 +104,7 @@ static void isci_task_refuse(struct isci_host *ihost, struct sas_task *task, | |||
104 | /* No notification because this request is already in the | 104 | /* No notification because this request is already in the |
105 | * abort path. | 105 | * abort path. |
106 | */ | 106 | */ |
107 | dev_warn(&ihost->pdev->dev, | 107 | dev_dbg(&ihost->pdev->dev, |
108 | "%s: Aborted - task = %p, response=%d, " | 108 | "%s: Aborted - task = %p, response=%d, " |
109 | "status=%d\n", | 109 | "status=%d\n", |
110 | __func__, task, response, status); | 110 | __func__, task, response, status); |
@@ -112,7 +112,7 @@ static void isci_task_refuse(struct isci_host *ihost, struct sas_task *task, | |||
112 | 112 | ||
113 | case isci_perform_error_io_completion: | 113 | case isci_perform_error_io_completion: |
114 | /* Use sas_task_abort */ | 114 | /* Use sas_task_abort */ |
115 | dev_warn(&ihost->pdev->dev, | 115 | dev_dbg(&ihost->pdev->dev, |
116 | "%s: Error - task = %p, response=%d, " | 116 | "%s: Error - task = %p, response=%d, " |
117 | "status=%d\n", | 117 | "status=%d\n", |
118 | __func__, task, response, status); | 118 | __func__, task, response, status); |
@@ -121,7 +121,7 @@ static void isci_task_refuse(struct isci_host *ihost, struct sas_task *task, | |||
121 | break; | 121 | break; |
122 | 122 | ||
123 | default: | 123 | default: |
124 | dev_warn(&ihost->pdev->dev, | 124 | dev_dbg(&ihost->pdev->dev, |
125 | "%s: isci task notification default case!", | 125 | "%s: isci task notification default case!", |
126 | __func__); | 126 | __func__); |
127 | sas_task_abort(task); | 127 | sas_task_abort(task); |
@@ -374,7 +374,7 @@ static int isci_task_execute_tmf(struct isci_host *ihost, | |||
374 | status = sci_controller_start_task(ihost, idev, ireq); | 374 | status = sci_controller_start_task(ihost, idev, ireq); |
375 | 375 | ||
376 | if (status != SCI_TASK_SUCCESS) { | 376 | if (status != SCI_TASK_SUCCESS) { |
377 | dev_warn(&ihost->pdev->dev, | 377 | dev_dbg(&ihost->pdev->dev, |
378 | "%s: start_io failed - status = 0x%x, request = %p\n", | 378 | "%s: start_io failed - status = 0x%x, request = %p\n", |
379 | __func__, | 379 | __func__, |
380 | status, | 380 | status, |
@@ -604,7 +604,7 @@ static void isci_terminate_request_core(struct isci_host *ihost, | |||
604 | * being aborted. | 604 | * being aborted. |
605 | */ | 605 | */ |
606 | if (status != SCI_SUCCESS) { | 606 | if (status != SCI_SUCCESS) { |
607 | dev_err(&ihost->pdev->dev, | 607 | dev_dbg(&ihost->pdev->dev, |
608 | "%s: sci_controller_terminate_request" | 608 | "%s: sci_controller_terminate_request" |
609 | " returned = 0x%x\n", | 609 | " returned = 0x%x\n", |
610 | __func__, status); | 610 | __func__, status); |
@@ -662,7 +662,7 @@ static void isci_terminate_request_core(struct isci_host *ihost, | |||
662 | 662 | ||
663 | if (!termination_completed) { | 663 | if (!termination_completed) { |
664 | 664 | ||
665 | dev_err(&ihost->pdev->dev, | 665 | dev_dbg(&ihost->pdev->dev, |
666 | "%s: *** Timeout waiting for " | 666 | "%s: *** Timeout waiting for " |
667 | "termination(%p/%p)\n", | 667 | "termination(%p/%p)\n", |
668 | __func__, io_request_completion, | 668 | __func__, io_request_completion, |
@@ -853,7 +853,7 @@ static int isci_task_send_lu_reset_sata(struct isci_host *ihost, | |||
853 | ret = isci_task_execute_tmf(ihost, idev, &tmf, ISCI_SRST_TIMEOUT_MS); | 853 | ret = isci_task_execute_tmf(ihost, idev, &tmf, ISCI_SRST_TIMEOUT_MS); |
854 | 854 | ||
855 | if (ret != TMF_RESP_FUNC_COMPLETE) { | 855 | if (ret != TMF_RESP_FUNC_COMPLETE) { |
856 | dev_warn(&ihost->pdev->dev, | 856 | dev_dbg(&ihost->pdev->dev, |
857 | "%s: Assert SRST failed (%p) = %x", | 857 | "%s: Assert SRST failed (%p) = %x", |
858 | __func__, idev, ret); | 858 | __func__, idev, ret); |
859 | 859 | ||
@@ -897,7 +897,7 @@ int isci_task_lu_reset(struct domain_device *domain_device, u8 *lun) | |||
897 | */ | 897 | */ |
898 | if (!isci_device || | 898 | if (!isci_device || |
899 | isci_device_is_reset_pending(isci_host, isci_device)) { | 899 | isci_device_is_reset_pending(isci_host, isci_device)) { |
900 | dev_warn(&isci_host->pdev->dev, | 900 | dev_dbg(&isci_host->pdev->dev, |
901 | "%s: No dev (%p), or " | 901 | "%s: No dev (%p), or " |
902 | "RESET PENDING: domain_device=%p\n", | 902 | "RESET PENDING: domain_device=%p\n", |
903 | __func__, isci_device, domain_device); | 903 | __func__, isci_device, domain_device); |
@@ -970,7 +970,7 @@ static void isci_abort_task_process_cb( | |||
970 | */ | 970 | */ |
971 | if ((old_request->status != aborted) | 971 | if ((old_request->status != aborted) |
972 | && (old_request->status != completed)) | 972 | && (old_request->status != completed)) |
973 | dev_err(&old_request->isci_host->pdev->dev, | 973 | dev_dbg(&old_request->isci_host->pdev->dev, |
974 | "%s: Bad request status (%d): tmf=%p, old_request=%p\n", | 974 | "%s: Bad request status (%d): tmf=%p, old_request=%p\n", |
975 | __func__, old_request->status, tmf, old_request); | 975 | __func__, old_request->status, tmf, old_request); |
976 | break; | 976 | break; |
@@ -988,7 +988,7 @@ static void isci_abort_task_process_cb( | |||
988 | break; | 988 | break; |
989 | 989 | ||
990 | default: | 990 | default: |
991 | dev_err(&old_request->isci_host->pdev->dev, | 991 | dev_dbg(&old_request->isci_host->pdev->dev, |
992 | "%s: Bad cb_state (%d): tmf=%p, old_request=%p\n", | 992 | "%s: Bad cb_state (%d): tmf=%p, old_request=%p\n", |
993 | __func__, cb_state, tmf, old_request); | 993 | __func__, cb_state, tmf, old_request); |
994 | break; | 994 | break; |
@@ -1046,7 +1046,7 @@ int isci_task_abort_task(struct sas_task *task) | |||
1046 | * SCSI error handler thread to escalate to LUN reset | 1046 | * SCSI error handler thread to escalate to LUN reset |
1047 | */ | 1047 | */ |
1048 | if (sas_protocol_ata(task->task_proto)) { | 1048 | if (sas_protocol_ata(task->task_proto)) { |
1049 | dev_warn(&isci_host->pdev->dev, | 1049 | dev_dbg(&isci_host->pdev->dev, |
1050 | " task %p is for a STP/SATA device;" | 1050 | " task %p is for a STP/SATA device;" |
1051 | " returning TMF_RESP_FUNC_FAILED\n" | 1051 | " returning TMF_RESP_FUNC_FAILED\n" |
1052 | " to cause a LUN reset...\n", task); | 1052 | " to cause a LUN reset...\n", task); |
@@ -1176,7 +1176,7 @@ int isci_task_abort_task(struct sas_task *task) | |||
1176 | ISCI_ABORT_TASK_TIMEOUT_MS); | 1176 | ISCI_ABORT_TASK_TIMEOUT_MS); |
1177 | 1177 | ||
1178 | if (ret != TMF_RESP_FUNC_COMPLETE) | 1178 | if (ret != TMF_RESP_FUNC_COMPLETE) |
1179 | dev_err(&isci_host->pdev->dev, | 1179 | dev_dbg(&isci_host->pdev->dev, |
1180 | "%s: isci_task_send_tmf failed\n", | 1180 | "%s: isci_task_send_tmf failed\n", |
1181 | __func__); | 1181 | __func__); |
1182 | } | 1182 | } |
@@ -1395,7 +1395,7 @@ static int isci_smp_execute_task(struct isci_host *ihost, | |||
1395 | 1395 | ||
1396 | if (res) { | 1396 | if (res) { |
1397 | del_timer(&task->timer); | 1397 | del_timer(&task->timer); |
1398 | dev_err(&ihost->pdev->dev, | 1398 | dev_dbg(&ihost->pdev->dev, |
1399 | "%s: executing SMP task failed:%d\n", | 1399 | "%s: executing SMP task failed:%d\n", |
1400 | __func__, res); | 1400 | __func__, res); |
1401 | goto ex_err; | 1401 | goto ex_err; |
@@ -1404,12 +1404,12 @@ static int isci_smp_execute_task(struct isci_host *ihost, | |||
1404 | wait_for_completion(&task->completion); | 1404 | wait_for_completion(&task->completion); |
1405 | res = -ECOMM; | 1405 | res = -ECOMM; |
1406 | if ((task->task_state_flags & SAS_TASK_STATE_ABORTED)) { | 1406 | if ((task->task_state_flags & SAS_TASK_STATE_ABORTED)) { |
1407 | dev_err(&ihost->pdev->dev, | 1407 | dev_dbg(&ihost->pdev->dev, |
1408 | "%s: smp task timed out or aborted\n", | 1408 | "%s: smp task timed out or aborted\n", |
1409 | __func__); | 1409 | __func__); |
1410 | isci_task_abort_task(task); | 1410 | isci_task_abort_task(task); |
1411 | if (!(task->task_state_flags & SAS_TASK_STATE_DONE)) { | 1411 | if (!(task->task_state_flags & SAS_TASK_STATE_DONE)) { |
1412 | dev_err(&ihost->pdev->dev, | 1412 | dev_dbg(&ihost->pdev->dev, |
1413 | "%s: SMP task aborted and not done\n", | 1413 | "%s: SMP task aborted and not done\n", |
1414 | __func__); | 1414 | __func__); |
1415 | goto ex_err; | 1415 | goto ex_err; |
@@ -1432,7 +1432,7 @@ static int isci_smp_execute_task(struct isci_host *ihost, | |||
1432 | res = -EMSGSIZE; | 1432 | res = -EMSGSIZE; |
1433 | break; | 1433 | break; |
1434 | } else { | 1434 | } else { |
1435 | dev_err(&ihost->pdev->dev, | 1435 | dev_dbg(&ihost->pdev->dev, |
1436 | "%s: task to dev %016llx response: 0x%x " | 1436 | "%s: task to dev %016llx response: 0x%x " |
1437 | "status 0x%x\n", __func__, | 1437 | "status 0x%x\n", __func__, |
1438 | SAS_ADDR(dev->sas_addr), | 1438 | SAS_ADDR(dev->sas_addr), |
@@ -1526,7 +1526,7 @@ static void isci_wait_for_smp_phy_reset(struct isci_remote_device *idev, int phy | |||
1526 | tmo = deadline - jiffies; | 1526 | tmo = deadline - jiffies; |
1527 | 1527 | ||
1528 | if (res) { | 1528 | if (res) { |
1529 | dev_warn(&ihost->pdev->dev, | 1529 | dev_dbg(&ihost->pdev->dev, |
1530 | "%s: iteration %d, phase %d:" | 1530 | "%s: iteration %d, phase %d:" |
1531 | " SMP error=%d, time_remaining=%lu\n", | 1531 | " SMP error=%d, time_remaining=%lu\n", |
1532 | __func__, iteration, phy_state, res, tmo); | 1532 | __func__, iteration, phy_state, res, tmo); |
@@ -1578,7 +1578,7 @@ static int isci_reset_device(struct isci_host *ihost, | |||
1578 | if (status != SCI_SUCCESS) { | 1578 | if (status != SCI_SUCCESS) { |
1579 | spin_unlock_irqrestore(&ihost->scic_lock, flags); | 1579 | spin_unlock_irqrestore(&ihost->scic_lock, flags); |
1580 | 1580 | ||
1581 | dev_warn(&ihost->pdev->dev, | 1581 | dev_dbg(&ihost->pdev->dev, |
1582 | "%s: sci_remote_device_reset(%p) returned %d!\n", | 1582 | "%s: sci_remote_device_reset(%p) returned %d!\n", |
1583 | __func__, idev, status); | 1583 | __func__, idev, status); |
1584 | 1584 | ||
@@ -1619,7 +1619,7 @@ static int isci_reset_device(struct isci_host *ihost, | |||
1619 | } | 1619 | } |
1620 | 1620 | ||
1621 | if (status != SCI_SUCCESS) { | 1621 | if (status != SCI_SUCCESS) { |
1622 | dev_warn(&ihost->pdev->dev, | 1622 | dev_dbg(&ihost->pdev->dev, |
1623 | "%s: sci_remote_device_reset_complete(%p) " | 1623 | "%s: sci_remote_device_reset_complete(%p) " |
1624 | "returned %d!\n", __func__, idev, status); | 1624 | "returned %d!\n", __func__, idev, status); |
1625 | } | 1625 | } |