isci: audit usage of BUG_ON macro in isci driver

Removes unnecessary usage of BUG_ON macro, excluding core directory.
In some cases macro is unnecesary, check is done in caller function.
In other cases macro is replaced by if construction with
appropriate warning.

Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
[changed some survivable bug conditions to WARN_ONCE]
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

1 files changed, 0 insertions, 4 deletions

diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
index 5e63ae6a75d1..5da9a6925cd7 100644
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -362,8 +362,6 @@ static int isci_setup_interrupts(struct pci_dev *pdev)
                 else
                         isr = isci_msix_isr;
 
-                BUG_ON(!isci_host);
-
                 err = devm_request_irq(&pdev->dev, msix->vector, isr, 0,
                                        DRV_NAME"-msix", isci_host);
                 if (!err)
@@ -379,13 +377,11 @@ static int isci_setup_interrupts(struct pci_dev *pdev)
                 pci_disable_msix(pdev);
                 goto intx;
         }
-
         return 0;
 
  intx:
         err = devm_request_irq(&pdev->dev, pdev->irq, isci_intx_isr,
                                IRQF_SHARED, DRV_NAME"-intx", pdev);
-
         return err;
 }