aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/ibmvscsi/ibmvfc.h
diff options
context:
space:
mode:
authorBrian King <brking@linux.vnet.ibm.com>2009-05-28 17:17:26 -0400
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2009-06-08 14:07:34 -0400
commit7d0e462247241b8ec2d377306203b58c7f423553 (patch)
tree8460e4c8b58f05b99a1b802c3be85345d3708e01 /drivers/scsi/ibmvscsi/ibmvfc.h
parent85e2399e925e0afa04dd6e185a910bdd3dc4626b (diff)
[SCSI] ibmvfc: Reduce error logging noise
The ibmvfc driver currently logs errors during discovery for several transient fabric errors, which generally get retried. If retries do not work, we see multiple errors in the log. If retries do work, we see errors in the log which may be confusing since the retry worked. This patch enhances the discovery time error logging to only log errors for command failures during discovery if all allowed retries have been used up. The existing behavior of logging all failures can be restored by setting the hosts log_level to a value of 3 or greater. Signed-off-by: Brian King <brking@linux.vnet.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/ibmvscsi/ibmvfc.h')
-rw-r--r--drivers/scsi/ibmvscsi/ibmvfc.h6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/drivers/scsi/ibmvscsi/ibmvfc.h
index ca1dcf7a7568..4dac3560c1a4 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.h
+++ b/drivers/scsi/ibmvscsi/ibmvfc.h
@@ -707,6 +707,12 @@ struct ibmvfc_host {
707#define tgt_err(t, fmt, ...) \ 707#define tgt_err(t, fmt, ...) \
708 dev_err((t)->vhost->dev, "%llX: " fmt, (t)->scsi_id, ##__VA_ARGS__) 708 dev_err((t)->vhost->dev, "%llX: " fmt, (t)->scsi_id, ##__VA_ARGS__)
709 709
710#define tgt_log(t, level, fmt, ...) \
711 do { \
712 if ((t)->vhost->log_level >= level) \
713 tgt_err(t, fmt, ##__VA_ARGS__); \
714 } while (0)
715
710#define ibmvfc_dbg(vhost, ...) \ 716#define ibmvfc_dbg(vhost, ...) \
711 DBG_CMD(dev_info((vhost)->dev, ##__VA_ARGS__)) 717 DBG_CMD(dev_info((vhost)->dev, ##__VA_ARGS__))
712 718