diff options
author | Julia Lawall <julia@diku.dk> | 2010-05-27 08:33:47 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-07-27 13:01:01 -0400 |
commit | 1db90ea239b85479daedb978ea2f0a61776f074f (patch) | |
tree | bb9c39b5a2aefc7cc4c945341ed1f4dda85b87c9 /drivers/scsi/hptiop.c | |
parent | 2a1b7e575b80ceb19ea50bfa86ce0053ea57181d (diff) |
[SCSI] hptiop: Eliminate a NULL pointer dereference
The end of the function is reachable both when host is and is not NULL.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@
if ((E == NULL && ...) || ...)
{
... when != if (...) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/hptiop.c')
-rw-r--r-- | drivers/scsi/hptiop.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c index 645f7cdf21ab..0729f150b33a 100644 --- a/drivers/scsi/hptiop.c +++ b/drivers/scsi/hptiop.c | |||
@@ -1157,7 +1157,7 @@ free_pci_regions: | |||
1157 | disable_pci_device: | 1157 | disable_pci_device: |
1158 | pci_disable_device(pcidev); | 1158 | pci_disable_device(pcidev); |
1159 | 1159 | ||
1160 | dprintk("scsi%d: hptiop_probe fail\n", host->host_no); | 1160 | dprintk("scsi%d: hptiop_probe fail\n", host ? host->host_no : 0); |
1161 | return -ENODEV; | 1161 | return -ENODEV; |
1162 | } | 1162 | } |
1163 | 1163 | ||