diff options
author | Stephen M. Cameron <scameron@beardog.cce.hp.com> | 2010-05-27 16:13:02 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-07-27 13:01:04 -0400 |
commit | 6b3f4c52b29eee17285a6cd57071c9ac7736d172 (patch) | |
tree | edabbb8f1f35a3def26087d937c123b68cbb8bad /drivers/scsi/hpsa.c | |
parent | 85bdbabbd97ff797f91e6ec839ab053776bc72b4 (diff) |
[SCSI] hpsa: remove redundant board_id parameter from hpsa_interrupt_mode
and delete duplicated comment
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/hpsa.c')
-rw-r--r-- | drivers/scsi/hpsa.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 4233b932ef55..66b7dcfb7276 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c | |||
@@ -3209,7 +3209,7 @@ static int find_PCI_BAR_index(struct pci_dev *pdev, unsigned long pci_bar_addr) | |||
3209 | * controllers that are capable. If not, we use IO-APIC mode. | 3209 | * controllers that are capable. If not, we use IO-APIC mode. |
3210 | */ | 3210 | */ |
3211 | 3211 | ||
3212 | static void __devinit hpsa_interrupt_mode(struct ctlr_info *h, u32 board_id) | 3212 | static void __devinit hpsa_interrupt_mode(struct ctlr_info *h) |
3213 | { | 3213 | { |
3214 | #ifdef CONFIG_PCI_MSI | 3214 | #ifdef CONFIG_PCI_MSI |
3215 | int err; | 3215 | int err; |
@@ -3218,9 +3218,8 @@ static void __devinit hpsa_interrupt_mode(struct ctlr_info *h, u32 board_id) | |||
3218 | }; | 3218 | }; |
3219 | 3219 | ||
3220 | /* Some boards advertise MSI but don't really support it */ | 3220 | /* Some boards advertise MSI but don't really support it */ |
3221 | if ((board_id == 0x40700E11) || | 3221 | if ((h->board_id == 0x40700E11) || (h->board_id == 0x40800E11) || |
3222 | (board_id == 0x40800E11) || | 3222 | (h->board_id == 0x40820E11) || (h->board_id == 0x40830E11)) |
3223 | (board_id == 0x40820E11) || (board_id == 0x40830E11)) | ||
3224 | goto default_int_mode; | 3223 | goto default_int_mode; |
3225 | if (pci_find_capability(h->pdev, PCI_CAP_ID_MSIX)) { | 3224 | if (pci_find_capability(h->pdev, PCI_CAP_ID_MSIX)) { |
3226 | dev_info(&h->pdev->dev, "MSIX\n"); | 3225 | dev_info(&h->pdev->dev, "MSIX\n"); |
@@ -3317,11 +3316,7 @@ static int __devinit hpsa_pci_init(struct ctlr_info *h) | |||
3317 | "cannot obtain PCI resources, aborting\n"); | 3316 | "cannot obtain PCI resources, aborting\n"); |
3318 | return err; | 3317 | return err; |
3319 | } | 3318 | } |
3320 | 3319 | hpsa_interrupt_mode(h); | |
3321 | /* If the kernel supports MSI/MSI-X we will try to enable that, | ||
3322 | * else we use the IO-APIC interrupt assigned to us by system ROM. | ||
3323 | */ | ||
3324 | hpsa_interrupt_mode(h, h->board_id); | ||
3325 | 3320 | ||
3326 | /* find the memory BAR */ | 3321 | /* find the memory BAR */ |
3327 | for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { | 3322 | for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { |