diff options
author | Stephen M. Cameron <scameron@beardog.cce.hp.com> | 2010-02-04 09:41:38 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-02-17 14:17:09 -0500 |
commit | 82a72c0a12326a56a323093297e2bad29fe6c29d (patch) | |
tree | 55d53ca69f8e3252b3824ec3e759f303bb5416a0 /drivers/scsi/hpsa.c | |
parent | 01a02ffcd55b74e3459bb7358140970e126d4731 (diff) |
[SCSI] hpsa: avoid unwanted promotion from unsigned to signed for raid level index
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/hpsa.c')
-rw-r--r-- | drivers/scsi/hpsa.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 0f4a1f3c7e9f..ee9db5ee3cb1 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c | |||
@@ -431,7 +431,7 @@ static ssize_t raid_level_show(struct device *dev, | |||
431 | struct device_attribute *attr, char *buf) | 431 | struct device_attribute *attr, char *buf) |
432 | { | 432 | { |
433 | ssize_t l = 0; | 433 | ssize_t l = 0; |
434 | int rlevel; | 434 | unsigned char rlevel; |
435 | struct ctlr_info *h; | 435 | struct ctlr_info *h; |
436 | struct scsi_device *sdev; | 436 | struct scsi_device *sdev; |
437 | struct hpsa_scsi_dev_t *hdev; | 437 | struct hpsa_scsi_dev_t *hdev; |
@@ -455,7 +455,7 @@ static ssize_t raid_level_show(struct device *dev, | |||
455 | 455 | ||
456 | rlevel = hdev->raid_level; | 456 | rlevel = hdev->raid_level; |
457 | spin_unlock_irqrestore(&h->lock, flags); | 457 | spin_unlock_irqrestore(&h->lock, flags); |
458 | if (rlevel < 0 || rlevel > RAID_UNKNOWN) | 458 | if (rlevel > RAID_UNKNOWN) |
459 | rlevel = RAID_UNKNOWN; | 459 | rlevel = RAID_UNKNOWN; |
460 | l = snprintf(buf, PAGE_SIZE, "RAID %s\n", raid_label[rlevel]); | 460 | l = snprintf(buf, PAGE_SIZE, "RAID %s\n", raid_label[rlevel]); |
461 | return l; | 461 | return l; |