aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/gdth_proc.c
diff options
context:
space:
mode:
authorMatthew Wilcox <matthew@wil.cx>2007-09-25 12:42:03 -0400
committerJames Bottomley <jejb@mulgrave.localdomain>2007-10-12 14:52:41 -0400
commit687d2bc4877081a44c41b5b312e012cc69edda53 (patch)
tree8daf04207eb3fb61fe50aa1c051d09e9060e3de6 /drivers/scsi/gdth_proc.c
parent9ec76fbf7d6da3e98070a7059699d0ca019b0c9b (diff)
[SCSI] gdth: Stop abusing ->done for internal commands
The ->done member was being used to mark commands as being internal. I decided to put a magic number in ->underflow instead. I believe this to be safe as no current user of ->underflow has any of the bottom 9 bits set. Signed-off-by: Matthew Wilcox <willy@linux.intel.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/gdth_proc.c')
-rw-r--r--drivers/scsi/gdth_proc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/gdth_proc.c b/drivers/scsi/gdth_proc.c
index 32982eb75c84..1f8d9a53003b 100644
--- a/drivers/scsi/gdth_proc.c
+++ b/drivers/scsi/gdth_proc.c
@@ -805,7 +805,7 @@ static void gdth_stop_timeout(int hanum, int busnum, int id)
805 spin_lock_irqsave(&ha->smp_lock, flags); 805 spin_lock_irqsave(&ha->smp_lock, flags);
806 806
807 for (scp = ha->req_first; scp; scp = (Scsi_Cmnd *)scp->SCp.ptr) { 807 for (scp = ha->req_first; scp; scp = (Scsi_Cmnd *)scp->SCp.ptr) {
808 if (scp->done != gdth_scsi_done) { 808 if (!IS_GDTH_INTERNAL_CMD(scp)) {
809 b = virt_ctr ? 809 b = virt_ctr ?
810 NUMDATA(scp->device->host)->busnum : scp->device->channel; 810 NUMDATA(scp->device->host)->busnum : scp->device->channel;
811 t = scp->device->id; 811 t = scp->device->id;
@@ -829,7 +829,7 @@ static void gdth_start_timeout(int hanum, int busnum, int id)
829 spin_lock_irqsave(&ha->smp_lock, flags); 829 spin_lock_irqsave(&ha->smp_lock, flags);
830 830
831 for (scp = ha->req_first; scp; scp = (Scsi_Cmnd *)scp->SCp.ptr) { 831 for (scp = ha->req_first; scp; scp = (Scsi_Cmnd *)scp->SCp.ptr) {
832 if (scp->done != gdth_scsi_done) { 832 if (!IS_GDTH_INTERNAL_CMD(scp)) {
833 b = virt_ctr ? 833 b = virt_ctr ?
834 NUMDATA(scp->device->host)->busnum : scp->device->channel; 834 NUMDATA(scp->device->host)->busnum : scp->device->channel;
835 t = scp->device->id; 835 t = scp->device->id;