diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-05-27 08:52:12 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2007-05-27 13:59:28 -0400 |
commit | 6cad75a61d802c5f4f4299103b8f95aeb3ee9876 (patch) | |
tree | 27893a562bd5a968335ee3f77d9b084a6fbbc2ff /drivers/scsi/fdomain.c | |
parent | 565bae6a4a8f16459e179ebf4421c1291cf88aa5 (diff) |
[SCSI] fdomain: fix PCMCIA-related warnings
fdomain is one of those drivers that is compiled twice, once for PCMCIA
and once for non-PCMCIA. The resultant two-driver setup leaves a bit of
dead code and data in the non-PCMCIA case, which gcc complains about.
Shuffle ifdefs a bit to eliminate the conditionally-dead code, and
the compiler warnings.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/fdomain.c')
-rw-r--r-- | drivers/scsi/fdomain.c | 28 |
1 files changed, 24 insertions, 4 deletions
diff --git a/drivers/scsi/fdomain.c b/drivers/scsi/fdomain.c index 0d1661a8116b..36169d597e98 100644 --- a/drivers/scsi/fdomain.c +++ b/drivers/scsi/fdomain.c | |||
@@ -410,6 +410,8 @@ static irqreturn_t do_fdomain_16x0_intr( int irq, void *dev_id ); | |||
410 | static char * fdomain = NULL; | 410 | static char * fdomain = NULL; |
411 | module_param(fdomain, charp, 0); | 411 | module_param(fdomain, charp, 0); |
412 | 412 | ||
413 | #ifndef PCMCIA | ||
414 | |||
413 | static unsigned long addresses[] = { | 415 | static unsigned long addresses[] = { |
414 | 0xc8000, | 416 | 0xc8000, |
415 | 0xca000, | 417 | 0xca000, |
@@ -426,6 +428,8 @@ static unsigned short ports[] = { 0x140, 0x150, 0x160, 0x170 }; | |||
426 | 428 | ||
427 | static unsigned short ints[] = { 3, 5, 10, 11, 12, 14, 15, 0 }; | 429 | static unsigned short ints[] = { 3, 5, 10, 11, 12, 14, 15, 0 }; |
428 | 430 | ||
431 | #endif /* !PCMCIA */ | ||
432 | |||
429 | /* | 433 | /* |
430 | 434 | ||
431 | READ THIS BEFORE YOU ADD A SIGNATURE! | 435 | READ THIS BEFORE YOU ADD A SIGNATURE! |
@@ -458,6 +462,8 @@ static unsigned short ints[] = { 3, 5, 10, 11, 12, 14, 15, 0 }; | |||
458 | 462 | ||
459 | */ | 463 | */ |
460 | 464 | ||
465 | #ifndef PCMCIA | ||
466 | |||
461 | static struct signature { | 467 | static struct signature { |
462 | const char *signature; | 468 | const char *signature; |
463 | int sig_offset; | 469 | int sig_offset; |
@@ -503,6 +509,8 @@ static struct signature { | |||
503 | 509 | ||
504 | #define SIGNATURE_COUNT ARRAY_SIZE(signatures) | 510 | #define SIGNATURE_COUNT ARRAY_SIZE(signatures) |
505 | 511 | ||
512 | #endif /* !PCMCIA */ | ||
513 | |||
506 | static void print_banner( struct Scsi_Host *shpnt ) | 514 | static void print_banner( struct Scsi_Host *shpnt ) |
507 | { | 515 | { |
508 | if (!shpnt) return; /* This won't ever happen */ | 516 | if (!shpnt) return; /* This won't ever happen */ |
@@ -633,6 +641,8 @@ static int fdomain_test_loopback( void ) | |||
633 | return 0; | 641 | return 0; |
634 | } | 642 | } |
635 | 643 | ||
644 | #ifndef PCMCIA | ||
645 | |||
636 | /* fdomain_get_irq assumes that we have a valid MCA ID for a | 646 | /* fdomain_get_irq assumes that we have a valid MCA ID for a |
637 | TMC-1660/TMC-1680 Future Domain board. Now, check to be sure the | 647 | TMC-1660/TMC-1680 Future Domain board. Now, check to be sure the |
638 | bios_base matches these ports. If someone was unlucky enough to have | 648 | bios_base matches these ports. If someone was unlucky enough to have |
@@ -667,7 +677,6 @@ static int fdomain_get_irq( int base ) | |||
667 | 677 | ||
668 | static int fdomain_isa_detect( int *irq, int *iobase ) | 678 | static int fdomain_isa_detect( int *irq, int *iobase ) |
669 | { | 679 | { |
670 | #ifndef PCMCIA | ||
671 | int i, j; | 680 | int i, j; |
672 | int base = 0xdeadbeef; | 681 | int base = 0xdeadbeef; |
673 | int flag = 0; | 682 | int flag = 0; |
@@ -786,11 +795,22 @@ found: | |||
786 | *iobase = base; | 795 | *iobase = base; |
787 | 796 | ||
788 | return 1; /* success */ | 797 | return 1; /* success */ |
789 | #else | ||
790 | return 0; | ||
791 | #endif | ||
792 | } | 798 | } |
793 | 799 | ||
800 | #else /* PCMCIA */ | ||
801 | |||
802 | static int fdomain_isa_detect( int *irq, int *iobase ) | ||
803 | { | ||
804 | if (irq) | ||
805 | *irq = 0; | ||
806 | if (iobase) | ||
807 | *iobase = 0; | ||
808 | return 0; | ||
809 | } | ||
810 | |||
811 | #endif /* !PCMCIA */ | ||
812 | |||
813 | |||
794 | /* PCI detection function: int fdomain_pci_bios_detect(int* irq, int* | 814 | /* PCI detection function: int fdomain_pci_bios_detect(int* irq, int* |
795 | iobase) This function gets the Interrupt Level and I/O base address from | 815 | iobase) This function gets the Interrupt Level and I/O base address from |
796 | the PCI configuration registers. */ | 816 | the PCI configuration registers. */ |