[SCSI] esp, scsi_tgt_lib, fcoe: use list_move() instead of list_del()/list_add() combination

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

1 files changed, 2 insertions, 4 deletions

diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index 9d38be2a41f9..229e4af5508a 100644
--- a/drivers/scsi/fcoe/fcoe_ctlr.c
+++ b/drivers/scsi/fcoe/fcoe_ctlr.c
@@ -978,10 +978,8 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb)
          * the FCF that answers multicast solicitations, not the others that
          * are sending periodic multicast advertisements.
          */
-        if (mtu_valid) {
-                list_del(&fcf->list);
-                list_add(&fcf->list, &fip->fcfs);
-        }
+        if (mtu_valid)
+                list_move(&fcf->list, &fip->fcfs);
 
         /*
          * If this is the first validated FCF, note the time and