aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/fcoe
diff options
context:
space:
mode:
authorChris Leech <christopher.leech@intel.com>2010-04-09 17:23:16 -0400
committerJames Bottomley <James.Bottomley@suse.de>2010-04-11 15:02:42 -0400
commit9f8f3aa640ae5da220eea95215317f19ace91481 (patch)
treeef2d97aee5de5f83e53fe2645a7a30aa8a3980c7 /drivers/scsi/fcoe
parentce8b5df04292e93a117d9f863af206245bf61271 (diff)
[SCSI] libfc, fcoe: normalize format specifies for world wide names
Print all world wide node names (node, port and fabric) with the same format specifier of "%16.16llx". That makes sure they all print as a 16 character hex string, with lower case letters, no 0x prefix, and without stripping off any leading 0s. Signed-off-by: Chris Leech <christopher.leech@intel.com> Signed-off-by: Robert Love <robert.w.love@intel.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/fcoe')
-rw-r--r--drivers/scsi/fcoe/fcoe.c3
-rw-r--r--drivers/scsi/fcoe/libfcoe.c21
2 files changed, 14 insertions, 10 deletions
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 25a7ce5c2d24..aba839e68014 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -934,7 +934,8 @@ static struct fc_lport *fcoe_if_create(struct fcoe_interface *fcoe,
934 } 934 }
935 935
936 if (npiv) { 936 if (npiv) {
937 FCOE_NETDEV_DBG(netdev, "Setting vport names, 0x%llX 0x%llX\n", 937 FCOE_NETDEV_DBG(netdev, "Setting vport names, "
938 "%16.16llx %16.16llx\n",
938 vport->node_name, vport->port_name); 939 vport->node_name, vport->port_name);
939 fc_set_wwnn(lport, vport->node_name); 940 fc_set_wwnn(lport, vport->node_name);
940 fc_set_wwpn(lport, vport->port_name); 941 fc_set_wwpn(lport, vport->port_name);
diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c
index de5c329cb3b4..aadd24962e92 100644
--- a/drivers/scsi/fcoe/libfcoe.c
+++ b/drivers/scsi/fcoe/libfcoe.c
@@ -583,7 +583,7 @@ static void fcoe_ctlr_age_fcfs(struct fcoe_ctlr *fip)
583 smp_processor_id()); 583 smp_processor_id());
584 stats->MissDiscAdvCount++; 584 stats->MissDiscAdvCount++;
585 printk(KERN_INFO "libfcoe: host%d: Missing Discovery " 585 printk(KERN_INFO "libfcoe: host%d: Missing Discovery "
586 "Advertisement for fab %llx count %lld\n", 586 "Advertisement for fab %16.16llx count %lld\n",
587 fip->lp->host->host_no, fcf->fabric_name, 587 fip->lp->host->host_no, fcf->fabric_name,
588 stats->MissDiscAdvCount); 588 stats->MissDiscAdvCount);
589 } 589 }
@@ -780,7 +780,8 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb)
780 mtu_valid = fcoe_ctlr_mtu_valid(fcf); 780 mtu_valid = fcoe_ctlr_mtu_valid(fcf);
781 fcf->time = jiffies; 781 fcf->time = jiffies;
782 if (!found) { 782 if (!found) {
783 LIBFCOE_FIP_DBG(fip, "New FCF for fab %llx map %x val %d\n", 783 LIBFCOE_FIP_DBG(fip, "New FCF for fab %16.16llx "
784 "map %x val %d\n",
784 fcf->fabric_name, fcf->fc_map, mtu_valid); 785 fcf->fabric_name, fcf->fc_map, mtu_valid);
785 } 786 }
786 787
@@ -1108,15 +1109,17 @@ static void fcoe_ctlr_select(struct fcoe_ctlr *fip)
1108 struct fcoe_fcf *best = NULL; 1109 struct fcoe_fcf *best = NULL;
1109 1110
1110 list_for_each_entry(fcf, &fip->fcfs, list) { 1111 list_for_each_entry(fcf, &fip->fcfs, list) {
1111 LIBFCOE_FIP_DBG(fip, "consider FCF for fab %llx VFID %d map %x " 1112 LIBFCOE_FIP_DBG(fip, "consider FCF for fab %16.16llx "
1112 "val %d\n", fcf->fabric_name, fcf->vfid, 1113 "VFID %d map %x val %d\n",
1114 fcf->fabric_name, fcf->vfid,
1113 fcf->fc_map, fcoe_ctlr_mtu_valid(fcf)); 1115 fcf->fc_map, fcoe_ctlr_mtu_valid(fcf));
1114 if (!fcoe_ctlr_fcf_usable(fcf)) { 1116 if (!fcoe_ctlr_fcf_usable(fcf)) {
1115 LIBFCOE_FIP_DBG(fip, "FCF for fab %llx map %x %svalid " 1117 LIBFCOE_FIP_DBG(fip, "FCF for fab %16.16llx "
1116 "%savailable\n", fcf->fabric_name, 1118 "map %x %svalid %savailable\n",
1117 fcf->fc_map, (fcf->flags & FIP_FL_SOL) 1119 fcf->fabric_name, fcf->fc_map,
1118 ? "" : "in", (fcf->flags & FIP_FL_AVAIL) 1120 (fcf->flags & FIP_FL_SOL) ? "" : "in",
1119 ? "" : "un"); 1121 (fcf->flags & FIP_FL_AVAIL) ?
1122 "" : "un");
1120 continue; 1123 continue;
1121 } 1124 }
1122 if (!best) { 1125 if (!best) {