[SCSI] libfcoe: reorder FCF list to put latest advertiser first

When there are several FCFs to choose from, the one most likely
to accept a FLOGI on certian switches is the one that last
answered a multicast solicit.

So, when receiving an advertisement, move the FCF to the front
of the list so that it gets chosen first among those with the
same priority.

Without this, more FLOGIs need to be sent in a test with
multiple FCFs and a switch in NPV mode, but it still
eventually finds one that accepts the FLOGI.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

1 files changed, 11 insertions, 0 deletions

diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c
index dcccb0bf3170..1a0bb230dd03 100644
--- a/drivers/scsi/fcoe/libfcoe.c
+++ b/drivers/scsi/fcoe/libfcoe.c
@@ -1000,6 +1000,17 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb)
                 fcoe_ctlr_solicit(fip, NULL);
 
         /*
+         * Put this FCF at the head of the list for priority among equals.
+         * This helps in the case of an NPV switch which insists we use
+         * the FCF that answers multicast solicitations, not the others that
+         * are sending periodic multicast advertisements.
+         */
+        if (mtu_valid) {
+                list_del(&fcf->list);
+                list_add(&fcf->list, &fip->fcfs);
+        }
+
+        /*
          * If this is the first validated FCF, note the time and
          * set a timer to trigger selection.
          */