Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6

* git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (71 commits)
  [SCSI] fcoe: cleanup cpu selection for incoming requests
  [SCSI] fcoe: add fip retry to avoid missing critical keep alive
  [SCSI] libfc: fix warn on in lport retry
  [SCSI] libfc: Remove the reference to FCP packet from scsi_cmnd in case of error
  [SCSI] libfc: cleanup sending SRR request
  [SCSI] libfc: two minor changes in comments
  [SCSI] libfc, fcoe: ignore rx frame with wrong xid info
  [SCSI] libfc: release exchg cache
  [SCSI] libfc: use FC_MAX_ERROR_CNT
  [SCSI] fcoe: remove unused ptype field in fcoe_rcv_info
  [SCSI] bnx2fc: Update copyright and bump version to 1.0.4
  [SCSI] bnx2fc: Tx BDs cache in write tasks
  [SCSI] bnx2fc: Do not arm CQ when there are no CQEs
  [SCSI] bnx2fc: hold tgt lock when calling cmd_release
  [SCSI] bnx2fc: Enable support for sequence level error recovery
  [SCSI] bnx2fc: HSI changes for tape
  [SCSI] bnx2fc: Handle REC_TOV error code from firmware
  [SCSI] bnx2fc: REC/SRR link service request and response handling
  [SCSI] bnx2fc: Support 'sequence cleanup' task
  [SCSI] dh_rdac: Associate HBA and storage in rdac_controller to support partitions in storage
  ...

1 files changed, 32 insertions, 37 deletions

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 204fa8d4b4ab..ba710e350ac5 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -487,6 +487,19 @@ static int fcoe_fip_recv(struct sk_buff *skb, struct net_device *netdev,
 }
 
 /**
+ * fcoe_port_send() - Send an Ethernet-encapsulated FIP/FCoE frame
+ * @port: The FCoE port
+ * @skb: The FIP/FCoE packet to be sent
+ */
+static void fcoe_port_send(struct fcoe_port *port, struct sk_buff *skb)
+{
+        if (port->fcoe_pending_queue.qlen)
+                fcoe_check_wait_queue(port->lport, skb);
+        else if (fcoe_start_io(skb))
+                fcoe_check_wait_queue(port->lport, skb);
+}
+
+/**
  * fcoe_fip_send() - Send an Ethernet-encapsulated FIP frame
  * @fip: The FCoE controller
  * @skb: The FIP packet to be sent
@@ -494,7 +507,7 @@ static int fcoe_fip_recv(struct sk_buff *skb, struct net_device *netdev,
 static void fcoe_fip_send(struct fcoe_ctlr *fip, struct sk_buff *skb)
 {
         skb->dev = fcoe_from_ctlr(fip)->netdev;
-        dev_queue_xmit(skb);
+        fcoe_port_send(lport_priv(fip->lp), skb);
 }
 
 /**
@@ -1257,30 +1270,20 @@ static int fcoe_cpu_callback(struct notifier_block *nfb,
 /**
  * fcoe_select_cpu() - Selects CPU to handle post-processing of incoming
  *                      command.
- * @curr_cpu:   CPU which received request
  *
- * This routine selects next CPU based on cpumask.
+ * This routine selects next CPU based on cpumask to distribute
+ * incoming requests in round robin.
  *
- * Returns: int (CPU number). Caller to verify if returned CPU is online or not.
+ * Returns: int CPU number
  */
-static unsigned int fcoe_select_cpu(unsigned int curr_cpu)
+static inline unsigned int fcoe_select_cpu(void)
 {
         static unsigned int selected_cpu;
 
-        if (num_online_cpus() == 1)
-                return curr_cpu;
-        /*
-         * Doing following check, to skip "curr_cpu (smp_processor_id)"
-         * from selection of CPU is intentional. This is to avoid same CPU
-         * doing post-processing of command. "curr_cpu" to just receive
-         * incoming request in case where rx_id is UNKNOWN and all other
-         * CPU to actually process the command(s)
-         */
-        do {
-                selected_cpu = cpumask_next(selected_cpu, cpu_online_mask);
-                if (selected_cpu >= nr_cpu_ids)
-                        selected_cpu = cpumask_first(cpu_online_mask);
-        } while (selected_cpu == curr_cpu);
+        selected_cpu = cpumask_next(selected_cpu, cpu_online_mask);
+        if (selected_cpu >= nr_cpu_ids)
+                selected_cpu = cpumask_first(cpu_online_mask);
+
         return selected_cpu;
 }
 
@@ -1350,30 +1353,26 @@ int fcoe_rcv(struct sk_buff *skb, struct net_device *netdev,
 
         fr = fcoe_dev_from_skb(skb);
         fr->fr_dev = lport;
-        fr->ptype = ptype;
 
         /*
          * In case the incoming frame's exchange is originated from
          * the initiator, then received frame's exchange id is ANDed
          * with fc_cpu_mask bits to get the same cpu on which exchange
-         * was originated, otherwise just use the current cpu.
+         * was originated, otherwise select cpu using rx exchange id
+         * or fcoe_select_cpu().
          */
         if (ntoh24(fh->fh_f_ctl) & FC_FC_EX_CTX)
                 cpu = ntohs(fh->fh_ox_id) & fc_cpu_mask;
         else {
-                cpu = smp_processor_id();
-
-                if ((fh->fh_type == FC_TYPE_FCP) &&
-                    (ntohs(fh->fh_rx_id) == FC_XID_UNKNOWN)) {
-                        do {
-                                cpu = fcoe_select_cpu(cpu);
-                        } while (!cpu_online(cpu));
-                } else  if ((fh->fh_type == FC_TYPE_FCP) &&
-                            (ntohs(fh->fh_rx_id) != FC_XID_UNKNOWN)) {
+                if (ntohs(fh->fh_rx_id) == FC_XID_UNKNOWN)
+                        cpu = fcoe_select_cpu();
+                else
                         cpu = ntohs(fh->fh_rx_id) & fc_cpu_mask;
-                } else
-                        cpu = smp_processor_id();
         }
+
+        if (cpu >= nr_cpu_ids)
+                goto err;
+
         fps = &per_cpu(fcoe_percpu, cpu);
         spin_lock_bh(&fps->fcoe_rx_list.lock);
         if (unlikely(!fps->thread)) {
@@ -1572,11 +1571,7 @@ int fcoe_xmit(struct fc_lport *lport, struct fc_frame *fp)
 
         /* send down to lld */
         fr_dev(fp) = lport;
-        if (port->fcoe_pending_queue.qlen)
-                fcoe_check_wait_queue(lport, skb);
-        else if (fcoe_start_io(skb))
-                fcoe_check_wait_queue(lport, skb);
-
+        fcoe_port_send(port, skb);
         return 0;
 }