diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-03-16 06:07:56 -0400 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2013-05-02 10:37:10 -0400 |
| commit | 4f8d1bd273684385fa8e8e4f9b8bd6107016ece8 (patch) | |
| tree | 733e563e854d5fd62c24d0125b1abf440f228768 /drivers/scsi/csiostor | |
| parent | 0a7d1d360aa3c7578deff480db080ac2544725e8 (diff) | |
[SCSI] csiostor: off by one error
We need to store PROTO_ERR_IMPL_LOGO (26) things here, but the
first element isn't used so the array should have 27 elements.
This matches fwevt_to_rnevt[] which has 27 elements.
The patch solves a Smatch static checker warning on my system:
drivers/scsi/csiostor/csio_rnode.c:880 csio_rnode_fwevt_handler()
error: buffer overflow '(rn)->stats.n_evt_fw' 26 <= 26
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Naresh Kumar Inna <naresh@chelsio.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/csiostor')
| -rw-r--r-- | drivers/scsi/csiostor/csio_lnode.h | 2 | ||||
| -rw-r--r-- | drivers/scsi/csiostor/csio_rnode.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/csiostor/csio_lnode.h b/drivers/scsi/csiostor/csio_lnode.h index 0f9c04175b11..372a67d122d3 100644 --- a/drivers/scsi/csiostor/csio_lnode.h +++ b/drivers/scsi/csiostor/csio_lnode.h | |||
| @@ -114,7 +114,7 @@ struct csio_lnode_stats { | |||
| 114 | uint32_t n_rnode_match; /* matched rnode */ | 114 | uint32_t n_rnode_match; /* matched rnode */ |
| 115 | uint32_t n_dev_loss_tmo; /* Device loss timeout */ | 115 | uint32_t n_dev_loss_tmo; /* Device loss timeout */ |
| 116 | uint32_t n_fdmi_err; /* fdmi err */ | 116 | uint32_t n_fdmi_err; /* fdmi err */ |
| 117 | uint32_t n_evt_fw[PROTO_ERR_IMPL_LOGO]; /* fw events */ | 117 | uint32_t n_evt_fw[PROTO_ERR_IMPL_LOGO + 1]; /* fw events */ |
| 118 | enum csio_ln_ev n_evt_sm[CSIO_LNE_MAX_EVENT]; /* State m/c events */ | 118 | enum csio_ln_ev n_evt_sm[CSIO_LNE_MAX_EVENT]; /* State m/c events */ |
| 119 | uint32_t n_rnode_alloc; /* rnode allocated */ | 119 | uint32_t n_rnode_alloc; /* rnode allocated */ |
| 120 | uint32_t n_rnode_free; /* rnode freed */ | 120 | uint32_t n_rnode_free; /* rnode freed */ |
diff --git a/drivers/scsi/csiostor/csio_rnode.h b/drivers/scsi/csiostor/csio_rnode.h index 65940096a80d..433434221222 100644 --- a/drivers/scsi/csiostor/csio_rnode.h +++ b/drivers/scsi/csiostor/csio_rnode.h | |||
| @@ -63,7 +63,7 @@ struct csio_rnode_stats { | |||
| 63 | uint32_t n_err_nomem; /* error nomem */ | 63 | uint32_t n_err_nomem; /* error nomem */ |
| 64 | uint32_t n_evt_unexp; /* unexpected event */ | 64 | uint32_t n_evt_unexp; /* unexpected event */ |
| 65 | uint32_t n_evt_drop; /* unexpected event */ | 65 | uint32_t n_evt_drop; /* unexpected event */ |
| 66 | uint32_t n_evt_fw[PROTO_ERR_IMPL_LOGO]; /* fw events */ | 66 | uint32_t n_evt_fw[PROTO_ERR_IMPL_LOGO + 1]; /* fw events */ |
| 67 | enum csio_rn_ev n_evt_sm[CSIO_RNFE_MAX_EVENT]; /* State m/c events */ | 67 | enum csio_rn_ev n_evt_sm[CSIO_RNFE_MAX_EVENT]; /* State m/c events */ |
| 68 | uint32_t n_lun_rst; /* Number of resets of | 68 | uint32_t n_lun_rst; /* Number of resets of |
| 69 | * of LUNs under this | 69 | * of LUNs under this |