diff options
author | Kyle McMartin <kmcmarti@redhat.com> | 2012-07-11 12:42:55 -0400 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2012-07-20 03:59:03 -0400 |
commit | 0b1017aab197271a78169fde3d7e487bb721997c (patch) | |
tree | 9f918a9be6eec209eba3a81e3d8cde58a1c1ff6c /drivers/scsi/bfa | |
parent | e67f13212a2b48a19b7c8433df40439177963a57 (diff) |
[SCSI] bfa: squelch lockdep complaint with a spin_lock_init
Spotted this while looking at another issue...
INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
Pid: 298, comm: udevd Not tainted 3.3.0 #1
Call Trace:
[<ffffffff810cee63>] __lock_acquire+0x1363/0x1bb0
[<ffffffff816593d2>] ? __slab_alloc+0x4a0/0x4fd
[<ffffffff81020063>] ? native_sched_clock+0x13/0x80
[<ffffffff810200d9>] ? sched_clock+0x9/0x10
[<ffffffff810cfd81>] lock_acquire+0xa1/0x1e0
[<ffffffffa0321b83>] ? bfa_fcs_lport_aen_post+0x43/0x160 [bfa]
[<ffffffff816630e5>] _raw_spin_lock_irqsave+0x65/0xb0
[<ffffffffa0321b83>] ? bfa_fcs_lport_aen_post+0x43/0x160 [bfa]
[<ffffffffa0321b83>] bfa_fcs_lport_aen_post+0x43/0x160 [bfa]
[<ffffffffa032fa57>] bfa_fcs_lport_init+0x97/0x120 [bfa]
[<ffffffffa031d4ff>] bfa_fcs_fabric_sm_uninit+0x1cf/0x250 [bfa]
[<ffffffffa031c1da>] bfa_fcs_fabric_modinit+0x2a/0xb0 [bfa]
[<ffffffffa031bef2>] ? bfa_fcs_fabric_attach+0xf2/0x170 [bfa]
[<ffffffffa031e75a>] bfa_fcs_init+0x2a/0x40 [bfa]
[<ffffffffa02facf7>] bfad_drv_init+0x107/0x1f0 [bfa]
[<ffffffffa02fb057>] bfad_pci_probe+0x277/0x450 [bfa]
[<ffffffff81354d4c>] local_pci_probe+0x5c/0xd0
[<ffffffff81354ed1>] pci_device_probe+0x111/0x120
[<ffffffff8141c0e6>] driver_probe_device+0x96/0x2f0
[<ffffffff8141c3eb>] __driver_attach+0xab/0xb0
[<ffffffff8141c340>] ? driver_probe_device+0x2f0/0x2f0
[<ffffffff8141a2e5>] bus_for_each_dev+0x55/0x90
[<ffffffffa037b000>] ? 0xffffffffa037afff
[<ffffffff8141bbce>] driver_attach+0x1e/0x20
[<ffffffff8141b8d8>] bus_add_driver+0x1b8/0x2b0
[<ffffffffa037b000>] ? 0xffffffffa037afff
[<ffffffff8141cbc7>] driver_register+0x77/0x160
[<ffffffffa037b000>] ? 0xffffffffa037afff
[<ffffffff81353b23>] __pci_register_driver+0x73/0xf0
[<ffffffffa037b000>] ? 0xffffffffa037afff
[<ffffffffa037b083>] bfad_init+0x83/0x1000 [bfa]
[<ffffffff8100212a>] do_one_initcall+0x12a/0x180
[<ffffffff810df0d0>] sys_init_module+0xc0/0x220
[<ffffffff8166bbe9>] system_call_fastpath+0x16/0x1b
Signed-off-by: Kyle McMartin <kmcmarti@redhat.com>
Acked-by: Krishna Gudipati <kgudipat@brocade.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/bfa')
-rw-r--r-- | drivers/scsi/bfa/bfad.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index 2e4b0be14a20..2c8f0c713076 100644 --- a/drivers/scsi/bfa/bfad.c +++ b/drivers/scsi/bfa/bfad.c | |||
@@ -1383,6 +1383,8 @@ bfad_pci_probe(struct pci_dev *pdev, const struct pci_device_id *pid) | |||
1383 | bfa_sm_set_state(bfad, bfad_sm_uninit); | 1383 | bfa_sm_set_state(bfad, bfad_sm_uninit); |
1384 | 1384 | ||
1385 | spin_lock_init(&bfad->bfad_lock); | 1385 | spin_lock_init(&bfad->bfad_lock); |
1386 | spin_lock_init(&bfad->bfad_aen_spinlock); | ||
1387 | |||
1386 | pci_set_drvdata(pdev, bfad); | 1388 | pci_set_drvdata(pdev, bfad); |
1387 | 1389 | ||
1388 | bfad->ref_count = 0; | 1390 | bfad->ref_count = 0; |