diff options
author | Mike Christie <michaelc@cs.wisc.edu> | 2011-06-24 16:11:52 -0400 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2011-06-29 17:43:03 -0400 |
commit | 9d04516310aaef3970c642a54531a52123001178 (patch) | |
tree | 2e1948a93a6a136ebfc9f1ad08b6ab4d200b05cc /drivers/scsi/be2iscsi | |
parent | c682d602d0f9751c92e07c196be27d8fac6ec3ed (diff) |
[SCSI] iscsi_boot_sysfs: have this module check for null on destruction
This moves the check for NULL boot_sets to the iscsi_boot_sysfs
module instead of having the drivers do it.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/be2iscsi')
-rw-r--r-- | drivers/scsi/be2iscsi/be_main.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 7b967ed48962..2e214390c63b 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c | |||
@@ -420,8 +420,7 @@ static int beiscsi_setup_boot_info(struct beiscsi_hba *phba) | |||
420 | return 0; | 420 | return 0; |
421 | 421 | ||
422 | free_kset: | 422 | free_kset: |
423 | if (phba->boot_kset) | 423 | iscsi_boot_destroy_kset(phba->boot_kset); |
424 | iscsi_boot_destroy_kset(phba->boot_kset); | ||
425 | return -ENOMEM; | 424 | return -ENOMEM; |
426 | } | 425 | } |
427 | 426 | ||
@@ -4149,8 +4148,7 @@ static void beiscsi_remove(struct pci_dev *pcidev) | |||
4149 | phba->ctrl.mbox_mem_alloced.size, | 4148 | phba->ctrl.mbox_mem_alloced.size, |
4150 | phba->ctrl.mbox_mem_alloced.va, | 4149 | phba->ctrl.mbox_mem_alloced.va, |
4151 | phba->ctrl.mbox_mem_alloced.dma); | 4150 | phba->ctrl.mbox_mem_alloced.dma); |
4152 | if (phba->boot_kset) | 4151 | iscsi_boot_destroy_kset(phba->boot_kset); |
4153 | iscsi_boot_destroy_kset(phba->boot_kset); | ||
4154 | iscsi_host_remove(phba->shost); | 4152 | iscsi_host_remove(phba->shost); |
4155 | pci_dev_put(phba->pcidev); | 4153 | pci_dev_put(phba->pcidev); |
4156 | iscsi_host_free(phba->shost); | 4154 | iscsi_host_free(phba->shost); |