[SCSI] be2iscsi: Fix return value and typo.

Fix return value and typo in the message displayed.
Fix the goto label when wrb_hanlde allocation fails.
Fix the error message display in beiscsi_alloc_pdu

Signed-off-by: John Soni Jose <sony.john-n@emulex.com>
Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

1 files changed, 6 insertions, 7 deletions

diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
index aedb0d9a9dae..3f41fc0b5712 100644
--- a/drivers/scsi/be2iscsi/be_iscsi.c
+++ b/drivers/scsi/be2iscsi/be_iscsi.c
@@ -531,9 +531,9 @@ static int be2iscsi_get_if_param(struct beiscsi_hba *phba,
                 break;
         case ISCSI_NET_PARAM_IPV4_BOOTPROTO:
                 if (!if_info.dhcp_state)
-                        len = sprintf(buf, "static");
+                        len = sprintf(buf, "static\n");
                 else
-                        len = sprintf(buf, "dhcp");
+                        len = sprintf(buf, "dhcp\n");
                 break;
         case ISCSI_NET_PARAM_IPV4_SUBNET:
                 len = sprintf(buf, "%pI4\n", &if_info.ip_addr.subnet_mask);
@@ -541,7 +541,7 @@ static int be2iscsi_get_if_param(struct beiscsi_hba *phba,
         case ISCSI_NET_PARAM_VLAN_ENABLED:
                 len = sprintf(buf, "%s\n",
                              (if_info.vlan_priority == BEISCSI_VLAN_DISABLE)
-                             ? "Disabled" : "Enabled");
+                             ? "Disabled\n" : "Enabled\n");
                 break;
         case ISCSI_NET_PARAM_VLAN_ID:
                 if (if_info.vlan_priority == BEISCSI_VLAN_DISABLE)
@@ -586,7 +586,7 @@ int be2iscsi_iface_get_param(struct iscsi_iface *iface,
                 len = be2iscsi_get_if_param(phba, iface, param, buf);
                 break;
         case ISCSI_NET_PARAM_IFACE_ENABLE:
-                len = sprintf(buf, "enabled");
+                len = sprintf(buf, "enabled\n");
                 break;
         case ISCSI_NET_PARAM_IPV4_GW:
                 memset(&gateway, 0, sizeof(gateway));
@@ -731,7 +731,6 @@ static int beiscsi_get_initname(char *buf, struct beiscsi_hba *phba)
  * beiscsi_get_port_state - Get the Port State
  * @shost : pointer to scsi_host structure
  *
- * returns number of bytes
  */
 static void beiscsi_get_port_state(struct Scsi_Host *shost)
 {
@@ -1150,8 +1149,8 @@ beiscsi_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr,
 
         if (phba->state != BE_ADAPTER_UP) {
                 ret = -EBUSY;
-                beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_CONFIG,
-                            "BS_%d : The Adapter state is Not UP\n");
+                beiscsi_log(phba, KERN_WARNING, BEISCSI_LOG_CONFIG,
+                            "BS_%d : The Adapter Port state is Down!!!\n");
                 return ERR_PTR(ret);
         }