diff options
author | Jayamohan Kallickal <jayamohank@serverengines.com> | 2010-07-21 18:46:38 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-07-28 10:05:29 -0400 |
commit | d3ad2bb31c26d7314fad98da8abb04f4fa24ed16 (patch) | |
tree | cf2ccd6434cddce6e6c52df040b032384a52875a /drivers/scsi/be2iscsi/be_cmds.c | |
parent | 457ff3b7dc3796d8778286217ad304ff122e948f (diff) |
[SCSI] be2iscsi: Fixing return values
This patch fixes the return values as per comment from Mike Christie
Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/be2iscsi/be_cmds.c')
-rw-r--r-- | drivers/scsi/be2iscsi/be_cmds.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 4f19030c1e3e..9cc1f5573150 100644 --- a/drivers/scsi/be2iscsi/be_cmds.c +++ b/drivers/scsi/be2iscsi/be_cmds.c | |||
@@ -98,7 +98,7 @@ static int be_mcc_compl_process(struct be_ctrl_info *ctrl, | |||
98 | dev_err(&ctrl->pdev->dev, | 98 | dev_err(&ctrl->pdev->dev, |
99 | "error in cmd completion: status(compl/extd)=%d/%d\n", | 99 | "error in cmd completion: status(compl/extd)=%d/%d\n", |
100 | compl_status, extd_status); | 100 | compl_status, extd_status); |
101 | return -1; | 101 | return -EBUSY; |
102 | } | 102 | } |
103 | return 0; | 103 | return 0; |
104 | } | 104 | } |
@@ -231,7 +231,7 @@ static int be_mcc_wait_compl(struct beiscsi_hba *phba) | |||
231 | } | 231 | } |
232 | if (i == mcc_timeout) { | 232 | if (i == mcc_timeout) { |
233 | dev_err(&phba->pcidev->dev, "mccq poll timed out\n"); | 233 | dev_err(&phba->pcidev->dev, "mccq poll timed out\n"); |
234 | return -1; | 234 | return -EBUSY; |
235 | } | 235 | } |
236 | return 0; | 236 | return 0; |
237 | } | 237 | } |
@@ -257,7 +257,7 @@ static int be_mbox_db_ready_wait(struct be_ctrl_info *ctrl) | |||
257 | 257 | ||
258 | if (cnt > 6000000) { | 258 | if (cnt > 6000000) { |
259 | dev_err(&ctrl->pdev->dev, "mbox_db poll timed out\n"); | 259 | dev_err(&ctrl->pdev->dev, "mbox_db poll timed out\n"); |
260 | return -1; | 260 | return -EBUSY; |
261 | } | 261 | } |
262 | 262 | ||
263 | if (cnt > 50) { | 263 | if (cnt > 50) { |
@@ -309,7 +309,7 @@ int be_mbox_notify(struct be_ctrl_info *ctrl) | |||
309 | } | 309 | } |
310 | } else { | 310 | } else { |
311 | dev_err(&ctrl->pdev->dev, "invalid mailbox completion\n"); | 311 | dev_err(&ctrl->pdev->dev, "invalid mailbox completion\n"); |
312 | return -1; | 312 | return -EBUSY; |
313 | } | 313 | } |
314 | return 0; | 314 | return 0; |
315 | } | 315 | } |
@@ -355,7 +355,7 @@ static int be_mbox_notify_wait(struct beiscsi_hba *phba) | |||
355 | return status; | 355 | return status; |
356 | } else { | 356 | } else { |
357 | dev_err(&phba->pcidev->dev, "invalid mailbox completion\n"); | 357 | dev_err(&phba->pcidev->dev, "invalid mailbox completion\n"); |
358 | return -1; | 358 | return -EBUSY; |
359 | } | 359 | } |
360 | return 0; | 360 | return 0; |
361 | } | 361 | } |
@@ -652,7 +652,7 @@ int beiscsi_cmd_q_destroy(struct be_ctrl_info *ctrl, struct be_queue_info *q, | |||
652 | default: | 652 | default: |
653 | spin_unlock(&ctrl->mbox_lock); | 653 | spin_unlock(&ctrl->mbox_lock); |
654 | BUG(); | 654 | BUG(); |
655 | return -1; | 655 | return -ENXIO; |
656 | } | 656 | } |
657 | be_cmd_hdr_prepare(&req->hdr, subsys, opcode, sizeof(*req)); | 657 | be_cmd_hdr_prepare(&req->hdr, subsys, opcode, sizeof(*req)); |
658 | if (queue_type != QTYPE_SGL) | 658 | if (queue_type != QTYPE_SGL) |