diff options
author | Finn Thain <fthain@telegraphics.com.au> | 2014-11-12 00:11:54 -0500 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2014-11-20 03:11:06 -0500 |
commit | 997acab7d593913eaa0606ff257079efcfcb146d (patch) | |
tree | 239997e829da105725a82d12d981c2ae9b6d4189 /drivers/scsi/atari_NCR5380.c | |
parent | 76f13b9321ec8f9550cd1557ed28ac6ae91e612c (diff) |
ncr5380: Remove redundant AUTOSENSE macro
Every NCR5380 driver sets AUTOSENSE so it need not be optional (and the
mid-layer expects it). Remove this redundant macro to improve readability.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/atari_NCR5380.c')
-rw-r--r-- | drivers/scsi/atari_NCR5380.c | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/drivers/scsi/atari_NCR5380.c b/drivers/scsi/atari_NCR5380.c index 3cfd39c583ad..f69d36327a7d 100644 --- a/drivers/scsi/atari_NCR5380.c +++ b/drivers/scsi/atari_NCR5380.c | |||
@@ -683,9 +683,6 @@ static inline void NCR5380_all_init(void) | |||
683 | static void __init NCR5380_print_options(struct Scsi_Host *instance) | 683 | static void __init NCR5380_print_options(struct Scsi_Host *instance) |
684 | { | 684 | { |
685 | printk(" generic options" | 685 | printk(" generic options" |
686 | #ifdef AUTOSENSE | ||
687 | " AUTOSENSE" | ||
688 | #endif | ||
689 | #ifdef REAL_DMA | 686 | #ifdef REAL_DMA |
690 | " REAL DMA" | 687 | " REAL DMA" |
691 | #endif | 688 | #endif |
@@ -842,13 +839,6 @@ static int __init NCR5380_init(struct Scsi_Host *instance, int flags) | |||
842 | first_instance = instance; | 839 | first_instance = instance; |
843 | } | 840 | } |
844 | 841 | ||
845 | #ifndef AUTOSENSE | ||
846 | if ((instance->cmd_per_lun > 1) || (instance->can_queue > 1)) | ||
847 | printk("scsi%d: WARNING : support for multiple outstanding commands enabled\n" | ||
848 | " without AUTOSENSE option, contingent allegiance conditions may\n" | ||
849 | " be incorrectly cleared.\n", HOSTNO); | ||
850 | #endif /* def AUTOSENSE */ | ||
851 | |||
852 | NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE); | 842 | NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE); |
853 | NCR5380_write(MODE_REG, MR_BASE); | 843 | NCR5380_write(MODE_REG, MR_BASE); |
854 | NCR5380_write(TARGET_COMMAND_REG, 0); | 844 | NCR5380_write(TARGET_COMMAND_REG, 0); |
@@ -2199,7 +2189,6 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) | |||
2199 | else if (status_byte(cmd->SCp.Status) != GOOD) | 2189 | else if (status_byte(cmd->SCp.Status) != GOOD) |
2200 | cmd->result = (cmd->result & 0x00ffff) | (DID_ERROR << 16); | 2190 | cmd->result = (cmd->result & 0x00ffff) | (DID_ERROR << 16); |
2201 | 2191 | ||
2202 | #ifdef AUTOSENSE | ||
2203 | if ((cmd->cmnd[0] == REQUEST_SENSE) && | 2192 | if ((cmd->cmnd[0] == REQUEST_SENSE) && |
2204 | hostdata->ses.cmd_len) { | 2193 | hostdata->ses.cmd_len) { |
2205 | scsi_eh_restore_cmnd(cmd, &hostdata->ses); | 2194 | scsi_eh_restore_cmnd(cmd, &hostdata->ses); |
@@ -2219,9 +2208,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) | |||
2219 | local_irq_restore(flags); | 2208 | local_irq_restore(flags); |
2220 | dprintk(NDEBUG_QUEUES, "scsi%d: REQUEST SENSE added to head of " | 2209 | dprintk(NDEBUG_QUEUES, "scsi%d: REQUEST SENSE added to head of " |
2221 | "issue queue\n", H_NO(cmd)); | 2210 | "issue queue\n", H_NO(cmd)); |
2222 | } else | 2211 | } else { |
2223 | #endif /* def AUTOSENSE */ | ||
2224 | { | ||
2225 | #ifdef NCR5380_STATS | 2212 | #ifdef NCR5380_STATS |
2226 | collect_stats(hostdata, cmd); | 2213 | collect_stats(hostdata, cmd); |
2227 | #endif | 2214 | #endif |