Merge master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6

* master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (97 commits)
  [SCSI] zfcp: removed wrong comment
  [SCSI] zfcp: use of uninitialized variable
  [SCSI] zfcp: Invalid locking order
  [SCSI] aic79xx: use dma_get_required_mask()
  [SCSI] aic79xx: fix bracket mismatch in unused macro
  [SCSI] BusLogic: Replace 'boolean' by 'bool'
  [SCSI] advansys: clean up warnings
  [SCSI] 53c7xx: brackets fix in uncompiled code
  [SCSI] nsp_cs: remove old scsi code
  [SCSI] aic79xx: make ahd_match_scb() static
  [SCSI] DAC960: kmalloc->kzalloc/Casting cleanups
  [SCSI] scsi_kmap_atomic_sg(): check that local irqs are disabled
  [SCSI] Buslogic: local_irq_disable() is redundant after local_irq_save()
  [SCSI] aic94xx: update for v28 firmware
  [SCSI] scsi_error: Fix lost EH commands
  [SCSI] aic94xx: Add default bus reset handler
  [SCSI] aic94xx: Remove TMF result code munging
  [SCSI] libsas: Add an LU reset mechanism to the error handler
  [SCSI] libsas: Don't BUG when connecting two expanders via wide port
  [SCSI] st: fix Tape dies if wrong block size used, bug 7919
  ...

11 files changed, 164 insertions, 100 deletions

diff --git a/drivers/scsi/aic94xx/aic94xx_dev.c b/drivers/scsi/aic94xx/aic94xx_dev.c
index 6f8901b748f7..c520e5b41fb5 100644
--- a/drivers/scsi/aic94xx/aic94xx_dev.c
+++ b/drivers/scsi/aic94xx/aic94xx_dev.c
@@ -37,18 +37,14 @@
 
 static inline int asd_get_ddb(struct asd_ha_struct *asd_ha)
 {
-        unsigned long flags;
         int ddb, i;
 
-        spin_lock_irqsave(&asd_ha->hw_prof.ddb_lock, flags);
         ddb = FIND_FREE_DDB(asd_ha);
         if (ddb >= asd_ha->hw_prof.max_ddbs) {
                 ddb = -ENOMEM;
-                spin_unlock_irqrestore(&asd_ha->hw_prof.ddb_lock, flags);
                 goto out;
         }
         SET_DDB(ddb, asd_ha);
-        spin_unlock_irqrestore(&asd_ha->hw_prof.ddb_lock, flags);
 
         for (i = 0; i < sizeof(struct asd_ddb_ssp_smp_target_port); i+= 4)
                 asd_ddbsite_write_dword(asd_ha, ddb, i, 0);
@@ -77,14 +73,10 @@ out:
 
 static inline void asd_free_ddb(struct asd_ha_struct *asd_ha, int ddb)
 {
-        unsigned long flags;
-
         if (!ddb || ddb >= 0xFFFF)
                 return;
         asd_ddbsite_write_byte(asd_ha, ddb, DDB_TYPE, DDB_TYPE_UNUSED);
-        spin_lock_irqsave(&asd_ha->hw_prof.ddb_lock, flags);
         CLEAR_DDB(ddb, asd_ha);
-        spin_unlock_irqrestore(&asd_ha->hw_prof.ddb_lock, flags);
 }
 
 static inline void asd_set_ddb_type(struct domain_device *dev)
@@ -320,8 +312,11 @@ out:
 
 int asd_dev_found(struct domain_device *dev)
 {
+        unsigned long flags;
         int res = 0;
+        struct asd_ha_struct *asd_ha = dev->port->ha->lldd_ha;
 
+        spin_lock_irqsave(&asd_ha->hw_prof.ddb_lock, flags);
         switch (dev->dev_type) {
         case SATA_PM:
                 res = asd_init_sata_pm_ddb(dev);
@@ -335,14 +330,18 @@ int asd_dev_found(struct domain_device *dev)
                 else
                         res = asd_init_initiator_ddb(dev);
         }
+        spin_unlock_irqrestore(&asd_ha->hw_prof.ddb_lock, flags);
+
         return res;
 }
 
 void asd_dev_gone(struct domain_device *dev)
 {
         int ddb, sister_ddb;
+        unsigned long flags;
         struct asd_ha_struct *asd_ha = dev->port->ha->lldd_ha;
 
+        spin_lock_irqsave(&asd_ha->hw_prof.ddb_lock, flags);
         ddb = (int) (unsigned long) dev->lldd_dev;
         sister_ddb = asd_ddbsite_read_word(asd_ha, ddb, SISTER_DDB);
 
@@ -350,4 +349,5 @@ void asd_dev_gone(struct domain_device *dev)
                 asd_free_ddb(asd_ha, sister_ddb);
         asd_free_ddb(asd_ha, ddb);
         dev->lldd_dev = NULL;
+        spin_unlock_irqrestore(&asd_ha->hw_prof.ddb_lock, flags);
 }
diff --git a/drivers/scsi/aic94xx/aic94xx_dump.c b/drivers/scsi/aic94xx/aic94xx_dump.c
index e6ade5996d95..6bd8e3059d27 100644
--- a/drivers/scsi/aic94xx/aic94xx_dump.c
+++ b/drivers/scsi/aic94xx/aic94xx_dump.c
@@ -556,7 +556,7 @@ static void asd_dump_lseq_state(struct asd_ha_struct *asd_ha, int lseq)
         PRINT_LMIP_word(asd_ha, lseq, Q_TGTXFR_TAIL);
         PRINT_LMIP_byte(asd_ha, lseq, LINK_NUMBER);
         PRINT_LMIP_byte(asd_ha, lseq, SCRATCH_FLAGS);
-        PRINT_LMIP_qword(asd_ha, lseq, CONNECTION_STATE);
+        PRINT_LMIP_dword(asd_ha, lseq, CONNECTION_STATE);
         PRINT_LMIP_word(asd_ha, lseq, CONCTL);
         PRINT_LMIP_byte(asd_ha, lseq, CONSTAT);
         PRINT_LMIP_byte(asd_ha, lseq, CONNECTION_MODES);
diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
index fbc82b00a418..bc7744e35ad0 100644
--- a/drivers/scsi/aic94xx/aic94xx_init.c
+++ b/drivers/scsi/aic94xx/aic94xx_init.c
@@ -38,7 +38,7 @@
 #include "aic94xx_seq.h"
 
 /* The format is "version.release.patchlevel" */
-#define ASD_DRIVER_VERSION "1.0.2"
+#define ASD_DRIVER_VERSION "1.0.3"
 
 static int use_msi = 0;
 module_param_named(use_msi, use_msi, int, S_IRUGO);
@@ -57,6 +57,8 @@ MODULE_PARM_DESC(collector, "\n"
 char sas_addr_str[2*SAS_ADDR_SIZE + 1] = "";
 
 static struct scsi_transport_template *aic94xx_transport_template;
+static int asd_scan_finished(struct Scsi_Host *, unsigned long);
+static void asd_scan_start(struct Scsi_Host *);
 
 static struct scsi_host_template aic94xx_sht = {
         .module                 = THIS_MODULE,
@@ -66,6 +68,8 @@ static struct scsi_host_template aic94xx_sht = {
         .target_alloc           = sas_target_alloc,
         .slave_configure        = sas_slave_configure,
         .slave_destroy          = sas_slave_destroy,
+        .scan_finished          = asd_scan_finished,
+        .scan_start             = asd_scan_start,
         .change_queue_depth     = sas_change_queue_depth,
         .change_queue_type      = sas_change_queue_type,
         .bios_param             = sas_bios_param,
@@ -75,6 +79,8 @@ static struct scsi_host_template aic94xx_sht = {
         .sg_tablesize           = SG_ALL,
         .max_sectors            = SCSI_DEFAULT_MAX_SECTORS,
         .use_clustering         = ENABLE_CLUSTERING,
+        .eh_device_reset_handler        = sas_eh_device_reset_handler,
+        .eh_bus_reset_handler   = sas_eh_bus_reset_handler,
 };
 
 static int __devinit asd_map_memio(struct asd_ha_struct *asd_ha)
@@ -234,7 +240,7 @@ static int __devinit asd_common_setup(struct asd_ha_struct *asd_ha)
         }
         /* Provide some sane default values. */
         asd_ha->hw_prof.max_scbs = 512;
-        asd_ha->hw_prof.max_ddbs = 128;
+        asd_ha->hw_prof.max_ddbs = ASD_MAX_DDBS;
         asd_ha->hw_prof.num_phys = ASD_MAX_PHYS;
         /* All phys are enabled, by default. */
         asd_ha->hw_prof.enabled_phys = 0xFF;
@@ -526,6 +532,7 @@ static int asd_register_sas_ha(struct asd_ha_struct *asd_ha)
         asd_ha->sas_ha.num_phys= ASD_MAX_PHYS;
 
         asd_ha->sas_ha.lldd_queue_size = asd_ha->seq.can_queue;
+        asd_ha->sas_ha.lldd_max_execute_num = lldd_max_execute_num;
 
         return sas_register_ha(&asd_ha->sas_ha);
 }
@@ -671,21 +678,10 @@ static int __devinit asd_pci_probe(struct pci_dev *dev,
         if (err)
                 goto Err_reg_sas;
 
-        err = asd_enable_phys(asd_ha, asd_ha->hw_prof.enabled_phys);
-        if (err) {
-                asd_printk("coudln't enable phys, err:%d\n", err);
-                goto Err_en_phys;
-        }
-        ASD_DPRINTK("enabled phys\n");
-        /* give the phy enabling interrupt event time to come in (1s
-         * is empirically about all it takes) */
-        ssleep(1);
-        /* Wait for discovery to finish */
-        scsi_flush_work(asd_ha->sas_ha.core.shost);
+        scsi_scan_host(shost);
 
         return 0;
-Err_en_phys:
-        asd_unregister_sas_ha(asd_ha);
+
 Err_reg_sas:
         asd_remove_dev_attrs(asd_ha);
 Err_dev_attrs:
@@ -778,6 +774,28 @@ static void __devexit asd_pci_remove(struct pci_dev *dev)
         return;
 }
 
+static void asd_scan_start(struct Scsi_Host *shost)
+{
+        struct asd_ha_struct *asd_ha;
+        int err;
+
+        asd_ha = SHOST_TO_SAS_HA(shost)->lldd_ha;
+        err = asd_enable_phys(asd_ha, asd_ha->hw_prof.enabled_phys);
+        if (err)
+                asd_printk("Couldn't enable phys, err:%d\n", err);
+}
+
+static int asd_scan_finished(struct Scsi_Host *shost, unsigned long time)
+{
+        /* give the phy enabling interrupt event time to come in (1s
+         * is empirically about all it takes) */
+        if (time < HZ)
+                return 0;
+        /* Wait for discovery to finish */
+        scsi_flush_work(shost);
+        return 1;
+}
+
 static ssize_t asd_version_show(struct device_driver *driver, char *buf)
 {
         return snprintf(buf, PAGE_SIZE, "%s\n", ASD_DRIVER_VERSION);
@@ -885,6 +903,7 @@ static void __exit aic94xx_exit(void)
         asd_remove_driver_attrs(&aic94xx_pci_driver.driver);
         pci_unregister_driver(&aic94xx_pci_driver);
         sas_release_transport(aic94xx_transport_template);
+        asd_release_firmware();
         asd_destroy_global_caches();
         asd_printk("%s version %s unloaded\n", ASD_DRIVER_DESCRIPTION,
                    ASD_DRIVER_VERSION);
diff --git a/drivers/scsi/aic94xx/aic94xx_reg_def.h b/drivers/scsi/aic94xx/aic94xx_reg_def.h
index a11f4e6d8bd9..a43e8cdf4ee4 100644
--- a/drivers/scsi/aic94xx/aic94xx_reg_def.h
+++ b/drivers/scsi/aic94xx/aic94xx_reg_def.h
@@ -2226,9 +2226,10 @@
 #define LmSEQ_SAS_RESET_MODE(LinkNum)           (LmSCRATCH(LinkNum) + 0x0074)
 #define LmSEQ_LINK_RESET_RETRY_COUNT(LinkNum)   (LmSCRATCH(LinkNum) + 0x0075)
 #define LmSEQ_NUM_LINK_RESET_RETRIES(LinkNum)   (LmSCRATCH(LinkNum) + 0x0076)
-#define LmSEQ_OOB_INT_ENABLES(LinkNum)          (LmSCRATCH(LinkNum) + 0x007A)
+#define LmSEQ_OOB_INT_ENABLES(LinkNum)          (LmSCRATCH(LinkNum) + 0x0078)
+#define LmSEQ_NOTIFY_TIMER_DOWN_COUNT(LinkNum)  (LmSCRATCH(LinkNum) + 0x007A)
 #define LmSEQ_NOTIFY_TIMER_TIMEOUT(LinkNum)     (LmSCRATCH(LinkNum) + 0x007C)
-#define LmSEQ_NOTIFY_TIMER_DOWN_COUNT(LinkNum)  (LmSCRATCH(LinkNum) + 0x007E)
+#define LmSEQ_NOTIFY_TIMER_INITIAL_COUNT(LinkNum) (LmSCRATCH(LinkNum) + 0x007E)
 
 /* Mode dependent scratch page 1, mode 0 and mode 1 */
 #define LmSEQ_SG_LIST_PTR_ADDR0(LinkNum)        (LmSCRATCH(LinkNum) + 0x0020)
diff --git a/drivers/scsi/aic94xx/aic94xx_sas.h b/drivers/scsi/aic94xx/aic94xx_sas.h
index 9050e93bfd5e..fa7c5290257d 100644
--- a/drivers/scsi/aic94xx/aic94xx_sas.h
+++ b/drivers/scsi/aic94xx/aic94xx_sas.h
@@ -34,6 +34,7 @@
  * domain that this sequencer can maintain low-level connections for
  * us.  They are be 64 bytes.
  */
+#define ASD_MAX_DDBS    128
 
 struct asd_ddb_ssp_smp_target_port {
         u8     conn_type;         /* byte 0 */
diff --git a/drivers/scsi/aic94xx/aic94xx_scb.c b/drivers/scsi/aic94xx/aic94xx_scb.c
index 75ed6b0569d1..8f43ff772f23 100644
--- a/drivers/scsi/aic94xx/aic94xx_scb.c
+++ b/drivers/scsi/aic94xx/aic94xx_scb.c
@@ -413,40 +413,6 @@ void asd_invalidate_edb(struct asd_ascb *ascb, int edb_id)
         }
 }
 
-/* hard reset a phy later */
-static void do_phy_reset_later(struct work_struct *work)
-{
-        struct sas_phy *sas_phy =
-                container_of(work, struct sas_phy, reset_work);
-        int error;
-
-        ASD_DPRINTK("%s: About to hard reset phy %d\n", __FUNCTION__,
-                    sas_phy->identify.phy_identifier);
-        /* Reset device port */
-        error = sas_phy_reset(sas_phy, 1);
-        if (error)
-                ASD_DPRINTK("%s: Hard reset of phy %d failed (%d).\n",
-                            __FUNCTION__, sas_phy->identify.phy_identifier, error);
-}
-
-static void phy_reset_later(struct sas_phy *sas_phy, struct Scsi_Host *shost)
-{
-        INIT_WORK(&sas_phy->reset_work, do_phy_reset_later);
-        queue_work(shost->work_q, &sas_phy->reset_work);
-}
-
-/* start up the ABORT TASK tmf... */
-static void task_kill_later(struct asd_ascb *ascb)
-{
-        struct asd_ha_struct *asd_ha = ascb->ha;
-        struct sas_ha_struct *sas_ha = &asd_ha->sas_ha;
-        struct Scsi_Host *shost = sas_ha->core.shost;
-        struct sas_task *task = ascb->uldd_task;
-
-        INIT_WORK(&task->abort_work, sas_task_abort);
-        queue_work(shost->work_q, &task->abort_work);
-}
-
 static void escb_tasklet_complete(struct asd_ascb *ascb,
                                   struct done_list_struct *dl)
 {
@@ -479,26 +445,55 @@ static void escb_tasklet_complete(struct asd_ascb *ascb,
         case REQ_TASK_ABORT: {
                 struct asd_ascb *a, *b;
                 u16 tc_abort;
+                struct domain_device *failed_dev = NULL;
+
+                ASD_DPRINTK("%s: REQ_TASK_ABORT, reason=0x%X\n",
+                            __FUNCTION__, dl->status_block[3]);
 
+                /*
+                 * Find the task that caused the abort and abort it first.
+                 * The sequencer won't put anything on the done list until
+                 * that happens.
+                 */
                 tc_abort = *((u16*)(&dl->status_block[1]));
                 tc_abort = le16_to_cpu(tc_abort);
 
-                ASD_DPRINTK("%s: REQ_TASK_ABORT, reason=0x%X\n",
-                            __FUNCTION__, dl->status_block[3]);
+                list_for_each_entry_safe(a, b, &asd_ha->seq.pend_q, list) {
+                        struct sas_task *task = ascb->uldd_task;
 
-                /* Find the pending task and abort it. */
-                list_for_each_entry_safe(a, b, &asd_ha->seq.pend_q, list)
-                        if (a->tc_index == tc_abort) {
-                                task_kill_later(a);
+                        if (task && a->tc_index == tc_abort) {
+                                failed_dev = task->dev;
+                                sas_task_abort(task);
                                 break;
                         }
+                }
+
+                if (!failed_dev) {
+                        ASD_DPRINTK("%s: Can't find task (tc=%d) to abort!\n",
+                                    __FUNCTION__, tc_abort);
+                        goto out;
+                }
+
+                /*
+                 * Now abort everything else for that device (hba?) so
+                 * that the EH will wake up and do something.
+                 */
+                list_for_each_entry_safe(a, b, &asd_ha->seq.pend_q, list) {
+                        struct sas_task *task = ascb->uldd_task;
+
+                        if (task &&
+                            task->dev == failed_dev &&
+                            a->tc_index != tc_abort)
+                                sas_task_abort(task);
+                }
+
                 goto out;
         }
         case REQ_DEVICE_RESET: {
-                struct Scsi_Host *shost = sas_ha->core.shost;
-                struct sas_phy *dev_phy;
                 struct asd_ascb *a;
                 u16 conn_handle;
+                unsigned long flags;
+                struct sas_task *last_dev_task = NULL;
 
                 conn_handle = *((u16*)(&dl->status_block[1]));
                 conn_handle = le16_to_cpu(conn_handle);
@@ -506,32 +501,47 @@ static void escb_tasklet_complete(struct asd_ascb *ascb,
                 ASD_DPRINTK("%s: REQ_DEVICE_RESET, reason=0x%X\n", __FUNCTION__,
                             dl->status_block[3]);
 
-                /* Kill all pending tasks and reset the device */
-                dev_phy = NULL;
+                /* Find the last pending task for the device... */
                 list_for_each_entry(a, &asd_ha->seq.pend_q, list) {
-                        struct sas_task *task;
-                        struct domain_device *dev;
                         u16 x;
+                        struct domain_device *dev;
+                        struct sas_task *task = a->uldd_task;
 
-                        task = a->uldd_task;
                         if (!task)
                                 continue;
                         dev = task->dev;
 
                         x = (unsigned long)dev->lldd_dev;
-                        if (x == conn_handle) {
-                                dev_phy = dev->port->phy;
-                                task_kill_later(a);
-                        }
+                        if (x == conn_handle)
+                                last_dev_task = task;
                 }
 
-                /* Reset device port */
-                if (!dev_phy) {
-                        ASD_DPRINTK("%s: No pending commands; can't reset.\n",
-                                    __FUNCTION__);
+                if (!last_dev_task) {
+                        ASD_DPRINTK("%s: Device reset for idle device %d?\n",
+                                    __FUNCTION__, conn_handle);
                         goto out;
                 }
-                phy_reset_later(dev_phy, shost);
+
+                /* ...and set the reset flag */
+                spin_lock_irqsave(&last_dev_task->task_state_lock, flags);
+                last_dev_task->task_state_flags |= SAS_TASK_NEED_DEV_RESET;
+                spin_unlock_irqrestore(&last_dev_task->task_state_lock, flags);
+
+                /* Kill all pending tasks for the device */
+                list_for_each_entry(a, &asd_ha->seq.pend_q, list) {
+                        u16 x;
+                        struct domain_device *dev;
+                        struct sas_task *task = a->uldd_task;
+
+                        if (!task)
+                                continue;
+                        dev = task->dev;
+
+                        x = (unsigned long)dev->lldd_dev;
+                        if (x == conn_handle)
+                                sas_task_abort(task);
+                }
+
                 goto out;
         }
         case SIGNAL_NCQ_ERROR:
diff --git a/drivers/scsi/aic94xx/aic94xx_sds.c b/drivers/scsi/aic94xx/aic94xx_sds.c
index e5a0ec37e954..5b0932f61473 100644
--- a/drivers/scsi/aic94xx/aic94xx_sds.c
+++ b/drivers/scsi/aic94xx/aic94xx_sds.c
@@ -427,7 +427,7 @@ struct asd_manuf_sec {
 
 struct asd_manuf_phy_desc {
         u8    state;         /* low 4 bits */
-#define MS_PHY_STATE_ENABLEABLE 0
+#define MS_PHY_STATE_ENABLED    0
 #define MS_PHY_STATE_REPORTED   1
 #define MS_PHY_STATE_HIDDEN     2
         u8    phy_id;
@@ -756,11 +756,11 @@ static void *asd_find_ll_by_id(void * const start, const u8 id0, const u8 id1)
  *
  * HIDDEN phys do not count in the total count.  REPORTED phys cannot
  * be enabled but are reported and counted towards the total.
- * ENEBLEABLE phys are enabled by default and count towards the total.
+ * ENABLED phys are enabled by default and count towards the total.
  * The absolute total phy number is ASD_MAX_PHYS.  hw_prof->num_phys
  * merely specifies the number of phys the host adapter decided to
  * report.  E.g., it is possible for phys 0, 1 and 2 to be HIDDEN,
- * phys 3, 4 and 5 to be REPORTED and phys 6 and 7 to be ENEBLEABLE.
+ * phys 3, 4 and 5 to be REPORTED and phys 6 and 7 to be ENABLED.
  * In this case ASD_MAX_PHYS is 8, hw_prof->num_phys is 5, and only 2
  * are actually enabled (enabled by default, max number of phys
  * enableable in this case).
@@ -816,8 +816,8 @@ static int asd_ms_get_phy_params(struct asd_ha_struct *asd_ha,
                         asd_ha->hw_prof.enabled_phys &= ~(1 << i);
                         rep_phys++;
                         continue;
-                case MS_PHY_STATE_ENABLEABLE:
-                        ASD_DPRINTK("ms: phy%d: ENEBLEABLE\n", i);
+                case MS_PHY_STATE_ENABLED:
+                        ASD_DPRINTK("ms: phy%d: ENABLED\n", i);
                         asd_ha->hw_prof.enabled_phys |= (1 << i);
                         en_phys++;
                         break;
diff --git a/drivers/scsi/aic94xx/aic94xx_seq.c b/drivers/scsi/aic94xx/aic94xx_seq.c
index 845112539d05..eae7a247bece 100644
--- a/drivers/scsi/aic94xx/aic94xx_seq.c
+++ b/drivers/scsi/aic94xx/aic94xx_seq.c
@@ -810,6 +810,8 @@ static void asd_init_lseq_mdp(struct asd_ha_struct *asd_ha,  int lseq)
         /* No delay for the first NOTIFY to be sent to the attached target. */
         asd_write_reg_word(asd_ha, LmSEQ_NOTIFY_TIMER_DOWN_COUNT(lseq),
                            ASD_NOTIFY_DOWN_COUNT);
+        asd_write_reg_word(asd_ha, LmSEQ_NOTIFY_TIMER_INITIAL_COUNT(lseq),
+                           ASD_NOTIFY_DOWN_COUNT);
 
         /* LSEQ Mode dependent, mode 0 and 1, page 1 setup. */
         for (i = 0; i < 2; i++) {
@@ -907,6 +909,16 @@ static void asd_init_scb_sites(struct asd_ha_struct *asd_ha)
                 for (i = 0; i < ASD_SCB_SIZE; i += 4)
                         asd_scbsite_write_dword(asd_ha, site_no, i, 0);
 
+                /* Initialize SCB Site Opcode field to invalid. */
+                asd_scbsite_write_byte(asd_ha, site_no,
+                                       offsetof(struct scb_header, opcode),
+                                       0xFF);
+
+                /* Initialize SCB Site Flags field to mean a response
+                 * frame has been received.  This means inadvertent
+                 * frames received to be dropped. */
+                asd_scbsite_write_byte(asd_ha, site_no, 0x49, 0x01);
+
                 /* Workaround needed by SEQ to fix a SATA issue is to exclude
                  * certain SCB sites from the free list. */
                 if (!SCB_SITE_VALID(site_no))
@@ -922,16 +934,6 @@ static void asd_init_scb_sites(struct asd_ha_struct *asd_ha)
                 /* Q_NEXT field of the last SCB is invalidated. */
                 asd_scbsite_write_word(asd_ha, site_no, 0, first_scb_site_no);
 
-                /* Initialize SCB Site Opcode field to invalid. */
-                asd_scbsite_write_byte(asd_ha, site_no,
-                                       offsetof(struct scb_header, opcode),
-                                       0xFF);
-
-                /* Initialize SCB Site Flags field to mean a response
-                 * frame has been received.  This means inadvertent
-                 * frames received to be dropped. */
-                asd_scbsite_write_byte(asd_ha, site_no, 0x49, 0x01);
-
                 first_scb_site_no = site_no;
                 max_scbs++;
         }
@@ -1173,6 +1175,16 @@ static void asd_init_ddb_0(struct asd_ha_struct *asd_ha)
         set_bit(0, asd_ha->hw_prof.ddb_bitmap);
 }
 
+static void asd_seq_init_ddb_sites(struct asd_ha_struct *asd_ha)
+{
+        unsigned int i;
+        unsigned int ddb_site;
+
+        for (ddb_site = 0 ; ddb_site < ASD_MAX_DDBS; ddb_site++)
+                for (i = 0; i < sizeof(struct asd_ddb_ssp_smp_target_port); i+= 4)
+                        asd_ddbsite_write_dword(asd_ha, ddb_site, i, 0);
+}
+
 /**
  * asd_seq_setup_seqs -- setup and initialize central and link sequencers
  * @asd_ha: pointer to host adapter structure
@@ -1182,6 +1194,9 @@ static void asd_seq_setup_seqs(struct asd_ha_struct *asd_ha)
         int             lseq;
         u8              lseq_mask;
 
+        /* Initialize DDB sites */
+        asd_seq_init_ddb_sites(asd_ha);
+
         /* Initialize SCB sites. Done first to compute some values which
          * the rest of the init code depends on. */
         asd_init_scb_sites(asd_ha);
@@ -1232,6 +1247,13 @@ static int asd_seq_start_lseq(struct asd_ha_struct *asd_ha, int lseq)
         return asd_seq_unpause_lseq(asd_ha, lseq);
 }
 
+int asd_release_firmware(void)
+{
+        if (sequencer_fw)
+                release_firmware(sequencer_fw);
+        return 0;
+}
+
 static int asd_request_firmware(struct asd_ha_struct *asd_ha)
 {
         int err, i;
@@ -1375,7 +1397,9 @@ void asd_update_port_links(struct asd_ha_struct *asd_ha, struct asd_phy *phy)
         u8  phy_is_up;
         u8  mask;
         int i, err;
+        unsigned long flags;
 
+        spin_lock_irqsave(&asd_ha->hw_prof.ddb_lock, flags);
         for_each_phy(phy_mask, mask, i)
                 asd_ddbsite_write_byte(asd_ha, 0,
                                        offsetof(struct asd_ddb_seq_shared,
@@ -1395,6 +1419,7 @@ void asd_update_port_links(struct asd_ha_struct *asd_ha, struct asd_phy *phy)
                         break;
                 }
         }
+        spin_unlock_irqrestore(&asd_ha->hw_prof.ddb_lock, flags);
 
         if (err)
                 asd_printk("couldn't update DDB 0:error:%d\n", err);
diff --git a/drivers/scsi/aic94xx/aic94xx_seq.h b/drivers/scsi/aic94xx/aic94xx_seq.h
index 9e715e5496af..9437ff0ae3a4 100644
--- a/drivers/scsi/aic94xx/aic94xx_seq.h
+++ b/drivers/scsi/aic94xx/aic94xx_seq.h
@@ -63,6 +63,7 @@ int asd_pause_lseq(struct asd_ha_struct *asd_ha, u8 lseq_mask);
 int asd_unpause_lseq(struct asd_ha_struct *asd_ha, u8 lseq_mask);
 int asd_init_seqs(struct asd_ha_struct *asd_ha);
 int asd_start_seqs(struct asd_ha_struct *asd_ha);
+int asd_release_firmware(void);
 
 void asd_update_port_links(struct asd_ha_struct *asd_ha, struct asd_phy *phy);
 #endif
diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
index d202ed5a6709..e2ad5bed9403 100644
--- a/drivers/scsi/aic94xx/aic94xx_task.c
+++ b/drivers/scsi/aic94xx/aic94xx_task.c
@@ -349,6 +349,7 @@ Again:
 
         spin_lock_irqsave(&task->task_state_lock, flags);
         task->task_state_flags &= ~SAS_TASK_STATE_PENDING;
+        task->task_state_flags &= ~SAS_TASK_AT_INITIATOR;
         task->task_state_flags |= SAS_TASK_STATE_DONE;
         if (unlikely((task->task_state_flags & SAS_TASK_STATE_ABORTED))) {
                 spin_unlock_irqrestore(&task->task_state_lock, flags);
@@ -557,6 +558,7 @@ int asd_execute_task(struct sas_task *task, const int num,
         struct sas_task *t = task;
         struct asd_ascb *ascb = NULL, *a;
         struct asd_ha_struct *asd_ha = task->dev->port->ha->lldd_ha;
+        unsigned long flags;
 
         res = asd_can_queue(asd_ha, num);
         if (res)
@@ -599,6 +601,10 @@ int asd_execute_task(struct sas_task *task, const int num,
                 }
                 if (res)
                         goto out_err_unmap;
+
+                spin_lock_irqsave(&t->task_state_lock, flags);
+                t->task_state_flags |= SAS_TASK_AT_INITIATOR;
+                spin_unlock_irqrestore(&t->task_state_lock, flags);
         }
         list_del_init(&alist);
 
@@ -617,6 +623,9 @@ out_err_unmap:
                         if (a == b)
                                 break;
                         t = a->uldd_task;
+                        spin_lock_irqsave(&t->task_state_lock, flags);
+                        t->task_state_flags &= ~SAS_TASK_AT_INITIATOR;
+                        spin_unlock_irqrestore(&t->task_state_lock, flags);
                         switch (t->task_proto) {
                         case SATA_PROTO:
                         case SAS_PROTO_STP:
diff --git a/drivers/scsi/aic94xx/aic94xx_tmf.c b/drivers/scsi/aic94xx/aic94xx_tmf.c
index 61234384503b..9a14a6d97275 100644
--- a/drivers/scsi/aic94xx/aic94xx_tmf.c
+++ b/drivers/scsi/aic94xx/aic94xx_tmf.c
@@ -566,9 +566,7 @@ static int asd_initiate_ssp_tmf(struct domain_device *dev, u8 *lun,
                 res = TMF_RESP_FUNC_ESUPP;
                 break;
         default:
-                ASD_DPRINTK("%s: converting result 0x%x to TMF_RESP_FUNC_FAILED\n",
-                            __FUNCTION__, res);
-                res = TMF_RESP_FUNC_FAILED;
+                /* Allow TMF response codes to propagate upwards */
                 break;
         }
 out_err: