diff options
author | Jeff Garzik <jgarzik@pobox.com> | 2005-10-24 18:04:36 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.(none)> | 2005-10-28 22:04:15 -0400 |
commit | 017560fca496f72ed9dd734ffde63ce39dfe0411 (patch) | |
tree | e63ae9a28fc179e715eda32f12aaec4ca752651b /drivers/scsi/aic7xxx | |
parent | 3bf743e7c891d8be8295650b7a6a9b5af083b096 (diff) |
[SCSI] use sfoo_printk() in drivers
Rejections fixed up and
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/aic7xxx')
-rw-r--r-- | drivers/scsi/aic7xxx/aic79xx_osm.c | 28 | ||||
-rw-r--r-- | drivers/scsi/aic7xxx/aic7xxx_osm.c | 22 |
2 files changed, 15 insertions, 35 deletions
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c index 95c285cc83e4..5e023dca4e52 100644 --- a/drivers/scsi/aic7xxx/aic79xx_osm.c +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c | |||
@@ -52,6 +52,7 @@ static struct scsi_transport_template *ahd_linux_transport_template = NULL; | |||
52 | #include <linux/mm.h> /* For fetching system memory size */ | 52 | #include <linux/mm.h> /* For fetching system memory size */ |
53 | #include <linux/blkdev.h> /* For block_size() */ | 53 | #include <linux/blkdev.h> /* For block_size() */ |
54 | #include <linux/delay.h> /* For ssleep/msleep */ | 54 | #include <linux/delay.h> /* For ssleep/msleep */ |
55 | #include <linux/device.h> | ||
55 | 56 | ||
56 | /* | 57 | /* |
57 | * Bucket size for counting good commands in between bad ones. | 58 | * Bucket size for counting good commands in between bad ones. |
@@ -565,7 +566,7 @@ ahd_linux_slave_configure(struct scsi_device *sdev) | |||
565 | 566 | ||
566 | ahd = *((struct ahd_softc **)sdev->host->hostdata); | 567 | ahd = *((struct ahd_softc **)sdev->host->hostdata); |
567 | if (bootverbose) | 568 | if (bootverbose) |
568 | printf("%s: Slave Configure %d\n", ahd_name(ahd), sdev->id); | 569 | sdev_printk(KERN_INFO, sdev, "Slave Configure\n"); |
569 | 570 | ||
570 | ahd_linux_device_queue_depth(sdev); | 571 | ahd_linux_device_queue_depth(sdev); |
571 | 572 | ||
@@ -2067,9 +2068,8 @@ ahd_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2067 | wait = FALSE; | 2068 | wait = FALSE; |
2068 | ahd = *(struct ahd_softc **)cmd->device->host->hostdata; | 2069 | ahd = *(struct ahd_softc **)cmd->device->host->hostdata; |
2069 | 2070 | ||
2070 | printf("%s:%d:%d:%d: Attempting to queue a%s message:", | 2071 | scmd_printk(KERN_INFO, cmd, |
2071 | ahd_name(ahd), cmd->device->channel, | 2072 | "Attempting to queue a%s message:", |
2072 | cmd->device->id, cmd->device->lun, | ||
2073 | flag == SCB_ABORT ? "n ABORT" : " TARGET RESET"); | 2073 | flag == SCB_ABORT ? "n ABORT" : " TARGET RESET"); |
2074 | 2074 | ||
2075 | printf("CDB:"); | 2075 | printf("CDB:"); |
@@ -2093,9 +2093,7 @@ ahd_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2093 | * No target device for this command exists, | 2093 | * No target device for this command exists, |
2094 | * so we must not still own the command. | 2094 | * so we must not still own the command. |
2095 | */ | 2095 | */ |
2096 | printf("%s:%d:%d:%d: Is not an active device\n", | 2096 | scmd_printk(KERN_INFO, cmd, "Is not an active device\n"); |
2097 | ahd_name(ahd), cmd->device->channel, cmd->device->id, | ||
2098 | cmd->device->lun); | ||
2099 | retval = SUCCESS; | 2097 | retval = SUCCESS; |
2100 | goto no_cmd; | 2098 | goto no_cmd; |
2101 | } | 2099 | } |
@@ -2121,9 +2119,7 @@ ahd_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2121 | } | 2119 | } |
2122 | 2120 | ||
2123 | if (pending_scb == NULL) { | 2121 | if (pending_scb == NULL) { |
2124 | printf("%s:%d:%d:%d: Command not found\n", | 2122 | scmd_printk(KERN_INFO, cmd, "Command not found\n"); |
2125 | ahd_name(ahd), cmd->device->channel, cmd->device->id, | ||
2126 | cmd->device->lun); | ||
2127 | goto no_cmd; | 2123 | goto no_cmd; |
2128 | } | 2124 | } |
2129 | 2125 | ||
@@ -2146,9 +2142,7 @@ ahd_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2146 | paused = TRUE; | 2142 | paused = TRUE; |
2147 | 2143 | ||
2148 | if ((pending_scb->flags & SCB_ACTIVE) == 0) { | 2144 | if ((pending_scb->flags & SCB_ACTIVE) == 0) { |
2149 | printf("%s:%d:%d:%d: Command already completed\n", | 2145 | scmd_printk(KERN_INFO, cmd, "Command already completed\n"); |
2150 | ahd_name(ahd), cmd->device->channel, cmd->device->id, | ||
2151 | cmd->device->lun); | ||
2152 | goto no_cmd; | 2146 | goto no_cmd; |
2153 | } | 2147 | } |
2154 | 2148 | ||
@@ -2214,9 +2208,7 @@ ahd_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2214 | pending_scb->flags |= SCB_RECOVERY_SCB|flag; | 2208 | pending_scb->flags |= SCB_RECOVERY_SCB|flag; |
2215 | ahd_outb(ahd, MSG_OUT, HOST_MSG); | 2209 | ahd_outb(ahd, MSG_OUT, HOST_MSG); |
2216 | ahd_outb(ahd, SCSISIGO, last_phase|ATNO); | 2210 | ahd_outb(ahd, SCSISIGO, last_phase|ATNO); |
2217 | printf("%s:%d:%d:%d: Device is active, asserting ATN\n", | 2211 | scmd_printk(KERN_INFO, cmd, "Device is active, asserting ATN\n"); |
2218 | ahd_name(ahd), cmd->device->channel, | ||
2219 | cmd->device->id, cmd->device->lun); | ||
2220 | wait = TRUE; | 2212 | wait = TRUE; |
2221 | } else if (disconnected) { | 2213 | } else if (disconnected) { |
2222 | 2214 | ||
@@ -2277,9 +2269,7 @@ ahd_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2277 | printf("Device is disconnected, re-queuing SCB\n"); | 2269 | printf("Device is disconnected, re-queuing SCB\n"); |
2278 | wait = TRUE; | 2270 | wait = TRUE; |
2279 | } else { | 2271 | } else { |
2280 | printf("%s:%d:%d:%d: Unable to deliver message\n", | 2272 | scmd_printk(KERN_INFO, cmd, "Unable to deliver message\n"); |
2281 | ahd_name(ahd), cmd->device->channel, | ||
2282 | cmd->device->id, cmd->device->lun); | ||
2283 | retval = FAILED; | 2273 | retval = FAILED; |
2284 | goto done; | 2274 | goto done; |
2285 | } | 2275 | } |
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index 6ee1435d37fa..7074ab95d1cc 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c | |||
@@ -641,7 +641,7 @@ ahc_linux_slave_configure(struct scsi_device *sdev) | |||
641 | ahc = *((struct ahc_softc **)sdev->host->hostdata); | 641 | ahc = *((struct ahc_softc **)sdev->host->hostdata); |
642 | 642 | ||
643 | if (bootverbose) | 643 | if (bootverbose) |
644 | printf("%s: Slave Configure %d\n", ahc_name(ahc), sdev->id); | 644 | sdev_printk(KERN_INFO, sdev, "Slave Configure\n"); |
645 | 645 | ||
646 | ahc_linux_device_queue_depth(sdev); | 646 | ahc_linux_device_queue_depth(sdev); |
647 | 647 | ||
@@ -2117,9 +2117,7 @@ ahc_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2117 | wait = FALSE; | 2117 | wait = FALSE; |
2118 | ahc = *(struct ahc_softc **)cmd->device->host->hostdata; | 2118 | ahc = *(struct ahc_softc **)cmd->device->host->hostdata; |
2119 | 2119 | ||
2120 | printf("%s:%d:%d:%d: Attempting to queue a%s message\n", | 2120 | scmd_printk(KERN_INFO, cmd, "Attempting to queue a%s message\n", |
2121 | ahc_name(ahc), cmd->device->channel, | ||
2122 | cmd->device->id, cmd->device->lun, | ||
2123 | flag == SCB_ABORT ? "n ABORT" : " TARGET RESET"); | 2121 | flag == SCB_ABORT ? "n ABORT" : " TARGET RESET"); |
2124 | 2122 | ||
2125 | printf("CDB:"); | 2123 | printf("CDB:"); |
@@ -2183,9 +2181,7 @@ ahc_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2183 | } | 2181 | } |
2184 | 2182 | ||
2185 | if (pending_scb == NULL) { | 2183 | if (pending_scb == NULL) { |
2186 | printf("%s:%d:%d:%d: Command not found\n", | 2184 | scmd_printk(KERN_INFO, cmd, "Command not found\n"); |
2187 | ahc_name(ahc), cmd->device->channel, cmd->device->id, | ||
2188 | cmd->device->lun); | ||
2189 | goto no_cmd; | 2185 | goto no_cmd; |
2190 | } | 2186 | } |
2191 | 2187 | ||
@@ -2207,9 +2203,7 @@ ahc_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2207 | paused = TRUE; | 2203 | paused = TRUE; |
2208 | 2204 | ||
2209 | if ((pending_scb->flags & SCB_ACTIVE) == 0) { | 2205 | if ((pending_scb->flags & SCB_ACTIVE) == 0) { |
2210 | printf("%s:%d:%d:%d: Command already completed\n", | 2206 | scmd_printk(KERN_INFO, cmd, "Command already completed\n"); |
2211 | ahc_name(ahc), cmd->device->channel, cmd->device->id, | ||
2212 | cmd->device->lun); | ||
2213 | goto no_cmd; | 2207 | goto no_cmd; |
2214 | } | 2208 | } |
2215 | 2209 | ||
@@ -2276,9 +2270,7 @@ ahc_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2276 | pending_scb->flags |= SCB_RECOVERY_SCB|flag; | 2270 | pending_scb->flags |= SCB_RECOVERY_SCB|flag; |
2277 | ahc_outb(ahc, MSG_OUT, HOST_MSG); | 2271 | ahc_outb(ahc, MSG_OUT, HOST_MSG); |
2278 | ahc_outb(ahc, SCSISIGO, last_phase|ATNO); | 2272 | ahc_outb(ahc, SCSISIGO, last_phase|ATNO); |
2279 | printf("%s:%d:%d:%d: Device is active, asserting ATN\n", | 2273 | scmd_printk(KERN_INFO, cmd, "Device is active, asserting ATN\n"); |
2280 | ahc_name(ahc), cmd->device->channel, cmd->device->id, | ||
2281 | cmd->device->lun); | ||
2282 | wait = TRUE; | 2274 | wait = TRUE; |
2283 | } else if (disconnected) { | 2275 | } else if (disconnected) { |
2284 | 2276 | ||
@@ -2344,9 +2336,7 @@ ahc_linux_queue_recovery_cmd(struct scsi_cmnd *cmd, scb_flag flag) | |||
2344 | printf("Device is disconnected, re-queuing SCB\n"); | 2336 | printf("Device is disconnected, re-queuing SCB\n"); |
2345 | wait = TRUE; | 2337 | wait = TRUE; |
2346 | } else { | 2338 | } else { |
2347 | printf("%s:%d:%d:%d: Unable to deliver message\n", | 2339 | scmd_printk(KERN_INFO, cmd, "Unable to deliver message\n"); |
2348 | ahc_name(ahc), cmd->device->channel, cmd->device->id, | ||
2349 | cmd->device->lun); | ||
2350 | retval = FAILED; | 2340 | retval = FAILED; |
2351 | goto done; | 2341 | goto done; |
2352 | } | 2342 | } |