diff options
author | James Bottomley <James.Bottomley@steeleye.com> | 2005-10-02 16:22:35 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.(none)> | 2005-10-02 16:32:25 -0400 |
commit | 97af50f60ff1202b0dd9ce481d4cf98c6a578bec (patch) | |
tree | 5637b5d7d505869ee5aace5ad6ed33085fc78697 /drivers/scsi/aic7xxx/aic79xx_osm.c | |
parent | 9e70592fcd87c90e9e98090d66cb79f39d740d4a (diff) |
[SCSI] aic7xxx/aic79xx: fix module removal path not to panic
In these drivers, scsi_remove_host() is called too late, at the point
it is called, the driver has already shut down too far to accept any
I/O that the shutdown might generate. Any generated I/O actually
triggers a panic.
Fix this by calling scsi_remove_host() as early as possible and not
calling scsi_host_put() until just before we kfree the ahc_softc.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/aic7xxx/aic79xx_osm.c')
-rw-r--r-- | drivers/scsi/aic7xxx/aic79xx_osm.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c index 6b6d4e287793..95c285cc83e4 100644 --- a/drivers/scsi/aic7xxx/aic79xx_osm.c +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c | |||
@@ -1192,11 +1192,6 @@ ahd_platform_free(struct ahd_softc *ahd) | |||
1192 | int i, j; | 1192 | int i, j; |
1193 | 1193 | ||
1194 | if (ahd->platform_data != NULL) { | 1194 | if (ahd->platform_data != NULL) { |
1195 | if (ahd->platform_data->host != NULL) { | ||
1196 | scsi_remove_host(ahd->platform_data->host); | ||
1197 | scsi_host_put(ahd->platform_data->host); | ||
1198 | } | ||
1199 | |||
1200 | /* destroy all of the device and target objects */ | 1195 | /* destroy all of the device and target objects */ |
1201 | for (i = 0; i < AHD_NUM_TARGETS; i++) { | 1196 | for (i = 0; i < AHD_NUM_TARGETS; i++) { |
1202 | starget = ahd->platform_data->starget[i]; | 1197 | starget = ahd->platform_data->starget[i]; |
@@ -1226,6 +1221,9 @@ ahd_platform_free(struct ahd_softc *ahd) | |||
1226 | release_mem_region(ahd->platform_data->mem_busaddr, | 1221 | release_mem_region(ahd->platform_data->mem_busaddr, |
1227 | 0x1000); | 1222 | 0x1000); |
1228 | } | 1223 | } |
1224 | if (ahd->platform_data->host) | ||
1225 | scsi_host_put(ahd->platform_data->host); | ||
1226 | |||
1229 | free(ahd->platform_data, M_DEVBUF); | 1227 | free(ahd->platform_data, M_DEVBUF); |
1230 | } | 1228 | } |
1231 | } | 1229 | } |