aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/aacraid/linit.c
diff options
context:
space:
mode:
authorSalyzyn, Mark <mark_salyzyn@adaptec.com>2007-03-21 13:49:47 -0400
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>2007-03-21 14:03:52 -0400
commit802ae2f05b646c1e5f9e33cfe4c80cfa1452a0e3 (patch)
tree46bc8f6d789538abf7a5feed0a40e318a652e7d5 /drivers/scsi/aacraid/linit.c
parent20235f35221472f1a127a5d5414f11091eb0a845 (diff)
[SCSI] aacraid: cleanup and version stamp driver
There is some residual cleanup of the last series of patches and the need to bump the revision number to draw the line in the sand. The cmd->SCp.phase is set in the aac_valid_context routine, then set again to the same value following it's return. The cmd->scsi_done is set twice in the aac_queuecommand routine. Free up the scsidev FILO in aac_probe_container as it is not needed further down the function in any case. Improve the efficiency of the abort handler kernel print parameters. Bump revision number of driver to approximate the equivalent in the Adaptec supplied version. Signed-off-by: Mark Salyzyn <aacraid@adaptec.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/aacraid/linit.c')
-rw-r--r--drivers/scsi/aacraid/linit.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 3cf3f6472e94..a5950c17d62b 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -260,7 +260,6 @@ static int aac_queuecommand(struct scsi_cmnd *cmd, void (*done)(struct scsi_cmnd
260 (cmd->SCp.phase == AAC_OWNER_FIRMWARE)) 260 (cmd->SCp.phase == AAC_OWNER_FIRMWARE))
261 return 0; /* Already owned by Adapter */ 261 return 0; /* Already owned by Adapter */
262 } 262 }
263 cmd->scsi_done = done;
264 cmd->SCp.phase = AAC_OWNER_LOWLEVEL; 263 cmd->SCp.phase = AAC_OWNER_LOWLEVEL;
265 return (aac_scsi_cmd(cmd) ? FAILED : 0); 264 return (aac_scsi_cmd(cmd) ? FAILED : 0);
266} 265}
@@ -461,15 +460,15 @@ static int aac_ioctl(struct scsi_device *sdev, int cmd, void __user * arg)
461 460
462static int aac_eh_abort(struct scsi_cmnd* cmd) 461static int aac_eh_abort(struct scsi_cmnd* cmd)
463{ 462{
464 struct Scsi_Host * host = cmd->device->host; 463 struct scsi_device * dev = cmd->device;
464 struct Scsi_Host * host = dev->host;
465 struct aac_dev * aac = (struct aac_dev *)host->hostdata; 465 struct aac_dev * aac = (struct aac_dev *)host->hostdata;
466 int count; 466 int count;
467 int ret = FAILED; 467 int ret = FAILED;
468 468
469 printk(KERN_ERR "%s: Host adapter abort request (%d,%d,%d,%d)\n", 469 printk(KERN_ERR "%s: Host adapter abort request (%d,%d,%d,%d)\n",
470 AAC_DRIVERNAME, 470 AAC_DRIVERNAME,
471 cmd->device->host->host_no, sdev_channel(cmd->device), 471 host->host_no, sdev_channel(dev), sdev_id(dev), dev->lun);
472 sdev_id(cmd->device), cmd->device->lun);
473 switch (cmd->cmnd[0]) { 472 switch (cmd->cmnd[0]) {
474 case SERVICE_ACTION_IN: 473 case SERVICE_ACTION_IN:
475 if (!(aac->raw_io_interface) || 474 if (!(aac->raw_io_interface) ||