diff options
author | Christof Schmitt <christof.schmitt@de.ibm.com> | 2009-05-15 07:18:18 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-05-23 16:44:15 -0400 |
commit | dceab655d9f7d99881c2033c8ff4e1c7b444e104 (patch) | |
tree | 21249a1815a7005a66bc8dc4edbf9003bac7b8b0 /drivers/s390 | |
parent | bc90c8632f63cd94246e3fb6f1b6d7ecba48f1a0 (diff) |
[SCSI] zfcp: Add comments to switch/case fallthroughs
Add comments where there is a deliberate fall through in switch/case
statements. This makes some code checkers happy and makes it clear
that there is no missing break statement.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/s390')
-rw-r--r-- | drivers/s390/scsi/zfcp_erp.c | 1 | ||||
-rw-r--r-- | drivers/s390/scsi/zfcp_fsf.c | 5 |
2 files changed, 6 insertions, 0 deletions
diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c index fdc9b4352a64..3f64aded6caa 100644 --- a/drivers/s390/scsi/zfcp_erp.c +++ b/drivers/s390/scsi/zfcp_erp.c | |||
@@ -880,6 +880,7 @@ static int zfcp_erp_port_strategy_open_common(struct zfcp_erp_action *act) | |||
880 | zfcp_port_put(port); | 880 | zfcp_port_put(port); |
881 | return ZFCP_ERP_CONTINUES; | 881 | return ZFCP_ERP_CONTINUES; |
882 | } | 882 | } |
883 | /* fall through */ | ||
883 | case ZFCP_ERP_STEP_NAMESERVER_LOOKUP: | 884 | case ZFCP_ERP_STEP_NAMESERVER_LOOKUP: |
884 | if (!port->d_id) | 885 | if (!port->d_id) |
885 | return ZFCP_ERP_FAILED; | 886 | return ZFCP_ERP_FAILED; |
diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c index 8411730d44ba..b550c249389d 100644 --- a/drivers/s390/scsi/zfcp_fsf.c +++ b/drivers/s390/scsi/zfcp_fsf.c | |||
@@ -526,6 +526,7 @@ static int zfcp_fsf_exchange_config_evaluate(struct zfcp_fsf_req *req) | |||
526 | break; | 526 | break; |
527 | case FSF_TOPO_AL: | 527 | case FSF_TOPO_AL: |
528 | fc_host_port_type(shost) = FC_PORTTYPE_NLPORT; | 528 | fc_host_port_type(shost) = FC_PORTTYPE_NLPORT; |
529 | /* fall through */ | ||
529 | default: | 530 | default: |
530 | dev_err(&adapter->ccw_device->dev, | 531 | dev_err(&adapter->ccw_device->dev, |
531 | "Unknown or unsupported arbitrated loop " | 532 | "Unknown or unsupported arbitrated loop " |
@@ -897,6 +898,7 @@ static void zfcp_fsf_abort_fcp_command_handler(struct zfcp_fsf_req *req) | |||
897 | switch (fsq->word[0]) { | 898 | switch (fsq->word[0]) { |
898 | case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE: | 899 | case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE: |
899 | zfcp_test_link(unit->port); | 900 | zfcp_test_link(unit->port); |
901 | /* fall through */ | ||
900 | case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED: | 902 | case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED: |
901 | req->status |= ZFCP_STATUS_FSFREQ_ERROR; | 903 | req->status |= ZFCP_STATUS_FSFREQ_ERROR; |
902 | break; | 904 | break; |
@@ -993,6 +995,7 @@ static void zfcp_fsf_send_ct_handler(struct zfcp_fsf_req *req) | |||
993 | break; | 995 | break; |
994 | case FSF_PORT_HANDLE_NOT_VALID: | 996 | case FSF_PORT_HANDLE_NOT_VALID: |
995 | zfcp_erp_adapter_reopen(adapter, 0, "fsscth1", req); | 997 | zfcp_erp_adapter_reopen(adapter, 0, "fsscth1", req); |
998 | /* fall through */ | ||
996 | case FSF_GENERIC_COMMAND_REJECTED: | 999 | case FSF_GENERIC_COMMAND_REJECTED: |
997 | case FSF_PAYLOAD_SIZE_MISMATCH: | 1000 | case FSF_PAYLOAD_SIZE_MISMATCH: |
998 | case FSF_REQUEST_SIZE_TOO_LARGE: | 1001 | case FSF_REQUEST_SIZE_TOO_LARGE: |
@@ -1590,8 +1593,10 @@ static void zfcp_fsf_open_wka_port_handler(struct zfcp_fsf_req *req) | |||
1590 | case FSF_MAXIMUM_NUMBER_OF_PORTS_EXCEEDED: | 1593 | case FSF_MAXIMUM_NUMBER_OF_PORTS_EXCEEDED: |
1591 | dev_warn(&req->adapter->ccw_device->dev, | 1594 | dev_warn(&req->adapter->ccw_device->dev, |
1592 | "Opening WKA port 0x%x failed\n", wka_port->d_id); | 1595 | "Opening WKA port 0x%x failed\n", wka_port->d_id); |
1596 | /* fall through */ | ||
1593 | case FSF_ADAPTER_STATUS_AVAILABLE: | 1597 | case FSF_ADAPTER_STATUS_AVAILABLE: |
1594 | req->status |= ZFCP_STATUS_FSFREQ_ERROR; | 1598 | req->status |= ZFCP_STATUS_FSFREQ_ERROR; |
1599 | /* fall through */ | ||
1595 | case FSF_ACCESS_DENIED: | 1600 | case FSF_ACCESS_DENIED: |
1596 | wka_port->status = ZFCP_WKA_PORT_OFFLINE; | 1601 | wka_port->status = ZFCP_WKA_PORT_OFFLINE; |
1597 | break; | 1602 | break; |