aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390
diff options
context:
space:
mode:
authorUrsula Braun <ursula.braun@de.ibm.com>2012-03-06 21:06:26 -0500
committerDavid S. Miller <davem@davemloft.net>2012-03-08 01:52:25 -0500
commitce1f893837afeee8aea0c5f6a32ebba16816beec (patch)
tree029a8490f64053a4817407dd1e2c100ecaa96804 /drivers/s390
parent2022e00cd5c0a9b43163834a51af664de16cfc3c (diff)
ctcm: make ctcmpc debugging compilable
ctcmpc debugging can be activated defining constant DEBUGCCW. The debugging part contains wrong checks for 64 bit addresses. Thus the debugging version does not compile. This patch corrects the 64-bit address checks to make it compilable. Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com> Reviewed-by: Belinda Thompson <belindat@us.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390')
-rw-r--r--drivers/s390/net/ctcm_main.c3
-rw-r--r--drivers/s390/net/ctcm_mpc.c12
2 files changed, 9 insertions, 6 deletions
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index 5cb93a8e3403..11f3b071f305 100644
--- a/drivers/s390/net/ctcm_main.c
+++ b/drivers/s390/net/ctcm_main.c
@@ -562,6 +562,9 @@ static int ctcm_transmit_skb(struct channel *ch, struct sk_buff *skb)
562 skb_queue_tail(&ch->io_queue, skb); 562 skb_queue_tail(&ch->io_queue, skb);
563 ccw_idx = 3; 563 ccw_idx = 3;
564 } 564 }
565 if (do_debug_ccw)
566 ctcmpc_dumpit((char *)&ch->ccw[ccw_idx],
567 sizeof(struct ccw1) * 3);
565 ch->retry = 0; 568 ch->retry = 0;
566 fsm_newstate(ch->fsm, CTC_STATE_TX); 569 fsm_newstate(ch->fsm, CTC_STATE_TX);
567 fsm_addtimer(&ch->timer, CTCM_TIME_5_SEC, CTC_EVENT_TIMER, ch); 570 fsm_addtimer(&ch->timer, CTCM_TIME_5_SEC, CTC_EVENT_TIMER, ch);
diff --git a/drivers/s390/net/ctcm_mpc.c b/drivers/s390/net/ctcm_mpc.c
index da4c747335e7..ac7975b7a837 100644
--- a/drivers/s390/net/ctcm_mpc.c
+++ b/drivers/s390/net/ctcm_mpc.c
@@ -53,8 +53,8 @@
53#include <linux/moduleparam.h> 53#include <linux/moduleparam.h>
54#include <asm/idals.h> 54#include <asm/idals.h>
55 55
56#include "ctcm_mpc.h"
57#include "ctcm_main.h" 56#include "ctcm_main.h"
57#include "ctcm_mpc.h"
58#include "ctcm_fsms.h" 58#include "ctcm_fsms.h"
59 59
60static const struct xid2 init_xid = { 60static const struct xid2 init_xid = {
@@ -132,7 +132,7 @@ void ctcmpc_dumpit(char *buf, int len)
132 __u32 ct, sw, rm, dup; 132 __u32 ct, sw, rm, dup;
133 char *ptr, *rptr; 133 char *ptr, *rptr;
134 char tbuf[82], tdup[82]; 134 char tbuf[82], tdup[82];
135 #if (UTS_MACHINE == s390x) 135 #ifdef CONFIG_64BIT
136 char addr[22]; 136 char addr[22];
137 #else 137 #else
138 char addr[12]; 138 char addr[12];
@@ -149,8 +149,8 @@ void ctcmpc_dumpit(char *buf, int len)
149 149
150 for (ct = 0; ct < len; ct++, ptr++, rptr++) { 150 for (ct = 0; ct < len; ct++, ptr++, rptr++) {
151 if (sw == 0) { 151 if (sw == 0) {
152 #if (UTS_MACHINE == s390x) 152 #ifdef CONFIG_64BIT
153 sprintf(addr, "%16.16lx", (__u64)rptr); 153 sprintf(addr, "%16.16llx", (__u64)rptr);
154 #else 154 #else
155 sprintf(addr, "%8.8X", (__u32)rptr); 155 sprintf(addr, "%8.8X", (__u32)rptr);
156 #endif 156 #endif
@@ -164,8 +164,8 @@ void ctcmpc_dumpit(char *buf, int len)
164 if (sw == 8) 164 if (sw == 8)
165 strcat(bhex, " "); 165 strcat(bhex, " ");
166 166
167 #if (UTS_MACHINE == s390x) 167 #if CONFIG_64BIT
168 sprintf(tbuf, "%2.2lX", (__u64)*ptr); 168 sprintf(tbuf, "%2.2llX", (__u64)*ptr);
169 #else 169 #else
170 sprintf(tbuf, "%2.2X", (__u32)*ptr); 170 sprintf(tbuf, "%2.2X", (__u32)*ptr);
171 #endif 171 #endif