aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390
diff options
context:
space:
mode:
authorJan Glauber <jang@linux.vnet.ibm.com>2008-08-21 13:46:35 -0400
committerMartin Schwidefsky <schwidefsky@de.ibm.com>2008-08-21 13:46:40 -0400
commit0686e402c365c92396d4c7abfaa24810f9cb77cc (patch)
tree34737bfe43c8e747ca3b769ce9e90fbc7a785110 /drivers/s390
parent58eb27cd7f4f1de2932b3e0e39ea54a27e9fef43 (diff)
[S390] qdio: remove the module_get & module_put pair
Increasing the qdio reference count for every used subchannel is unnecessary since unloading qdio (if build as a module) is only possible if other modules that use qdio are unloaded. Unloading modules that use qdio in turn requires that these modules shut down all qdio subchannels. Therefore the additional module_get reference is not needed. Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390')
-rw-r--r--drivers/s390/cio/qdio_main.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c
index 444fc7e521d4..e6eabc853422 100644
--- a/drivers/s390/cio/qdio_main.c
+++ b/drivers/s390/cio/qdio_main.c
@@ -1251,7 +1251,6 @@ no_cleanup:
1251 1251
1252 qdio_set_state(irq_ptr, QDIO_IRQ_STATE_INACTIVE); 1252 qdio_set_state(irq_ptr, QDIO_IRQ_STATE_INACTIVE);
1253 mutex_unlock(&irq_ptr->setup_mutex); 1253 mutex_unlock(&irq_ptr->setup_mutex);
1254 module_put(THIS_MODULE);
1255 if (rc) 1254 if (rc)
1256 return rc; 1255 return rc;
1257 return 0; 1256 return 0;
@@ -1399,9 +1398,6 @@ int qdio_establish(struct qdio_initialize *init_data)
1399 if (cdev->private->state != DEV_STATE_ONLINE) 1398 if (cdev->private->state != DEV_STATE_ONLINE)
1400 return -EINVAL; 1399 return -EINVAL;
1401 1400
1402 if (!try_module_get(THIS_MODULE))
1403 return -EINVAL;
1404
1405 mutex_lock(&irq_ptr->setup_mutex); 1401 mutex_lock(&irq_ptr->setup_mutex);
1406 qdio_setup_irq(init_data); 1402 qdio_setup_irq(init_data);
1407 1403