diff options
author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-09-17 04:12:00 -0400 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2012-09-26 09:45:26 -0400 |
commit | 72abaadf25f2bc6098740622e4ed526775b197f9 (patch) | |
tree | 8735955aa7e1ae8b178aee40a93cd4b754a5bf2d /drivers/s390 | |
parent | b1d6b40cbd0d6ff475b6a0a7a807a1e3bee7c033 (diff) |
drivers/s390/char/monreader.c: fix error return code
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390')
-rw-r--r-- | drivers/s390/char/monreader.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/s390/char/monreader.c b/drivers/s390/char/monreader.c index 5b8b8592d311..f4ff515db251 100644 --- a/drivers/s390/char/monreader.c +++ b/drivers/s390/char/monreader.c | |||
@@ -571,8 +571,11 @@ static int __init mon_init(void) | |||
571 | if (rc) | 571 | if (rc) |
572 | goto out_iucv; | 572 | goto out_iucv; |
573 | monreader_device = kzalloc(sizeof(struct device), GFP_KERNEL); | 573 | monreader_device = kzalloc(sizeof(struct device), GFP_KERNEL); |
574 | if (!monreader_device) | 574 | if (!monreader_device) { |
575 | rc = -ENOMEM; | ||
575 | goto out_driver; | 576 | goto out_driver; |
577 | } | ||
578 | |||
576 | dev_set_name(monreader_device, "monreader-dev"); | 579 | dev_set_name(monreader_device, "monreader-dev"); |
577 | monreader_device->bus = &iucv_bus; | 580 | monreader_device->bus = &iucv_bus; |
578 | monreader_device->parent = iucv_root; | 581 | monreader_device->parent = iucv_root; |