[SCSI] zfcp: fix likely/unlikely usage

zfcp_fsf_protstatus_eval() takes always the 'wrong' branch.

Likely Profiling Results
 ---------------------------------------------------------
[+- ] Type | # True | # False | Function:Filename@Line
+unlikely  |   11042|        0  zfcp_fsf_protstatus_eval()

Acked-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

1 files changed, 6 insertions, 4 deletions

diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c
index ef16f7ca4bb1..4c0a59afd5c8 100644
--- a/drivers/s390/scsi/zfcp_fsf.c
+++ b/drivers/s390/scsi/zfcp_fsf.c
@@ -299,9 +299,10 @@ zfcp_fsf_protstatus_eval(struct zfcp_fsf_req *fsf_req)
         }
 
         /* log additional information provided by FSF (if any) */
-        if (unlikely(qtcb->header.log_length)) {
+        if (likely(qtcb->header.log_length)) {
                 /* do not trust them ;-) */
-                if (qtcb->header.log_start > sizeof(struct fsf_qtcb)) {
+                if (unlikely(qtcb->header.log_start >
+                             sizeof(struct fsf_qtcb))) {
                         ZFCP_LOG_NORMAL
                             ("bug: ULP (FSF logging) log data starts "
                              "beyond end of packet header. Ignored. "
@@ -310,8 +311,9 @@ zfcp_fsf_protstatus_eval(struct zfcp_fsf_req *fsf_req)
                              sizeof(struct fsf_qtcb));
                         goto forget_log;
                 }
-                if ((size_t) (qtcb->header.log_start + qtcb->header.log_length)
-                    > sizeof(struct fsf_qtcb)) {
+                if (unlikely((size_t) (qtcb->header.log_start +
+                                       qtcb->header.log_length) >
+                             sizeof(struct fsf_qtcb))) {
                         ZFCP_LOG_NORMAL("bug: ULP (FSF logging) log data ends "
                                         "beyond end of packet header. Ignored. "
                                         "(start=%i, length=%i, size=%li)\n",