aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390/scsi/zfcp_qdio.c
diff options
context:
space:
mode:
authorChristof Schmitt <christof.schmitt@de.ibm.com>2010-02-17 05:18:51 -0500
committerJames Bottomley <James.Bottomley@suse.de>2010-02-17 18:46:21 -0500
commit452b505c5ada345103bdfdb39dc550df3ffe9eea (patch)
treede88e7fb6c42de0fc9522d959abc9c82f57d0fe5 /drivers/s390/scsi/zfcp_qdio.c
parentb6bd2fb92a7bb9f1f3feecd9945c21e6c227dd51 (diff)
[SCSI] zfcp: Remove two FIXME comments
On a link down, the adapter reopen is not strictly necessary, but it helps flushing pending requests as quickly as possible. Add a comment mentioning this. qdio returning a problem on the response queue is an unlikely event. The recovery mentioned in the comment might resolve it, so implement it. This also has the advantage that it creates an entry in the recovery trace to see if and when this is occurring. Reviewed-by: Swen Schillig <swen@vnet.ibm.com> Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/s390/scsi/zfcp_qdio.c')
-rw-r--r--drivers/s390/scsi/zfcp_qdio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/s390/scsi/zfcp_qdio.c b/drivers/s390/scsi/zfcp_qdio.c
index 6c5228b627fc..3d329fa3d094 100644
--- a/drivers/s390/scsi/zfcp_qdio.c
+++ b/drivers/s390/scsi/zfcp_qdio.c
@@ -106,7 +106,7 @@ static void zfcp_qdio_resp_put_back(struct zfcp_qdio *qdio, int processed)
106 106
107 if (unlikely(retval)) { 107 if (unlikely(retval)) {
108 atomic_set(&queue->count, count); 108 atomic_set(&queue->count, count);
109 /* FIXME: Recover this with an adapter reopen? */ 109 zfcp_erp_adapter_reopen(qdio->adapter, 0, "qdrpb_1", NULL);
110 } else { 110 } else {
111 queue->first += count; 111 queue->first += count;
112 queue->first %= QDIO_MAX_BUFFERS_PER_Q; 112 queue->first %= QDIO_MAX_BUFFERS_PER_Q;