aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390/scsi/zfcp_fsf.c
diff options
context:
space:
mode:
authorChristof Schmitt <christof.schmitt@de.ibm.com>2009-03-02 07:08:57 -0500
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2009-03-12 13:58:18 -0400
commit49f0f01c9966639f8fd7ce784a412e22057d9f2a (patch)
treed6d1238eaa7467e447889639c35e5fd742ba2682 /drivers/s390/scsi/zfcp_fsf.c
parent94506fd1483b39cd5d66b8ccb4ead3c9cc9542ac (diff)
[SCSI] zfcp: Simplify latency lock handling
The lock only needs to protect the softirq context called from qdio against the userspace context called from sysfs. spin_lock and spin_lock_bh is enough. Acked-by: Swen Schillig <swen@vnet.ibm.com> Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/s390/scsi/zfcp_fsf.c')
-rw-r--r--drivers/s390/scsi/zfcp_fsf.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c
index 638cd5a2919d..cce698114b0b 100644
--- a/drivers/s390/scsi/zfcp_fsf.c
+++ b/drivers/s390/scsi/zfcp_fsf.c
@@ -2069,7 +2069,6 @@ static void zfcp_fsf_req_latency(struct zfcp_fsf_req *req)
2069 struct fsf_qual_latency_info *lat_inf; 2069 struct fsf_qual_latency_info *lat_inf;
2070 struct latency_cont *lat; 2070 struct latency_cont *lat;
2071 struct zfcp_unit *unit = req->unit; 2071 struct zfcp_unit *unit = req->unit;
2072 unsigned long flags;
2073 2072
2074 lat_inf = &req->qtcb->prefix.prot_status_qual.latency_info; 2073 lat_inf = &req->qtcb->prefix.prot_status_qual.latency_info;
2075 2074
@@ -2087,11 +2086,11 @@ static void zfcp_fsf_req_latency(struct zfcp_fsf_req *req)
2087 return; 2086 return;
2088 } 2087 }
2089 2088
2090 spin_lock_irqsave(&unit->latencies.lock, flags); 2089 spin_lock(&unit->latencies.lock);
2091 zfcp_fsf_update_lat(&lat->channel, lat_inf->channel_lat); 2090 zfcp_fsf_update_lat(&lat->channel, lat_inf->channel_lat);
2092 zfcp_fsf_update_lat(&lat->fabric, lat_inf->fabric_lat); 2091 zfcp_fsf_update_lat(&lat->fabric, lat_inf->fabric_lat);
2093 lat->counter++; 2092 lat->counter++;
2094 spin_unlock_irqrestore(&unit->latencies.lock, flags); 2093 spin_unlock(&unit->latencies.lock);
2095} 2094}
2096 2095
2097#ifdef CONFIG_BLK_DEV_IO_TRACE 2096#ifdef CONFIG_BLK_DEV_IO_TRACE