diff options
author | Christof Schmitt <christof.schmitt@de.ibm.com> | 2007-11-05 06:37:47 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-01-11 19:22:40 -0500 |
commit | 1de1b43b5f0bb536126e31f07ec833e01969ed1c (patch) | |
tree | 9908cfa46ab158be6890b2edf1c3b7362243a7f8 /drivers/s390/scsi/zfcp_def.h | |
parent | e39c8877a41e8f70225baeeb74fade8fe3a80d8b (diff) |
[SCSI] zfcp: Fix deadlock when adding invalid LUN
When adding an invalid LUN, there is a deadlock between the add
via scsi_scan_target and the slave_destroy handler: The handler
waits for the scan to complete, but for an invalid unit,
scsi_scan_target directly calls the slave_destroy handler.
Fix the deadlock by removing the wait in the slave_destroy
handler, it was not necessary anyway.
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/s390/scsi/zfcp_def.h')
-rw-r--r-- | drivers/s390/scsi/zfcp_def.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h index 3d2d2dc0d6f8..294d0792e82b 100644 --- a/drivers/s390/scsi/zfcp_def.h +++ b/drivers/s390/scsi/zfcp_def.h | |||
@@ -983,10 +983,6 @@ struct zfcp_unit { | |||
983 | struct scsi_device *device; /* scsi device struct pointer */ | 983 | struct scsi_device *device; /* scsi device struct pointer */ |
984 | struct zfcp_erp_action erp_action; /* pending error recovery */ | 984 | struct zfcp_erp_action erp_action; /* pending error recovery */ |
985 | atomic_t erp_counter; | 985 | atomic_t erp_counter; |
986 | wait_queue_head_t scsi_scan_wq; /* can be used to wait until | ||
987 | all scsi_scan_target | ||
988 | requests have been | ||
989 | completed. */ | ||
990 | }; | 986 | }; |
991 | 987 | ||
992 | /* FSF request */ | 988 | /* FSF request */ |