diff options
author | Christof Schmitt <christof.schmitt@de.ibm.com> | 2009-11-24 10:54:13 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2009-12-04 13:02:15 -0500 |
commit | 7c7dc196814b9e1d5cc254dc579a5fa78ae524f7 (patch) | |
tree | efe4800a456fa97e1f10876840fbde0983264b18 /drivers/s390/scsi/zfcp_def.h | |
parent | 800c0cad962dcf630cabf3efdc5983619e73d4c9 (diff) |
[SCSI] zfcp: Simplify handling of ct and els requests
Remove some redundancies in FC related code and trace:
- drop redundant data from SAN trace (local s_id that only changes
during link down, ls_code that is already part of payload, d_id in
ct response trace that is always the same as in ct request trace)
- use one common fsf struct to hold zfcp data for ct and els requests
- leverage common fsf struct for FC passthrough job data, allocate it
with dd_bsg_data for passthrough requests and unify common code for
ct and els passthrough request
- simplify callback handling in zfcp_fc
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/s390/scsi/zfcp_def.h')
-rw-r--r-- | drivers/s390/scsi/zfcp_def.h | 46 |
1 files changed, 0 insertions, 46 deletions
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h index ea11b4e45cdc..21b29804a7a6 100644 --- a/drivers/s390/scsi/zfcp_def.h +++ b/drivers/s390/scsi/zfcp_def.h | |||
@@ -132,52 +132,6 @@ struct zfcp_adapter_mempool { | |||
132 | mempool_t *qtcb_pool; | 132 | mempool_t *qtcb_pool; |
133 | }; | 133 | }; |
134 | 134 | ||
135 | /** | ||
136 | * struct zfcp_send_ct - used to pass parameters to function zfcp_fsf_send_ct | ||
137 | * @wka_port: port where the request is sent to | ||
138 | * @req: scatter-gather list for request | ||
139 | * @resp: scatter-gather list for response | ||
140 | * @handler: handler function (called for response to the request) | ||
141 | * @handler_data: data passed to handler function | ||
142 | * @completion: completion for synchronization purposes | ||
143 | * @status: used to pass error status to calling function | ||
144 | */ | ||
145 | struct zfcp_send_ct { | ||
146 | struct zfcp_fc_wka_port *wka_port; | ||
147 | struct scatterlist *req; | ||
148 | struct scatterlist *resp; | ||
149 | void (*handler)(unsigned long); | ||
150 | unsigned long handler_data; | ||
151 | struct completion *completion; | ||
152 | int status; | ||
153 | }; | ||
154 | |||
155 | /** | ||
156 | * struct zfcp_send_els - used to pass parameters to function zfcp_fsf_send_els | ||
157 | * @adapter: adapter where request is sent from | ||
158 | * @port: port where ELS is destinated (port reference count has to be increased) | ||
159 | * @d_id: destiniation id of port where request is sent to | ||
160 | * @req: scatter-gather list for request | ||
161 | * @resp: scatter-gather list for response | ||
162 | * @handler: handler function (called for response to the request) | ||
163 | * @handler_data: data passed to handler function | ||
164 | * @completion: completion for synchronization purposes | ||
165 | * @ls_code: hex code of ELS command | ||
166 | * @status: used to pass error status to calling function | ||
167 | */ | ||
168 | struct zfcp_send_els { | ||
169 | struct zfcp_adapter *adapter; | ||
170 | struct zfcp_port *port; | ||
171 | u32 d_id; | ||
172 | struct scatterlist *req; | ||
173 | struct scatterlist *resp; | ||
174 | void (*handler)(unsigned long); | ||
175 | unsigned long handler_data; | ||
176 | struct completion *completion; | ||
177 | int ls_code; | ||
178 | int status; | ||
179 | }; | ||
180 | |||
181 | struct zfcp_qdio_queue { | 135 | struct zfcp_qdio_queue { |
182 | struct qdio_buffer *sbal[QDIO_MAX_BUFFERS_PER_Q]; | 136 | struct qdio_buffer *sbal[QDIO_MAX_BUFFERS_PER_Q]; |
183 | u8 first; /* index of next free bfr in queue */ | 137 | u8 first; /* index of next free bfr in queue */ |