diff options
author | Christof Schmitt <christof.schmitt@de.ibm.com> | 2007-11-05 06:37:47 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-01-11 19:22:40 -0500 |
commit | 1de1b43b5f0bb536126e31f07ec833e01969ed1c (patch) | |
tree | 9908cfa46ab158be6890b2edf1c3b7362243a7f8 /drivers/s390/scsi/zfcp_aux.c | |
parent | e39c8877a41e8f70225baeeb74fade8fe3a80d8b (diff) |
[SCSI] zfcp: Fix deadlock when adding invalid LUN
When adding an invalid LUN, there is a deadlock between the add
via scsi_scan_target and the slave_destroy handler: The handler
waits for the scan to complete, but for an invalid unit,
scsi_scan_target directly calls the slave_destroy handler.
Fix the deadlock by removing the wait in the slave_destroy
handler, it was not necessary anyway.
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/s390/scsi/zfcp_aux.c')
-rw-r--r-- | drivers/s390/scsi/zfcp_aux.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c index 00118499018b..874b55ed00a3 100644 --- a/drivers/s390/scsi/zfcp_aux.c +++ b/drivers/s390/scsi/zfcp_aux.c | |||
@@ -844,8 +844,6 @@ zfcp_unit_enqueue(struct zfcp_port *port, fcp_lun_t fcp_lun) | |||
844 | unit->sysfs_device.release = zfcp_sysfs_unit_release; | 844 | unit->sysfs_device.release = zfcp_sysfs_unit_release; |
845 | dev_set_drvdata(&unit->sysfs_device, unit); | 845 | dev_set_drvdata(&unit->sysfs_device, unit); |
846 | 846 | ||
847 | init_waitqueue_head(&unit->scsi_scan_wq); | ||
848 | |||
849 | /* mark unit unusable as long as sysfs registration is not complete */ | 847 | /* mark unit unusable as long as sysfs registration is not complete */ |
850 | atomic_set_mask(ZFCP_STATUS_COMMON_REMOVE, &unit->status); | 848 | atomic_set_mask(ZFCP_STATUS_COMMON_REMOVE, &unit->status); |
851 | 849 | ||