aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390/net
diff options
context:
space:
mode:
authorPeter Oberparleiter <peter.oberparleiter@de.ibm.com>2011-10-30 10:16:04 -0400
committerMartin Schwidefsky <schwidefsky@de.ibm.com>2011-10-30 10:16:15 -0400
commitde400d6b78d15a73023485f050bc6b1709dc7a79 (patch)
tree2d2e7233a76982db4cf12ff0859054a33e46a911 /drivers/s390/net
parentce949717b559709423c1ef716a9db16d1dcadaed (diff)
[S390] fix mismatch in summation of I/O IRQ statistics
Current IRQ statistics support does not show detail counts for I/O interrupts which are processed internally only. The result is a summation count which is way off such as this one: CPU0 CPU1 CPU2 I/O: 1331 710 442 [...] QAI: 15 16 16 [I/O] QDIO Adapter Interrupt QDI: 1 0 0 [I/O] QDIO Interrupt DAS: 706 645 381 [I/O] DASD C15: 26 10 0 [I/O] 3215 C70: 0 0 0 [I/O] 3270 TAP: 0 0 0 [I/O] Tape VMR: 0 0 0 [I/O] Unit Record Devices LCS: 0 0 0 [I/O] LCS CLW: 0 0 0 [I/O] CLAW CTC: 0 0 0 [I/O] CTC APB: 0 0 0 [I/O] AP Bus Fix this by moving I/O interrupt accounting into the common I/O layer. Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/net')
-rw-r--r--drivers/s390/net/claw.c3
-rw-r--r--drivers/s390/net/ctcm_main.c3
-rw-r--r--drivers/s390/net/lcs.c3
3 files changed, 3 insertions, 6 deletions
diff --git a/drivers/s390/net/claw.c b/drivers/s390/net/claw.c
index f1fa2483ae6b..b41fae37d3af 100644
--- a/drivers/s390/net/claw.c
+++ b/drivers/s390/net/claw.c
@@ -63,7 +63,6 @@
63 63
64#define KMSG_COMPONENT "claw" 64#define KMSG_COMPONENT "claw"
65 65
66#include <linux/kernel_stat.h>
67#include <asm/ccwdev.h> 66#include <asm/ccwdev.h>
68#include <asm/ccwgroup.h> 67#include <asm/ccwgroup.h>
69#include <asm/debug.h> 68#include <asm/debug.h>
@@ -291,6 +290,7 @@ static struct ccw_driver claw_ccw_driver = {
291 .ids = claw_ids, 290 .ids = claw_ids,
292 .probe = ccwgroup_probe_ccwdev, 291 .probe = ccwgroup_probe_ccwdev,
293 .remove = ccwgroup_remove_ccwdev, 292 .remove = ccwgroup_remove_ccwdev,
293 .int_class = IOINT_CLW,
294}; 294};
295 295
296static ssize_t 296static ssize_t
@@ -645,7 +645,6 @@ claw_irq_handler(struct ccw_device *cdev,
645 struct claw_env *p_env; 645 struct claw_env *p_env;
646 struct chbk *p_ch_r=NULL; 646 struct chbk *p_ch_r=NULL;
647 647
648 kstat_cpu(smp_processor_id()).irqs[IOINT_CLW]++;
649 CLAW_DBF_TEXT(4, trace, "clawirq"); 648 CLAW_DBF_TEXT(4, trace, "clawirq");
650 /* Bypass all 'unsolicited interrupts' */ 649 /* Bypass all 'unsolicited interrupts' */
651 privptr = dev_get_drvdata(&cdev->dev); 650 privptr = dev_get_drvdata(&cdev->dev);
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index 426787efc492..5cb93a8e3403 100644
--- a/drivers/s390/net/ctcm_main.c
+++ b/drivers/s390/net/ctcm_main.c
@@ -24,7 +24,6 @@
24#define KMSG_COMPONENT "ctcm" 24#define KMSG_COMPONENT "ctcm"
25#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt 25#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
26 26
27#include <linux/kernel_stat.h>
28#include <linux/module.h> 27#include <linux/module.h>
29#include <linux/init.h> 28#include <linux/init.h>
30#include <linux/kernel.h> 29#include <linux/kernel.h>
@@ -1203,7 +1202,6 @@ static void ctcm_irq_handler(struct ccw_device *cdev,
1203 int cstat; 1202 int cstat;
1204 int dstat; 1203 int dstat;
1205 1204
1206 kstat_cpu(smp_processor_id()).irqs[IOINT_CTC]++;
1207 CTCM_DBF_TEXT_(TRACE, CTC_DBF_DEBUG, 1205 CTCM_DBF_TEXT_(TRACE, CTC_DBF_DEBUG,
1208 "Enter %s(%s)", CTCM_FUNTAIL, dev_name(&cdev->dev)); 1206 "Enter %s(%s)", CTCM_FUNTAIL, dev_name(&cdev->dev));
1209 1207
@@ -1769,6 +1767,7 @@ static struct ccw_driver ctcm_ccw_driver = {
1769 .ids = ctcm_ids, 1767 .ids = ctcm_ids,
1770 .probe = ccwgroup_probe_ccwdev, 1768 .probe = ccwgroup_probe_ccwdev,
1771 .remove = ccwgroup_remove_ccwdev, 1769 .remove = ccwgroup_remove_ccwdev,
1770 .int_class = IOINT_CTC,
1772}; 1771};
1773 1772
1774static struct ccwgroup_driver ctcm_group_driver = { 1773static struct ccwgroup_driver ctcm_group_driver = {
diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
index fb246b944b16..05fb3f7c7289 100644
--- a/drivers/s390/net/lcs.c
+++ b/drivers/s390/net/lcs.c
@@ -26,7 +26,6 @@
26#define KMSG_COMPONENT "lcs" 26#define KMSG_COMPONENT "lcs"
27#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt 27#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
28 28
29#include <linux/kernel_stat.h>
30#include <linux/module.h> 29#include <linux/module.h>
31#include <linux/if.h> 30#include <linux/if.h>
32#include <linux/netdevice.h> 31#include <linux/netdevice.h>
@@ -1399,7 +1398,6 @@ lcs_irq(struct ccw_device *cdev, unsigned long intparm, struct irb *irb)
1399 int rc, index; 1398 int rc, index;
1400 int cstat, dstat; 1399 int cstat, dstat;
1401 1400
1402 kstat_cpu(smp_processor_id()).irqs[IOINT_LCS]++;
1403 if (lcs_check_irb_error(cdev, irb)) 1401 if (lcs_check_irb_error(cdev, irb))
1404 return; 1402 return;
1405 1403
@@ -2399,6 +2397,7 @@ static struct ccw_driver lcs_ccw_driver = {
2399 .ids = lcs_ids, 2397 .ids = lcs_ids,
2400 .probe = ccwgroup_probe_ccwdev, 2398 .probe = ccwgroup_probe_ccwdev,
2401 .remove = ccwgroup_remove_ccwdev, 2399 .remove = ccwgroup_remove_ccwdev,
2400 .int_class = IOINT_LCS,
2402}; 2401};
2403 2402
2404/** 2403/**