diff options
author | Ursula Braun <braunu@de.ibm.com> | 2007-05-02 09:17:11 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-05-08 01:15:35 -0400 |
commit | a4c48a2691189cec0359ac13b41726d3005ef2f5 (patch) | |
tree | 751136ad57dcc75e3e0fea60db51d5090f26af50 /drivers/s390/net/qeth_main.c | |
parent | 1a14780960888c97371a9918f42c4dbe6957efb4 (diff) |
s390: qeth driver connection hang
Frank Pavlic <fpavlic@de.ibm.com>
Connection hangs when using EDDP mode because sk_protocol is NULL
when skb has been copied via skb_copy. This results in dropping
packets.
Also keep MAC address after recovery of Virtual NICs so that
traffic can flow again and duplicate statements in
qeth_dev_set_route_store removed.
Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Frank Pavlic <fpavlic@de.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/s390/net/qeth_main.c')
-rw-r--r-- | drivers/s390/net/qeth_main.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/s390/net/qeth_main.c b/drivers/s390/net/qeth_main.c index 6fd8870551d3..032483513027 100644 --- a/drivers/s390/net/qeth_main.c +++ b/drivers/s390/net/qeth_main.c | |||
@@ -4490,7 +4490,8 @@ qeth_send_packet(struct qeth_card *card, struct sk_buff *skb) | |||
4490 | qeth_fill_header(card, hdr, new_skb, ipv, cast_type); | 4490 | qeth_fill_header(card, hdr, new_skb, ipv, cast_type); |
4491 | } | 4491 | } |
4492 | if (large_send == QETH_LARGE_SEND_EDDP) { | 4492 | if (large_send == QETH_LARGE_SEND_EDDP) { |
4493 | ctx = qeth_eddp_create_context(card, new_skb, hdr); | 4493 | ctx = qeth_eddp_create_context(card, new_skb, hdr, |
4494 | skb->sk->sk_protocol); | ||
4494 | if (ctx == NULL) { | 4495 | if (ctx == NULL) { |
4495 | __qeth_free_new_skb(skb, new_skb); | 4496 | __qeth_free_new_skb(skb, new_skb); |
4496 | PRINT_WARN("could not create eddp context\n"); | 4497 | PRINT_WARN("could not create eddp context\n"); |
@@ -6651,7 +6652,7 @@ qeth_setadpparms_change_macaddr_cb(struct qeth_card *card, | |||
6651 | QETH_DBF_TEXT(trace,4,"chgmaccb"); | 6652 | QETH_DBF_TEXT(trace,4,"chgmaccb"); |
6652 | 6653 | ||
6653 | cmd = (struct qeth_ipa_cmd *) data; | 6654 | cmd = (struct qeth_ipa_cmd *) data; |
6654 | if (!card->options.layer2 || card->info.guestlan || | 6655 | if (!card->options.layer2 || |
6655 | !(card->info.mac_bits & QETH_LAYER2_MAC_READ)) { | 6656 | !(card->info.mac_bits & QETH_LAYER2_MAC_READ)) { |
6656 | memcpy(card->dev->dev_addr, | 6657 | memcpy(card->dev->dev_addr, |
6657 | &cmd->data.setadapterparms.data.change_addr.addr, | 6658 | &cmd->data.setadapterparms.data.change_addr.addr, |