qeth: synchronize configuration interface

Synchronize access to the drivers configuration interface.
Also do not allow configuration changes during online/offline
transition.

Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 135 insertions, 109 deletions

diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
index 25b3e7aae44f..fb5318b30e99 100644
--- a/drivers/s390/net/qeth_l3_sys.c
+++ b/drivers/s390/net/qeth_l3_sys.c
@@ -70,10 +70,10 @@ static ssize_t qeth_l3_dev_route_store(struct qeth_card *card,
 {
         enum qeth_routing_types old_route_type = route->type;
         char *tmp;
-        int rc;
+        int rc = 0;
 
         tmp = strsep((char **) &buf, "\n");
-
+        mutex_lock(&card->conf_mutex);
         if (!strcmp(tmp, "no_router")) {
                 route->type = NO_ROUTER;
         } else if (!strcmp(tmp, "primary_connector")) {
@@ -87,7 +87,8 @@ static ssize_t qeth_l3_dev_route_store(struct qeth_card *card,
         } else if (!strcmp(tmp, "multicast_router")) {
                 route->type = MULTICAST_ROUTER;
         } else {
-                return -EINVAL;
+                rc = -EINVAL;
+                goto out;
         }
         if (((card->state == CARD_STATE_SOFTSETUP) ||
              (card->state == CARD_STATE_UP)) &&
@@ -97,7 +98,9 @@ static ssize_t qeth_l3_dev_route_store(struct qeth_card *card,
                 else if (prot == QETH_PROT_IPV6)
                         rc = qeth_l3_setrouting_v6(card);
         }
-        return count;
+out:
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static ssize_t qeth_l3_dev_route4_store(struct device *dev,
@@ -157,22 +160,26 @@ static ssize_t qeth_l3_dev_fake_broadcast_store(struct device *dev,
 {
         struct qeth_card *card = dev_get_drvdata(dev);
         char *tmp;
-        int i;
+        int i, rc = 0;
 
         if (!card)
                 return -EINVAL;
 
+        mutex_lock(&card->conf_mutex);
         if ((card->state != CARD_STATE_DOWN) &&
-            (card->state != CARD_STATE_RECOVER))
-                return -EPERM;
+            (card->state != CARD_STATE_RECOVER)) {
+                rc = -EPERM;
+                goto out;
+        }
 
         i = simple_strtoul(buf, &tmp, 16);
         if ((i == 0) || (i == 1))
                 card->options.fake_broadcast = i;
-        else {
-                return -EINVAL;
-        }
-        return count;
+        else
+                rc = -EINVAL;
+out:
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static DEVICE_ATTR(fake_broadcast, 0644, qeth_l3_dev_fake_broadcast_show,
@@ -200,31 +207,35 @@ static ssize_t qeth_l3_dev_broadcast_mode_store(struct device *dev,
 {
         struct qeth_card *card = dev_get_drvdata(dev);
         char *tmp;
+        int rc = 0;
 
         if (!card)
                 return -EINVAL;
 
+        mutex_lock(&card->conf_mutex);
         if ((card->state != CARD_STATE_DOWN) &&
-            (card->state != CARD_STATE_RECOVER))
-                return -EPERM;
+            (card->state != CARD_STATE_RECOVER)) {
+                rc = -EPERM;
+                goto out;
+        }
 
         if (!((card->info.link_type == QETH_LINK_TYPE_HSTR) ||
               (card->info.link_type == QETH_LINK_TYPE_LANE_TR))) {
-                return -EINVAL;
+                rc = -EINVAL;
+                goto out;
         }
 
         tmp = strsep((char **) &buf, "\n");
 
-        if (!strcmp(tmp, "local")) {
+        if (!strcmp(tmp, "local"))
                 card->options.broadcast_mode = QETH_TR_BROADCAST_LOCAL;
-                return count;
-        } else if (!strcmp(tmp, "all_rings")) {
+        else if (!strcmp(tmp, "all_rings"))
                 card->options.broadcast_mode = QETH_TR_BROADCAST_ALLRINGS;
-                return count;
-        } else {
-                return -EINVAL;
-        }
-        return count;
+        else
+                rc = -EINVAL;
+out:
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static DEVICE_ATTR(broadcast_mode, 0644, qeth_l3_dev_broadcast_mode_show,
@@ -251,18 +262,22 @@ static ssize_t qeth_l3_dev_canonical_macaddr_store(struct device *dev,
 {
         struct qeth_card *card = dev_get_drvdata(dev);
         char *tmp;
-        int i;
+        int i, rc = 0;
 
         if (!card)
                 return -EINVAL;
 
+        mutex_lock(&card->conf_mutex);
         if ((card->state != CARD_STATE_DOWN) &&
-            (card->state != CARD_STATE_RECOVER))
-                return -EPERM;
+            (card->state != CARD_STATE_RECOVER)) {
+                rc = -EPERM;
+                goto out;
+        }
 
         if (!((card->info.link_type == QETH_LINK_TYPE_HSTR) ||
               (card->info.link_type == QETH_LINK_TYPE_LANE_TR))) {
-                return -EINVAL;
+                rc = -EINVAL;
+                goto out;
         }
 
         i = simple_strtoul(buf, &tmp, 16);
@@ -270,10 +285,11 @@ static ssize_t qeth_l3_dev_canonical_macaddr_store(struct device *dev,
                 card->options.macaddr_mode = i?
                         QETH_TR_MACADDR_CANONICAL :
                         QETH_TR_MACADDR_NONCANONICAL;
-        else {
-                return -EINVAL;
-        }
-        return count;
+        else
+                rc = -EINVAL;
+out:
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static DEVICE_ATTR(canonical_macaddr, 0644, qeth_l3_dev_canonical_macaddr_show,
@@ -297,11 +313,12 @@ static ssize_t qeth_l3_dev_checksum_store(struct device *dev,
         struct qeth_card *card = dev_get_drvdata(dev);
         enum qeth_checksum_types csum_type;
         char *tmp;
-        int rc;
+        int rc = 0;
 
         if (!card)
                 return -EINVAL;
 
+        mutex_lock(&card->conf_mutex);
         tmp = strsep((char **) &buf, "\n");
         if (!strcmp(tmp, "sw_checksumming"))
                 csum_type = SW_CHECKSUMMING;
@@ -309,13 +326,15 @@ static ssize_t qeth_l3_dev_checksum_store(struct device *dev,
                 csum_type = HW_CHECKSUMMING;
         else if (!strcmp(tmp, "no_checksumming"))
                 csum_type = NO_CHECKSUMMING;
-        else
-                return -EINVAL;
+        else {
+                rc = -EINVAL;
+                goto out;
+        }
 
         rc = qeth_l3_set_rx_csum(card, csum_type);
-        if (rc)
-                return rc;
-        return count;
+out:
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static DEVICE_ATTR(checksumming, 0644, qeth_l3_dev_checksum_show,
@@ -336,7 +355,7 @@ static ssize_t qeth_l3_dev_sniffer_store(struct device *dev,
                 struct device_attribute *attr, const char *buf, size_t count)
 {
         struct qeth_card *card = dev_get_drvdata(dev);
-        int ret;
+        int rc = 0;
         unsigned long i;
 
         if (!card)
@@ -345,19 +364,24 @@ static ssize_t qeth_l3_dev_sniffer_store(struct device *dev,
         if (card->info.type != QETH_CARD_TYPE_IQD)
                 return -EPERM;
 
+        mutex_lock(&card->conf_mutex);
         if ((card->state != CARD_STATE_DOWN) &&
-            (card->state != CARD_STATE_RECOVER))
-                return -EPERM;
+            (card->state != CARD_STATE_RECOVER)) {
+                rc = -EPERM;
+                goto out;
+        }
 
-        ret = strict_strtoul(buf, 16, &i);
-        if (ret)
-                return -EINVAL;
+        rc = strict_strtoul(buf, 16, &i);
+        if (rc) {
+                rc = -EINVAL;
+                goto out;
+        }
         switch (i) {
         case 0:
                 card->options.sniffer = i;
                 break;
         case 1:
-                ret = qdio_get_ssqd_desc(CARD_DDEV(card), &card->ssqd);
+                qdio_get_ssqd_desc(CARD_DDEV(card), &card->ssqd);
                 if (card->ssqd.qdioac2 & QETH_SNIFF_AVAIL) {
                         card->options.sniffer = i;
                         if (card->qdio.init_pool.buf_count !=
@@ -366,11 +390,13 @@ static ssize_t qeth_l3_dev_sniffer_store(struct device *dev,
                                         QETH_IN_BUF_COUNT_MAX);
                         break;
                 } else
-                        return -EPERM;
+                        rc = -EPERM;
         default:   /* fall through */
-                return -EINVAL;
+                rc = -EINVAL;
         }
-        return count;
+out:
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static DEVICE_ATTR(sniffer, 0644, qeth_l3_dev_sniffer_show,
@@ -412,12 +438,11 @@ static ssize_t qeth_l3_dev_large_send_store(struct device *dev,
         else
                 return -EINVAL;
 
-        if (card->options.large_send == type)
-                return count;
-        rc = qeth_l3_set_large_send(card, type);
-        if (rc)
-                return rc;
-        return count;
+        mutex_lock(&card->conf_mutex);
+        if (card->options.large_send != type)
+                rc = qeth_l3_set_large_send(card, type);
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static DEVICE_ATTR(large_send, 0644, qeth_l3_dev_large_send_show,
@@ -455,13 +480,17 @@ static ssize_t qeth_l3_dev_ipato_enable_store(struct device *dev,
 {
         struct qeth_card *card = dev_get_drvdata(dev);
         char *tmp;
+        int rc = 0;
 
         if (!card)
                 return -EINVAL;
 
+        mutex_lock(&card->conf_mutex);
         if ((card->state != CARD_STATE_DOWN) &&
-            (card->state != CARD_STATE_RECOVER))
-                return -EPERM;
+            (card->state != CARD_STATE_RECOVER)) {
+                rc = -EPERM;
+                goto out;
+        }
 
         tmp = strsep((char **) &buf, "\n");
         if (!strcmp(tmp, "toggle")) {
@@ -470,10 +499,11 @@ static ssize_t qeth_l3_dev_ipato_enable_store(struct device *dev,
                 card->ipato.enabled = 1;
         } else if (!strcmp(tmp, "0")) {
                 card->ipato.enabled = 0;
-        } else {
-                return -EINVAL;
-        }
-        return count;
+        } else
+                rc = -EINVAL;
+out:
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static QETH_DEVICE_ATTR(ipato_enable, enable, 0644,
@@ -497,10 +527,12 @@ static ssize_t qeth_l3_dev_ipato_invert4_store(struct device *dev,
 {
         struct qeth_card *card = dev_get_drvdata(dev);
         char *tmp;
+        int rc = 0;
 
         if (!card)
                 return -EINVAL;
 
+        mutex_lock(&card->conf_mutex);
         tmp = strsep((char **) &buf, "\n");
         if (!strcmp(tmp, "toggle")) {
                 card->ipato.invert4 = (card->ipato.invert4)? 0 : 1;
@@ -508,10 +540,10 @@ static ssize_t qeth_l3_dev_ipato_invert4_store(struct device *dev,
                 card->ipato.invert4 = 1;
         } else if (!strcmp(tmp, "0")) {
                 card->ipato.invert4 = 0;
-        } else {
-                return -EINVAL;
-        }
-        return count;
+        } else
+                rc = -EINVAL;
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static QETH_DEVICE_ATTR(ipato_invert4, invert4, 0644,
@@ -593,27 +625,28 @@ static ssize_t qeth_l3_dev_ipato_add_store(const char *buf, size_t count,
         struct qeth_ipato_entry *ipatoe;
         u8 addr[16];
         int mask_bits;
-        int rc;
+        int rc = 0;
 
+        mutex_lock(&card->conf_mutex);
         rc = qeth_l3_parse_ipatoe(buf, proto, addr, &mask_bits);
         if (rc)
-                return rc;
+                goto out;
 
         ipatoe = kzalloc(sizeof(struct qeth_ipato_entry), GFP_KERNEL);
         if (!ipatoe) {
-                return -ENOMEM;
+                rc = -ENOMEM;
+                goto out;
         }
         ipatoe->proto = proto;
         memcpy(ipatoe->addr, addr, (proto == QETH_PROT_IPV4)? 4:16);
         ipatoe->mask_bits = mask_bits;
 
         rc = qeth_l3_add_ipato_entry(card, ipatoe);
-        if (rc) {
+        if (rc)
                 kfree(ipatoe);
-                return rc;
-        }
-
-        return count;
+out:
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static ssize_t qeth_l3_dev_ipato_add4_store(struct device *dev,
@@ -636,15 +669,14 @@ static ssize_t qeth_l3_dev_ipato_del_store(const char *buf, size_t count,
 {
         u8 addr[16];
         int mask_bits;
-        int rc;
+        int rc = 0;
 
+        mutex_lock(&card->conf_mutex);
         rc = qeth_l3_parse_ipatoe(buf, proto, addr, &mask_bits);
-        if (rc)
-                return rc;
-
-        qeth_l3_del_ipato_entry(card, proto, addr, mask_bits);
-
-        return count;
+        if (!rc)
+                qeth_l3_del_ipato_entry(card, proto, addr, mask_bits);
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static ssize_t qeth_l3_dev_ipato_del4_store(struct device *dev,
@@ -677,10 +709,12 @@ static ssize_t qeth_l3_dev_ipato_invert6_store(struct device *dev,
 {
         struct qeth_card *card = dev_get_drvdata(dev);
         char *tmp;
+        int rc = 0;
 
         if (!card)
                 return -EINVAL;
 
+        mutex_lock(&card->conf_mutex);
         tmp = strsep((char **) &buf, "\n");
         if (!strcmp(tmp, "toggle")) {
                 card->ipato.invert6 = (card->ipato.invert6)? 0 : 1;
@@ -688,10 +722,10 @@ static ssize_t qeth_l3_dev_ipato_invert6_store(struct device *dev,
                 card->ipato.invert6 = 1;
         } else if (!strcmp(tmp, "0")) {
                 card->ipato.invert6 = 0;
-        } else {
-                return -EINVAL;
-        }
-        return count;
+        } else
+                rc = -EINVAL;
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static QETH_DEVICE_ATTR(ipato_invert6, invert6, 0644,
@@ -813,15 +847,12 @@ static ssize_t qeth_l3_dev_vipa_add_store(const char *buf, size_t count,
         u8 addr[16] = {0, };
         int rc;
 
+        mutex_lock(&card->conf_mutex);
         rc = qeth_l3_parse_vipae(buf, proto, addr);
-        if (rc)
-                return rc;
-
-        rc = qeth_l3_add_vipa(card, proto, addr);
-        if (rc)
-                return rc;
-
-        return count;
+        if (!rc)
+                rc = qeth_l3_add_vipa(card, proto, addr);
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static ssize_t qeth_l3_dev_vipa_add4_store(struct device *dev,
@@ -845,13 +876,12 @@ static ssize_t qeth_l3_dev_vipa_del_store(const char *buf, size_t count,
         u8 addr[16];
         int rc;
 
+        mutex_lock(&card->conf_mutex);
         rc = qeth_l3_parse_vipae(buf, proto, addr);
-        if (rc)
-                return rc;
-
-        qeth_l3_del_vipa(card, proto, addr);
-
-        return count;
+        if (!rc)
+                qeth_l3_del_vipa(card, proto, addr);
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static ssize_t qeth_l3_dev_vipa_del4_store(struct device *dev,
@@ -979,15 +1009,12 @@ static ssize_t qeth_l3_dev_rxip_add_store(const char *buf, size_t count,
         u8 addr[16] = {0, };
         int rc;
 
+        mutex_lock(&card->conf_mutex);
         rc = qeth_l3_parse_rxipe(buf, proto, addr);
-        if (rc)
-                return rc;
-
-        rc = qeth_l3_add_rxip(card, proto, addr);
-        if (rc)
-                return rc;
-
-        return count;
+        if (!rc)
+                rc = qeth_l3_add_rxip(card, proto, addr);
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static ssize_t qeth_l3_dev_rxip_add4_store(struct device *dev,
@@ -1011,13 +1038,12 @@ static ssize_t qeth_l3_dev_rxip_del_store(const char *buf, size_t count,
         u8 addr[16];
         int rc;
 
+        mutex_lock(&card->conf_mutex);
         rc = qeth_l3_parse_rxipe(buf, proto, addr);
-        if (rc)
-                return rc;
-
-        qeth_l3_del_rxip(card, proto, addr);
-
-        return count;
+        if (!rc)
+                qeth_l3_del_rxip(card, proto, addr);
+        mutex_unlock(&card->conf_mutex);
+        return rc ? rc : count;
 }
 
 static ssize_t qeth_l3_dev_rxip_del4_store(struct device *dev,