ctcm: fix minor findings from code analysis tool

From: Ursula Braun <ursula.braun@de.ibm.com>

This patch fixes problems in the ctcm driver identified by
static code analysis:
o remove an unnecessary always true condition in ctcm_unpack_skb
o remove duplicate assignment in ctc_mpc_alloc_channel
o remove an unnecessary always true condition in ctcmpc_send_sweep_resp
o remove duplicate initialization in ctcmpc_unpack_skb
o shorten if condition in mpc_action_go_inop
o remove INOP event if mpc group is undefined in mpc_action_doxid7

Signed-off-by: Joel A. Fowler <fowlerja@us.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 5 deletions

diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index a7a25383db76..77f4033a0f4f 100644
--- a/drivers/s390/net/ctcm_main.c
+++ b/drivers/s390/net/ctcm_main.c
@@ -168,11 +168,9 @@ void ctcm_unpack_skb(struct channel *ch, struct sk_buff *pskb)
                 if (len > 0) {
                         skb_pull(pskb, header->length);
                         if (skb_tailroom(pskb) < LL_HEADER_LENGTH) {
-                                if (!(ch->logflags & LOG_FLAG_OVERRUN)) {
-                                        CTCM_DBF_DEV_NAME(TRACE, dev,
-                                                "Overrun in ctcm_unpack_skb");
-                                        ch->logflags |= LOG_FLAG_OVERRUN;
-                                }
+                                CTCM_DBF_DEV_NAME(TRACE, dev,
+                                        "Overrun in ctcm_unpack_skb");
+                                ch->logflags |= LOG_FLAG_OVERRUN;
                                 return;
                         }
                         skb_put(pskb, LL_HEADER_LENGTH);