aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390/cio/device.c
diff options
context:
space:
mode:
authorCornelia Huck <cornelia.huck@de.ibm.com>2007-10-12 10:11:26 -0400
committerMartin Schwidefsky <schwidefsky@de.ibm.com>2007-10-12 10:13:02 -0400
commit3f4cf6e72f9f6a0b046b32881acc4f829f3aaa46 (patch)
tree84302932647aed49fa65b506fd0f5652af276915 /drivers/s390/cio/device.c
parent3952c8d43aa23862181ad23ecdf72895b4be3143 (diff)
[S390] cio: Avoid machine check vs. not operational races.
There was the possibilty that an action like ccw_device_set_offline() triggered by a device gone machine check might trigger a not oper event. Unfortunately, this could lead to the situation that we tried to unregister a subchannel twice: Once from the slow path evaluation, and once via the not oper event. Fix this by always using the same mechanism (css_schedule_eval()) for triggering the unregister. This makes sure that unregistration will only be done once. As an added bonus, it also simplyfies the code. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/cio/device.c')
-rw-r--r--drivers/s390/cio/device.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/s390/cio/device.c b/drivers/s390/cio/device.c
index c96380db0136..39f02b48e4c7 100644
--- a/drivers/s390/cio/device.c
+++ b/drivers/s390/cio/device.c
@@ -969,8 +969,7 @@ out:
969 wake_up(&ccw_device_init_wq); 969 wake_up(&ccw_device_init_wq);
970} 970}
971 971
972void 972static void ccw_device_call_sch_unregister(struct work_struct *work)
973ccw_device_call_sch_unregister(struct work_struct *work)
974{ 973{
975 struct ccw_device_private *priv; 974 struct ccw_device_private *priv;
976 struct ccw_device *cdev; 975 struct ccw_device *cdev;