diff options
author | Cornelia Huck <cornelia.huck@de.ibm.com> | 2007-07-27 06:29:19 -0400 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2007-07-27 06:29:19 -0400 |
commit | e556bbbd9d2ff2b158915945ac82e2ac7def4d2f (patch) | |
tree | 023ed3bc586284f2acb8e754b9eb4171f54b0f2c /drivers/s390/cio/chp.c | |
parent | b771aeac32a320ac52bc227252103d7d7fc48cad (diff) |
[S390] cio: Clean up messages.
- Remove unneeded messages.
- Move some messages into the debug feature.
- Use dev_* where appropriate.
- Use "cio: " prefix consistently.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/cio/chp.c')
-rw-r--r-- | drivers/s390/cio/chp.c | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/drivers/s390/cio/chp.c b/drivers/s390/cio/chp.c index b57d93d986c0..920dd71e6434 100644 --- a/drivers/s390/cio/chp.c +++ b/drivers/s390/cio/chp.c | |||
@@ -121,14 +121,8 @@ static int s390_vary_chpid(struct chp_id chpid, int on) | |||
121 | CIO_TRACE_EVENT( 2, dbf_text); | 121 | CIO_TRACE_EVENT( 2, dbf_text); |
122 | 122 | ||
123 | status = chp_get_status(chpid); | 123 | status = chp_get_status(chpid); |
124 | if (status < 0) { | ||
125 | printk(KERN_ERR "Can't vary unknown chpid %x.%02x\n", | ||
126 | chpid.cssid, chpid.id); | ||
127 | return -EINVAL; | ||
128 | } | ||
129 | |||
130 | if (!on && !status) { | 124 | if (!on && !status) { |
131 | printk(KERN_ERR "chpid %x.%02x is already offline\n", | 125 | printk(KERN_ERR "cio: chpid %x.%02x is already offline\n", |
132 | chpid.cssid, chpid.id); | 126 | chpid.cssid, chpid.id); |
133 | return -EINVAL; | 127 | return -EINVAL; |
134 | } | 128 | } |
@@ -421,21 +415,14 @@ int chp_new(struct chp_id chpid) | |||
421 | if (ret) | 415 | if (ret) |
422 | goto out_free; | 416 | goto out_free; |
423 | } else { | 417 | } else { |
424 | static int msg_done; | ||
425 | |||
426 | if (!msg_done) { | ||
427 | printk(KERN_WARNING "cio: Channel measurements not " | ||
428 | "available, continuing.\n"); | ||
429 | msg_done = 1; | ||
430 | } | ||
431 | chp->cmg = -1; | 418 | chp->cmg = -1; |
432 | } | 419 | } |
433 | 420 | ||
434 | /* make it known to the system */ | 421 | /* make it known to the system */ |
435 | ret = device_register(&chp->dev); | 422 | ret = device_register(&chp->dev); |
436 | if (ret) { | 423 | if (ret) { |
437 | printk(KERN_WARNING "%s: could not register %x.%02x\n", | 424 | CIO_MSG_EVENT(0, "Could not register chp%x.%02x: %d\n", |
438 | __func__, chpid.cssid, chpid.id); | 425 | chpid.cssid, chpid.id, ret); |
439 | goto out_free; | 426 | goto out_free; |
440 | } | 427 | } |
441 | ret = sysfs_create_group(&chp->dev.kobj, &chp_attr_group); | 428 | ret = sysfs_create_group(&chp->dev.kobj, &chp_attr_group); |