aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390/char
diff options
context:
space:
mode:
authorJeff Dike <jdike@addtoit.com>2006-10-02 05:17:18 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-10-02 10:57:14 -0400
commitb68e31d0ebbcc909d1941f9f230c9d062a3a13d3 (patch)
treeb32902e5de02081cbb9eca49d7bb0b444e2b4f23 /drivers/s390/char
parented97bd37efd8ff7398d3a7eedf4bcbf245f5dad3 (diff)
[PATCH] const struct tty_operations
As part of an SMP cleanliness pass over UML, I consted a bunch of structures in order to not have to document their locking. One of these structures was a struct tty_operations. In order to const it in UML without introducing compiler complaints, the declaration of tty_set_operations needs to be changed, and then all of its callers need to be fixed. This patch declares all struct tty_operations in the tree as const. In all cases, they are static and used only as input to tty_set_operations. As an extra check, I ran an i386 allyesconfig build which produced no extra warnings. 53 drivers are affected. I checked the history of a bunch of them, and in most cases, there have been only a handful of maintenance changes in the last six months. serial_core.c was the busiest one that I looked at. Signed-off-by: Jeff Dike <jdike@addtoit.com> Acked-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/s390/char')
-rw-r--r--drivers/s390/char/con3215.c2
-rw-r--r--drivers/s390/char/sclp_tty.c2
-rw-r--r--drivers/s390/char/sclp_vt220.c2
-rw-r--r--drivers/s390/char/tty3270.c2
4 files changed, 4 insertions, 4 deletions
diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
index 2fa566fa6da4..d7de175d53f0 100644
--- a/drivers/s390/char/con3215.c
+++ b/drivers/s390/char/con3215.c
@@ -1103,7 +1103,7 @@ tty3215_start(struct tty_struct *tty)
1103 } 1103 }
1104} 1104}
1105 1105
1106static struct tty_operations tty3215_ops = { 1106static const struct tty_operations tty3215_ops = {
1107 .open = tty3215_open, 1107 .open = tty3215_open,
1108 .close = tty3215_close, 1108 .close = tty3215_close,
1109 .write = tty3215_write, 1109 .write = tty3215_write,
diff --git a/drivers/s390/char/sclp_tty.c b/drivers/s390/char/sclp_tty.c
index f6cf9023039e..6f43e04dbefd 100644
--- a/drivers/s390/char/sclp_tty.c
+++ b/drivers/s390/char/sclp_tty.c
@@ -711,7 +711,7 @@ static struct sclp_register sclp_input_event =
711 .receiver_fn = sclp_tty_receiver 711 .receiver_fn = sclp_tty_receiver
712}; 712};
713 713
714static struct tty_operations sclp_ops = { 714static const struct tty_operations sclp_ops = {
715 .open = sclp_tty_open, 715 .open = sclp_tty_open,
716 .close = sclp_tty_close, 716 .close = sclp_tty_close,
717 .write = sclp_tty_write, 717 .write = sclp_tty_write,
diff --git a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
index 54fba6f17188..723bf4191bfe 100644
--- a/drivers/s390/char/sclp_vt220.c
+++ b/drivers/s390/char/sclp_vt220.c
@@ -655,7 +655,7 @@ __sclp_vt220_init(int early)
655 return 0; 655 return 0;
656} 656}
657 657
658static struct tty_operations sclp_vt220_ops = { 658static const struct tty_operations sclp_vt220_ops = {
659 .open = sclp_vt220_open, 659 .open = sclp_vt220_open,
660 .close = sclp_vt220_close, 660 .close = sclp_vt220_close,
661 .write = sclp_vt220_write, 661 .write = sclp_vt220_write,
diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c
index 06e2eeec8473..4717c3611601 100644
--- a/drivers/s390/char/tty3270.c
+++ b/drivers/s390/char/tty3270.c
@@ -1737,7 +1737,7 @@ tty3270_ioctl(struct tty_struct *tty, struct file *file,
1737 return kbd_ioctl(tp->kbd, file, cmd, arg); 1737 return kbd_ioctl(tp->kbd, file, cmd, arg);
1738} 1738}
1739 1739
1740static struct tty_operations tty3270_ops = { 1740static const struct tty_operations tty3270_ops = {
1741 .open = tty3270_open, 1741 .open = tty3270_open,
1742 .close = tty3270_close, 1742 .close = tty3270_close,
1743 .write = tty3270_write, 1743 .write = tty3270_write,